Update Slowvote to use sensible string constants for response visibility
ClosedPublic
Actions

Authored by epriestley on May 26 2022, 4:58 PM.

Details

Reviewers: None
Maniphest Tasks: T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default"
Commits: rP9f075839a23f: Update Slowvote to use sensible string constants for response visibility

Summary

Ref T13682. Migrate and update Slowvote to use API-friendly string constants for response visibility, not opaque integers.

Test Plan

Created and edited slowvotes, changing response visibility.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.May 26 2022, 4:58 PM

Owners added a subscriber: Restricted Owners Package.May 26 2022, 4:58 PM

epriestley requested review of this revision.May 26 2022, 4:58 PM

Harbormaster completed remote builds in B25751: Diff 52061.May 26 2022, 4:58 PM

This revision was not accepted when it landed; it landed in state Needs Review.May 26 2022, 4:58 PM

Closed by commit rP9f075839a23f: Update Slowvote to use sensible string constants for response visibility (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP9f075839a23f: Update Slowvote to use sensible string constants for response visibility.

Revision Contents
Changeset List

Path

Size

resources/

sql/

autopatches/

20220525.slowvote.03.response-type.sql

3 lines

20220525.slowvote.04.response-value.sql

8 lines

20220525.slowvote.05.response-xactions.sql

23 lines

src/

applications/

slowvote/

constants/

SlowvotePollResponseVisibility.php

8 lines

controller/

PhabricatorSlowvoteEditController.php

11 lines

storage/

PhabricatorSlowvotePoll.php

2 lines

view/

SlowvoteEmbedView.php

4 lines

xaction/

PhabricatorSlowvoteResponsesTransaction.php

6 lines

Diff 52063

View Options

resources/sql/autopatches/20220525.slowvote.03.response-type.sql

View Options

resources/sql/autopatches/20220525.slowvote.04.response-value.sql

View Options

resources/sql/autopatches/20220525.slowvote.05.response-xactions.sql

View Options

src/applications/slowvote/constants/SlowvotePollResponseVisibility.php

View Options

src/applications/slowvote/controller/PhabricatorSlowvoteEditController.php

View Options

src/applications/slowvote/storage/PhabricatorSlowvotePoll.php

View Options

src/applications/slowvote/view/SlowvoteEmbedView.php

View Options

src/applications/slowvote/xaction/PhabricatorSlowvoteResponsesTransaction.php

Update Slowvote to use sensible string constants for response visibilityClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 52063

resources/sql/autopatches/20220525.slowvote.03.response-type.sql

resources/sql/autopatches/20220525.slowvote.04.response-value.sql

resources/sql/autopatches/20220525.slowvote.05.response-xactions.sql

src/applications/slowvote/constants/SlowvotePollResponseVisibility.php

src/applications/slowvote/controller/PhabricatorSlowvoteEditController.php

src/applications/slowvote/storage/PhabricatorSlowvotePoll.php

src/applications/slowvote/view/SlowvoteEmbedView.php

src/applications/slowvote/xaction/PhabricatorSlowvoteResponsesTransaction.php

Update Slowvote to use sensible string constants for response visibility
ClosedPublic
Actions

Revision Contents
Changeset List