Differential D20825

Add an "{anchor #xyz}" rule to Remarkup
ClosedPublic
Actions

Authored by epriestley on Sep 24 2019, 5:26 PM.

Tags

None

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T4280: Embed anchor in remark up text and later link to it.
T13410: Update Phriction UI structural behaviors
Commits: rPb1d4d5c00ce1: Add an "{anchor #xyz}" rule to Remarkup

Summary

Ref T13410. Fixes T4280. Allows you to put a named anchor into a document explicitly.

Test Plan

Used {anchor ...} in Remarkup, used location bar to jump to anchors.

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Sep 24 2019, 5:26 PM

Harbormaster completed remote builds in B23476: Diff 49649.Sep 24 2019, 5:27 PM

epriestley requested review of this revision.Sep 24 2019, 5:27 PM

This revision was not accepted when it landed; it landed in state Needs Review.Sep 24 2019, 6:04 PM

Closed by commit rPb1d4d5c00ce1: Add an "{anchor #xyz}" rule to Remarkup (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPb1d4d5c00ce1: Add an "{anchor #xyz}" rule to Remarkup.

Revision Contents
Changeset List

			Path	Packages
M			src/__phutil_library_map__.php (2 lines)
M			src/docs/user/userguide/remarkup.diviner (12 lines)
M			src/infrastructure/markup/PhabricatorMarkupEngine.php (1 line)
M			src/infrastructure/markup/blockrule/PhutilRemarkupHeaderBlockRule.php (7 lines)
A	M		src/infrastructure/markup/markuprule/PhutilRemarkupAnchorRule.php (69 lines)

Diff 49655

src/__phutil_library_map__.php

Loading...

src/docs/user/userguide/remarkup.diviner

Loading...

src/infrastructure/markup/PhabricatorMarkupEngine.php

Loading...

src/infrastructure/markup/blockrule/PhutilRemarkupHeaderBlockRule.php

Loading...

src/infrastructure/markup/markuprule/PhutilRemarkupAnchorRule.php

Loading...