Differential D20510

When a user pastes a Phabricator URI into the search box, redirect to the URI
ClosedPublic
Actions

Authored by epriestley on May 9 2019, 6:23 PM.

Details

Reviewers

amckinley
joshuaspence

Maniphest Tasks

T5378: Phabricator full task URLs for that instance do not provide hover/popup text (like T1234 does)

Summary

Depends on D20509. See PHI1224. Ref T5378. With some frequency, I paste URIs into the global search input (I am dumb).

When I do this dumb thing, redirect to the URI as though the global search was a URI bar.

Maybe only I am dumb like this, but I don't think it'll hurt anything.

Test Plan

pasted a URI and hit return; tried to eat a rock

Diff Detail

Repository

rP Phabricator

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.May 9 2019, 6:23 PM

Harbormaster completed remote builds in B22776: Diff 48903.May 9 2019, 6:24 PM

epriestley requested review of this revision.May 9 2019, 6:24 PM

epriestley added a child revision: D20512: Specialize rendering of self-URIs in the form "/X123".May 9 2019, 8:34 PM

joshuaspence accepted this revision.May 14 2019, 12:39 AM

This revision is now accepted and ready to land.May 14 2019, 12:39 AM

Closed by commit rP706826bf022f: When a user pastes a Phabricator URI into the search box, redirect to the URI (authored by epriestley). · Explain WhyMay 16 2019, 6:20 PM

This revision was automatically updated to reflect the committed changes.

epriestley added an edge: rP706826bf022f: When a user pastes a Phabricator URI into the search box, redirect to the URI.

Revision Contents
Changeset List

			Path	Packages
M			src/__phutil_library_map__.php (2 lines)
A	M		src/applications/meta/engineextension/PhabricatorDatasourceURIEngineExtension.php (34 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	48903	68098ce		May 9 2019, 6:22 PM	★	★
Diff 2	48939	f2feb03	rP706826bf022f0e98797c4d3a5fd7c1360d4515f9	May 16 2019, 6:19 PM	★	★

Status	Author	Revision
Closed	epriestley	D20512 Specialize rendering of self-URIs in the form "/X123"
Closed	epriestley	D20510 When a user pastes a Phabricator URI into the search box, redirect to the URI
Closed	epriestley	D20509 Remove ancient "PhabricatorQuickSearchEngineExtension" compatibility class

Diff 48939

View Options

src/__phutil_library_map__.php