Differential D20971

Respect linebreaks in full HTML tables in Remarkup
ClosedPublic
Actions

Authored by epriestley on Feb 6 2020, 10:53 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Nov 19, 7:45 AM

	Unknown Object (File)
	Mon, Nov 18, 7:57 PM

	Unknown Object (File)
	Sat, Nov 16, 2:36 PM

	Unknown Object (File)
	Oct 9 2024, 12:52 PM

	Unknown Object (File)
	Oct 6 2024, 10:21 PM

	Unknown Object (File)
	Oct 4 2024, 9:04 PM

	Unknown Object (File)
	Oct 2 2024, 12:44 AM

	Unknown Object (File)
	Sep 17 2024, 1:53 PM

View All Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T5427: Force a line break in a table cell
Commits: rP2327578adc94: Respect linebreaks in full HTML tables in Remarkup

Summary

Fixes T5427. See PHI1630. See also T13160 and D20568.

In the full HTML table syntax with "<table>", respect linebreaks as literals inside "<td>" cells.

Test Plan

Previewed some full-HTML tables with and without linebreaks, saw what seemed like sensible rendering behavior.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Feb 6 2020, 10:53 PM

Harbormaster completed remote builds in B23793: Diff 49968.Feb 6 2020, 10:54 PM

epriestley requested review of this revision.Feb 6 2020, 10:54 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 6 2020, 11:01 PM

Closed by commit rP2327578adc94: Respect linebreaks in full HTML tables in Remarkup (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP2327578adc94: Respect linebreaks in full HTML tables in Remarkup.

Revision Contents
Changeset List

Path

Size

src/

infrastructure/

markup/

blockrule/

PhutilRemarkupTableBlockRule.php

13 lines

Diff 49969

View Options

src/infrastructure/markup/blockrule/PhutilRemarkupTableBlockRule.php

Respect linebreaks in full HTML tables in RemarkupClosedPublicActions