Page MenuHomePhabricator
Differential D20971

Respect linebreaks in full HTML tables in Remarkup
ClosedPublic
Actions

Authored by epriestley on Feb 6 2020, 10:53 PM.
Tags
None
Referenced Files
F18082823: D20971.diff
Tue, Aug 5, 7:35 AM
F17803788: D20971.id49969.diff
Fri, Jul 25, 10:37 AM
F17769191: D20971.id49968.diff
Wed, Jul 23, 8:23 AM
F17757869: D20971.id.diff
Tue, Jul 22, 4:32 PM
Unknown Object (File)
Jun 27 2025, 9:44 PM
Unknown Object (File)
Jun 5 2025, 4:45 PM
Unknown Object (File)
May 29 2025, 9:40 AM
Unknown Object (File)
Apr 13 2025, 6:28 AM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T5427: Force a line break in a table cell
Commits
rP2327578adc94: Respect linebreaks in full HTML tables in Remarkup
Summary

Fixes T5427. See PHI1630. See also T13160 and D20568.

In the full HTML table syntax with "<table>", respect linebreaks as literals inside "<td>" cells.

Test Plan

Previewed some full-HTML tables with and without linebreaks, saw what seemed like sensible rendering behavior.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Feb 6 2020, 10:53 PM
Harbormaster completed remote builds in B23793: Diff 49968.Feb 6 2020, 10:54 PM
epriestley requested review of this revision.Feb 6 2020, 10:54 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 6 2020, 11:01 PM
Closed by commit rP2327578adc94: Respect linebreaks in full HTML tables in Remarkup (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP2327578adc94: Respect linebreaks in full HTML tables in Remarkup.

Revision Contents
Changeset List

PathSize
src/
infrastructure/
markup/
blockrule/
13 lines

Diff 49969

View Options

src/infrastructure/markup/blockrule/PhutilRemarkupTableBlockRule.php

Loading...
Phabricator · Built by Phacility