Differential D20954

Don't use "line-through" style for completed items in remarkup checklists
ClosedPublic
Actions

Authored by epriestley on Jan 29 2020, 4:53 PM.

Tags

None

Referenced Files

	F18389333: D20954.id49921.diff
	Fri, Aug 29, 5:42 AM

	F18389323: D20954.id49921.diff
	Fri, Aug 29, 5:41 AM

	F18351023: D20954.diff
	Tue, Aug 26, 9:28 PM

	F18207731: D20954.id49922.diff
	Mon, Aug 18, 7:21 PM

	F18194486: D20954.id49921.diff
	Sun, Aug 17, 10:35 AM

	F18101537: D20954.id49922.diff
	Sat, Aug 9, 2:18 PM

	F18100840: D20954.diff
	Sat, Aug 9, 12:07 PM

	F18100161: D20954.id.diff
	Sat, Aug 9, 11:31 AM

View All Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13482: Remove strikethru style from checked-off Remarkup list items
Commits: rP7a1681b8dae1: Don't use "line-through" style for completed items in remarkup checklists

Summary

Fixes T13482. Although this style makes physical sense by relationship to a written checklist, it seems to do more harm than good in practice.

Test Plan

Wrote a checklist with a checked-off item in remarkup, saw no more line-through.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Jan 29 2020, 4:53 PM

Harbormaster completed remote builds in B23747: Diff 49921.Jan 29 2020, 4:55 PM

epriestley requested review of this revision.Jan 29 2020, 4:55 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jan 29 2020, 4:59 PM

Closed by commit rP7a1681b8dae1: Don't use "line-through" style for completed items in remarkup checklists (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP7a1681b8dae1: Don't use "line-through" style for completed items in remarkup checklists.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

webroot/

rsrc/

css/

core/

remarkup.css

1 line

Diff 49922

View Options

resources/celerity/map.php