Page MenuHomePhabricator

Implement a "{src ...}" rule in Remarkup for referencing source files in Diffusion
Open, NormalPublic


See PHI1224, which requests support for linking to source files in a way that makes access via an external editor easier.

Previously, see T5378. My plan of attack here is:

  • Convert existing Doorkeeper rules (JIRA and Asana) to use the new extension point. See also T13285.
  • Begin recognizing and specializing the rendering of full URIs, similar to how URIs are now specialized.
  • Provide an alternate mechanism for this rendering rule, {src ...}.
  • Add options to control layout and behavior.

Once this lands, both {src ...} and the new uri, {uri}, and <uri> rules should be documented.


Event Timeline

epriestley triaged this task as Normal priority.May 17 2019, 2:22 PM
epriestley created this task.
epriestley updated the task description. (Show Details)May 17 2019, 3:13 PM
epriestley updated the task description. (Show Details)May 19 2019, 8:48 PM

See also T13290. Now that full URIs count as mentions (D20527), the text "Differential Revision: ..." in commits is counting as a mention, and "mentioning" the associated revision.

This isn't too harmful but is silly, and should get cleaned up.

epriestley moved this task from Backlog to Next on the Remarkup board.May 23 2019, 2:45 PM

See PHI1312. The modified JIRA rules reportedly misfire on URIs with anchors or parameters. For now, the plan is to just skip these URIs. In the future, we might specialize URIs which (for example) link to comments on foreign objects.