Page MenuHomePhabricator
Create Task
Maniphest T13291

Implement a "{src ...}" rule in Remarkup for referencing source files in Diffusion
Open, NormalPublic
Actions

Description

See PHI1224, which requests support for linking to source files in a way that makes access via an external editor easier.

Previously, see T5378. My plan of attack here is:

  • Convert existing Doorkeeper rules (JIRA and Asana) to use the new extension point. See also T13285.
  • Begin recognizing and specializing the rendering of full https://install.com/diffusion/x/y/z.c URIs, similar to how https://install.com/T123 URIs are now specialized.
  • Provide an alternate mechanism for this rendering rule, {src ...}.
  • Add options to control layout and behavior.

Once this lands, both {src ...} and the new uri, {uri}, and <uri> rules should be documented.

Also:

Revisions and Commits

rPHU libphutil
D20529rPHU07e92da74e9a Support timeouts in OAuth1Future
rP Phabricator
AbandonedD20591 Don't handle JIRA/Asana URIs with anchors or query parameters in a special way (with Doorkeeper)
D20619rP2d2626d73f0b (stable) Bump the remarkup cache version after JIRA/Asana rule changes
D20619rP987e10461056 Bump the remarkup cache version after JIRA/Asana rule changes
D20592rPca56e8590a3d Don't handle JIRA/Asana URIs with anchors or query parameters in a special way…
D20544rP1eff4fdca332 Prevent "Differential Revision: ..." from counting as a mention in commit…
D20539rP4180b337cf7e Add a "{src ...}" Remarkup rule to provide a more flexible way to reference…
D20538rP56e7bde68d9b Recognize self-URI links to Diffusion files and give them special rendering…
D20530rP2f0e655a9b9e Add a 15-second timeout to external service calls to fill Doorkeeper link tags
D20528rPf4201593808d Implement Asana and JIRA external links via HyperlinkEngineExtension, not…
D20527rP33688c8a41eb When an object is referenced by URI, treat it like a mention

Related Objects
Search...

Event Timeline

epriestley triaged this task as Normal priority.May 17 2019, 2:22 PM
epriestley created this task.
Herald added a subscriber: amckinley. · View Herald TranscriptMay 17 2019, 2:22 PM
epriestley updated the task description. (Show Details)May 17 2019, 3:13 PM
epriestley updated the task description. (Show Details)May 19 2019, 8:48 PM
Herald added a subscriber: qgil. · View Herald TranscriptMay 19 2019, 8:48 PM
epriestley added a revision: D20527: When an object is referenced by URI, treat it like a mention.May 20 2019, 4:59 PM
epriestley added a revision: D20528: Implement Asana and JIRA external links via HyperlinkEngineExtension, not separate Remarkup rules.May 20 2019, 6:23 PM
epriestley added a revision: D20529: Support timeouts in OAuth1Future.May 20 2019, 6:39 PM
epriestley added a revision: D20530: Add a 15-second timeout to external service calls to fill Doorkeeper link tags.May 20 2019, 6:45 PM
epriestley added a revision: D20538: Recognize self-URI links to Diffusion files and give them special rendering behavior.May 21 2019, 4:46 PM
epriestley added a revision: D20539: Add a "{src ...}" Remarkup rule to provide a more flexible way to reference source files in Diffusion.May 21 2019, 7:01 PM
epriestley added a commit: rP33688c8a41eb: When an object is referenced by URI, treat it like a mention.May 21 2019, 7:13 PM
epriestley added a commit: rPHU07e92da74e9a: Support timeouts in OAuth1Future.
epriestley added a commit: rPf4201593808d: Implement Asana and JIRA external links via HyperlinkEngineExtension, not….May 21 2019, 7:15 PM
epriestley added a commit: rP2f0e655a9b9e: Add a 15-second timeout to external service calls to fill Doorkeeper link tags.
epriestley added a commit: rP56e7bde68d9b: Recognize self-URI links to Diffusion files and give them special rendering….May 21 2019, 8:07 PM
epriestley added a commit: rP4180b337cf7e: Add a "{src ...}" Remarkup rule to provide a more flexible way to reference….May 21 2019, 8:12 PM
epriestley added a comment.May 22 2019, 11:51 AM

See also T13290. Now that full URIs count as mentions (D20527), the text "Differential Revision: ..." in commits is counting as a mention, and "mentioning" the associated revision.

This isn't too harmful but is silly, and should get cleaned up.

joshuaspence added a subscriber: joshuaspence.May 22 2019, 11:54 AM
epriestley added a revision: D20544: Prevent "Differential Revision: ..." from counting as a mention in commit messages.May 22 2019, 9:15 PM
epriestley added a commit: rP1eff4fdca332: Prevent "Differential Revision: ..." from counting as a mention in commit….May 22 2019, 11:22 PM
epriestley moved this task from Backlog to Next on the Remarkup board.May 23 2019, 2:45 PM
jbrownEP added a subscriber: jbrownEP.May 23 2019, 5:02 PM
epriestley added a subtask: T9720: Provide a way to link to Diffusion files.Jun 19 2019, 5:31 PM
epriestley closed subtask T9720: Provide a way to link to Diffusion files as Resolved.
epriestley mentioned this in T9720: Provide a way to link to Diffusion files.
epriestley added a comment.Jun 19 2019, 5:33 PM

See PHI1312. The modified JIRA rules reportedly misfire on URIs with anchors or parameters. For now, the plan is to just skip these URIs. In the future, we might specialize URIs which (for example) link to comments on foreign objects.

epriestley added a revision: D20591: Don't handle JIRA/Asana URIs with anchors or query parameters in a special way (with Doorkeeper).Jun 19 2019, 5:44 PM
epriestley added a revision: D20592: Don't handle JIRA/Asana URIs with anchors or query parameters in a special way (with Doorkeeper).
epriestley added a commit: rPca56e8590a3d: Don't handle JIRA/Asana URIs with anchors or query parameters in a special way….Jun 21 2019, 1:34 PM
20after4 awarded a token.Jun 21 2019, 9:06 PM
epriestley added a revision: D20619: Bump the remarkup cache version after JIRA/Asana rule changes.Jun 25 2019, 7:55 PM
epriestley added a commit: rP987e10461056: Bump the remarkup cache version after JIRA/Asana rule changes.Jun 25 2019, 9:56 PM
epriestley added a commit: rP2d2626d73f0b: (stable) Bump the remarkup cache version after JIRA/Asana rule changes.
epriestley mentioned this in T5378: Phabricator full task URLs for that instance do not provide hover/popup text (like T1234 does).May 21 2020, 4:03 PM
Phabricator · Built by Phacility