Page MenuHomePhabricator

Only attach files that are both referenced in Remarkup and attached by explicit metadata
ClosedPublic

Authored by epriestley on May 20 2022, 5:48 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jun 18, 2:12 PM
Unknown Object (File)
Thu, Jun 16, 11:49 PM
Unknown Object (File)
Thu, Jun 16, 10:25 AM
Unknown Object (File)
Thu, Jun 16, 10:25 AM
Unknown Object (File)
Thu, Jun 16, 10:25 AM
Unknown Object (File)
Mon, Jun 13, 1:49 PM
Unknown Object (File)
Fri, Jun 10, 2:11 PM
Unknown Object (File)
Wed, Jun 8, 5:57 PM
Subscribers
None

Details

Summary

Ref T13682. When a user uploads a file, then changes their mind and deletes the reference to the file, we don't actually want to attach the file.

When choosing which files to attach, only attach files which are both referenced in Remarkup and explicitly attached in remarkup metadata.

Test Plan
  • Dropped a file into a comment, submitted it, saw it attach normally.
  • Dropped a file into a comment, deleted the reference, submitted it, saw no attachment.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.
This revision was not accepted when it landed; it landed in state Needs Review.May 23 2022, 9:08 PM
This revision was automatically updated to reflect the committed changes.