Fix file PHID extraction in Pholio
ClosedPublic
Actions

Authored by epriestley on Feb 17 2023, 6:30 PM.

Tags

None

Referenced Files

	F19084493: D21858.id.diff
	Tue, Dec 2, 3:28 PM

	F19078151: D21858.diff
	Mon, Dec 1, 5:13 PM

	F18994575: D21858.diff
	Nov 19 2025, 1:08 PM

	F18876992: D21858.diff
	Nov 6 2025, 5:15 AM

	F18850556: D21858.diff
	Oct 30 2025, 5:46 PM

	F18825692: D21858.id.diff
	Oct 23 2025, 11:35 PM

	F18819832: D21858.diff
	Oct 22 2025, 10:07 AM

	F18807948: D21858.diff
	Oct 19 2025, 4:06 AM

View All Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default"
Commits: rPa83cb99e856a: Fix file PHID extraction in Pholio

Summary

Ref T13682. After some change prior change likely connected to T13682, file PHIDs fail to extract properly in Pholio.

Test Plan

Created a new Pholio mock with at least one image.
Before: fatal when extracting data from this datastructure.
After: clean mock creation.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley requested review of this revision.Feb 17 2023, 6:30 PM

epriestley created this revision.

Harbormaster completed remote builds in B25768: Diff 52097.Feb 17 2023, 6:30 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 17 2023, 6:36 PM

Closed by commit rPa83cb99e856a: Fix file PHID extraction in Pholio (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPa83cb99e856a: Fix file PHID extraction in Pholio.

Revision Contents
Changeset List

Path

Size

src/

applications/

pholio/

xaction/

PholioImageFileTransaction.php

13 lines

Diff 52098

View Options

src/applications/pholio/xaction/PholioImageFileTransaction.php

Fix file PHID extraction in PholioClosedPublicActions