Fix file PHID extraction in Pholio
ClosedPublic
Actions

Authored by epriestley on Feb 17 2023, 6:30 PM.

Tags

None

Referenced Files

	F15487526: D21858.id52097.diff
	Thu, Apr 10, 2:53 PM

	F15486230: D21858.diff
	Thu, Apr 10, 5:55 AM

	F15479113: D21858.diff
	Tue, Apr 8, 5:10 AM

	F15478182: D21858.id.diff
	Mon, Apr 7, 8:57 PM

	F15469788: D21858.id.diff
	Fri, Apr 4, 4:35 PM

	F15461901: D21858.id52097.diff
	Tue, Apr 1, 12:14 PM

	F15461900: D21858.id.diff
	Tue, Apr 1, 12:14 PM

	F15450596: D21858.id52098.diff
	Fri, Mar 28, 4:32 PM

View All Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default"
Commits: rPa83cb99e856a: Fix file PHID extraction in Pholio

Summary

Ref T13682. After some change prior change likely connected to T13682, file PHIDs fail to extract properly in Pholio.

Test Plan

Created a new Pholio mock with at least one image.
Before: fatal when extracting data from this datastructure.
After: clean mock creation.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley requested review of this revision.Feb 17 2023, 6:30 PM

epriestley created this revision.

Harbormaster completed remote builds in B25768: Diff 52097.Feb 17 2023, 6:30 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 17 2023, 6:36 PM

Closed by commit rPa83cb99e856a: Fix file PHID extraction in Pholio (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPa83cb99e856a: Fix file PHID extraction in Pholio.

Revision Contents
Changeset List

Path

Size

src/

applications/

pholio/

xaction/

PholioImageFileTransaction.php

13 lines

Diff 52098

View Options

src/applications/pholio/xaction/PholioImageFileTransaction.php

Fix file PHID extraction in PholioClosedPublicActions