Page MenuHomePhabricator

Don't handle JIRA/Asana URIs with anchors or query parameters in a special way (with Doorkeeper)
AbandonedPublicDraft

Authored by epriestley on Jun 19 2019, 5:44 PM.

Details

Summary

Ref T13291. See PHI1312. Currently, if you link to a JIRA or Asana issue with an anchor (#asdf) or query parameters (?a=b), we:

  • treat the link as an external object reference and attempt a lookup on it;
  • if the lookup succeeds, we discard the fragment or parameters when re-rendering the rich link (with the issue/task title).

Particularly, the re-rendering part uses the canonical URI of the object, and can discard these parameters/fragments, which is broken/bad.

As a first pass at improving this, just don't apply special behavior for links with anchors or parameters -- simply treat them as links.

In some future change, we could specialize this behavior and permit certain known parameters or anchors or something, but these use cases are likely fairly marginal.

Test Plan

Before:

After:

Diff Detail

Repository
rP Phabricator
Branch
close1
Lint
Lint OK
Unit
Unit Tests OK
Build Status
Buildable 22993
Build 31558: Run Core Tests
Build 31557: arc lint + arc unit

Event Timeline

epriestley created this revision.Jun 19 2019, 5:44 PM
epriestley abandoned this revision.Jun 19 2019, 5:46 PM

Oops, arc diff raced arc land locally. See D20592.