Page MenuHomePhabricator

Prevent "Differential Revision: ..." from counting as a mention in commit messages
ClosedPublic

Authored by epriestley on May 22 2019, 9:15 PM.
Tags
None
Referenced Files
F18777033: D20544.id.diff
Sat, Oct 11, 12:38 AM
F18722020: D20544.id.diff
Mon, Sep 29, 10:01 PM
F18703997: D20544.diff
Sun, Sep 28, 5:51 AM
F18683700: D20544.id49017.diff
Fri, Sep 26, 8:11 AM
F18646404: D20544.id49017.diff
Fri, Sep 19, 9:53 AM
F18621228: D20544.diff
Sep 15 2025, 7:26 AM
F18609501: D20544.id49007.diff
Sep 14 2025, 3:10 AM
F18590754: D20544.diff
Sep 12 2025, 7:03 AM
Subscribers
None

Details

Summary

Ref T13290. Ref T13291. Now that a full URI is a "mention", the full URI in "Differential Revision: ..." also triggers a mention.

Stop it from doing that, since these mentions are silly/redundant/unintended.

The API here is also slightly odd; simplify it a little bit to get rid of doing "append" with "get + append + set".

Test Plan

Used bin/repository reparse --publish to republish commits with "Differential Revision: ..." and verified that the revision PHID was properly dropped from the mention list.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable