Page MenuHomePhabricator

Prevent "Differential Revision: ..." from counting as a mention in commit messages
ClosedPublic

Authored by epriestley on May 22 2019, 9:15 PM.
Tags
None
Referenced Files
F17457072: D20544.diff
Tue, Jul 1, 7:27 PM
Unknown Object (File)
Sat, Jun 21, 6:56 AM
Unknown Object (File)
Thu, Jun 5, 4:25 PM
Unknown Object (File)
May 25 2025, 2:02 PM
Unknown Object (File)
May 20 2025, 10:52 PM
Unknown Object (File)
May 8 2025, 8:12 AM
Unknown Object (File)
May 8 2025, 3:08 AM
Unknown Object (File)
May 7 2025, 12:42 AM
Subscribers
None

Details

Summary

Ref T13290. Ref T13291. Now that a full URI is a "mention", the full URI in "Differential Revision: ..." also triggers a mention.

Stop it from doing that, since these mentions are silly/redundant/unintended.

The API here is also slightly odd; simplify it a little bit to get rid of doing "append" with "get + append + set".

Test Plan

Used bin/repository reparse --publish to republish commits with "Differential Revision: ..." and verified that the revision PHID was properly dropped from the mention list.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable