Page MenuHomePhabricator

Prevent "Differential Revision: ..." from counting as a mention in commit messages
ClosedPublic

Authored by epriestley on May 22 2019, 9:15 PM.
Tags
None
Referenced Files
F15391671: D20544.id49007.diff
Sat, Mar 15, 10:59 AM
F15379791: D20544.id49017.diff
Thu, Mar 13, 11:24 PM
F15354491: D20544.diff
Tue, Mar 11, 4:18 AM
F15345029: D20544.diff
Mon, Mar 10, 8:10 AM
F15338560: D20544.diff
Sun, Mar 9, 11:27 AM
F15333930: D20544.id49017.diff
Sat, Mar 8, 5:42 AM
Unknown Object (File)
Wed, Feb 19, 12:29 AM
Unknown Object (File)
Feb 13 2025, 6:07 PM
Subscribers
None

Details

Summary

Ref T13290. Ref T13291. Now that a full URI is a "mention", the full URI in "Differential Revision: ..." also triggers a mention.

Stop it from doing that, since these mentions are silly/redundant/unintended.

The API here is also slightly odd; simplify it a little bit to get rid of doing "append" with "get + append + set".

Test Plan

Used bin/repository reparse --publish to republish commits with "Differential Revision: ..." and verified that the revision PHID was properly dropped from the mention list.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable