Page MenuHomePhabricator

Prevent "Differential Revision: ..." from counting as a mention in commit messages
ClosedPublic

Authored by epriestley on May 22 2019, 9:15 PM.
Tags
None
Referenced Files
F19507173: D20544.diff
Fri, Jan 9, 6:03 PM
F19503836: D20544.diff
Fri, Jan 9, 1:57 AM
F19472993: D20544.diff
Wed, Jan 7, 3:46 PM
F19077349: D20544.diff
Dec 1 2025, 3:01 PM
F19077341: D20544.diff
Dec 1 2025, 2:57 PM
F19077314: D20544.diff
Dec 1 2025, 2:46 PM
F19077312: D20544.diff
Dec 1 2025, 2:46 PM
F19077247: D20544.diff
Dec 1 2025, 2:33 PM
Subscribers
None

Details

Summary

Ref T13290. Ref T13291. Now that a full URI is a "mention", the full URI in "Differential Revision: ..." also triggers a mention.

Stop it from doing that, since these mentions are silly/redundant/unintended.

The API here is also slightly odd; simplify it a little bit to get rid of doing "append" with "get + append + set".

Test Plan

Used bin/repository reparse --publish to republish commits with "Differential Revision: ..." and verified that the revision PHID was properly dropped from the mention list.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable