Page MenuHomePhabricator

Strikethrough for icons in checked remarkup list items
Closed, WontfixPublic


It's just a suggestion, but it might improve the look of checked items to also strike icons:

.remarkup-checked-item .phui-font-fa::after {
    content: '';
    background-color: #92969D;
    height: 1px;
    display: block;
    position: relative;
    top: -6px;

This is a little hacky but it works!

Also, shouldn't icons be grey too?

.remarkup-checked-item .phui-font-fa {
    color: #92969D;


  • Cameras
  • Folders
  • Peoples

Event Timeline

This comment was removed by epriestley.

I'm confused here -- the icons are already struck in every browser on my system (Safari, Firefox, Chrome):

No they're not. I know it's a tiny difference, but look at this closely (left is my proposal, right is the current state):

This doesn't make a big difference for the dog paw, but it's noticeable for the circle.

Thanks, that's much more clear than the original description!

Sorry, I should have led with a screenshot! I'm the biggest nitpicker, I know.

I didn't find a trick for tags though:

I'm not sure why the checkbox has visibility: hidden instead of display: none (or why it's still there at all).

Anyway, feel free to dismiss my rambling, I was just kind of bored and I thought that I could improve the design a little!

epriestley claimed this task.

I removed the strikethrough in T13482, which mostly moots this.

I didn't fix the default color for icons but I think the behavior is okay-ish as-is. Particularly, I think {icon color=red ...} should still render red, and interpreting the default values as color=black instead of color=same-as-text is at least a plausible behavior. Maybe I'll fix this some day if I'm touching all these rules, but I don't want to break {icon color=red ...} in some weird case by adjusting rule specificity just to fix this tiny oddity.