Page MenuHomePhabricator
Create Task
Maniphest T12865

Strikethrough for icons in checked remarkup list items
Closed, WontfixPublic
Actions

Description

It's just a suggestion, but it might improve the look of checked items to also strike icons:

.remarkup-checked-item .phui-font-fa::after {
    content: '';
    background-color: #92969D;
    height: 1px;
    display: block;
    position: relative;
    top: -6px;
}

This is a little hacky but it works!

Also, shouldn't icons be grey too?

.remarkup-checked-item .phui-font-fa {
    color: #92969D;
}

Example:

  • Cameras
  • Folders
  • Peoples

Related Objects

Event Timeline

mcorteel created this task.Jun 22 2017, 8:24 AM
Herald added a subscriber: eadler. · View Herald TranscriptJun 22 2017, 8:24 AM
• 1 added a subscriber: • 1.Jun 22 2017, 6:11 PM
This comment was removed by epriestley.
epriestley added a subscriber: epriestley.Jun 22 2017, 6:14 PM
chad updated the task description. (Show Details)Jun 22 2017, 7:25 PM
epriestley added a comment.Jun 23 2017, 4:18 PM

I'm confused here -- the icons are already struck in every browser on my system (Safari, Firefox, Chrome):

Screen Shot 2017-06-23 at 9.16.25 AM.png (239×697 px, 43 KB)

mcorteel added a comment.Jun 23 2017, 4:41 PM

No they're not. I know it's a tiny difference, but look at this closely (left is my proposal, right is the current state):

Spectacle.eD1745.png (147×463 px, 9 KB)

This doesn't make a big difference for the dog paw, but it's noticeable for the circle.

epriestley added a comment.Jun 23 2017, 4:42 PM

Thanks, that's much more clear than the original description!

mcorteel added a comment.Jun 23 2017, 5:48 PM

Sorry, I should have led with a screenshot! I'm the biggest nitpicker, I know.

I didn't find a trick for tags though:

I'm not sure why the checkbox has visibility: hidden instead of display: none (or why it's still there at all).

Anyway, feel free to dismiss my rambling, I was just kind of bored and I thought that I could improve the design a little!

epriestley mentioned this in T13482: Remove strikethru style from checked-off Remarkup list items.Jan 29 2020, 4:52 PM
epriestley closed this task as Wontfix.Jan 29 2020, 5:21 PM
epriestley claimed this task.

I removed the strikethrough in T13482, which mostly moots this.

I didn't fix the default color for icons but I think the behavior is okay-ish as-is. Particularly, I think {icon color=red ...} should still render red, and interpreting the default values as color=black instead of color=same-as-text is at least a plausible behavior. Maybe I'll fix this some day if I'm touching all these rules, but I don't want to break {icon color=red ...} in some weird case by adjusting rule specificity just to fix this tiny oddity.

Herald added a subscriber: amckinley. · View Herald TranscriptJan 29 2020, 5:21 PM
Phabricator · Built by Phacility