Provide a way to link to Diffusion files
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	jparise
	Nov 5 2015, 5:03 PM

Description

We already have ways to link to (or embed) many kind of objects, but the one I miss is file-level linking.

When writing code review feedback, I sometimes want to say "Please also update some/filename.txt", and it would be even more useful if there was a shorthand syntax that would linkify filename references to their Diffusion browsing links.

Some things to consider:

Could the file's repository be implied or must it always be explicitly specified?
Should the syntax support linking to a specific line (range) or revision?

Related Objects
Search...

Status	Assigned	Task
Open	None	T13285 Service failures in JIRA can cascade into service failures in Phabricator
Resolved	epriestley	T5378 Phabricator full task URLs for that instance do not provide hover/popup text (like T1234 does)
Open	epriestley	T13291 Implement a "{src ...}" rule in Remarkup for referencing source files in Diffusion
Resolved	epriestley	T9720 Provide a way to link to Diffusion files
Resolved	epriestley	T4245 Make repository URIs slightly prettier
Resolved	None	T7938 Do not allow users to enter things like "/" or ".." in the "Clone/Checkout" field in repositories
Resolved	epriestley	T10721 SVN repositories with no callsigns do not route individual commit URLs properly

Event Timeline

jparise created this task.Nov 5 2015, 5:03 PM

jparise updated the task description. (Show Details)

jparise added a project: Remarkup.

jparise added a subscriber: jparise.

This should probably also wait for (or happen concurrently with / be considered alongside) the repository monogram changes which occur with T4245, although I think it doesn't limit the reasonable syntax available to us very much.

T5378 / D12692 also have some bearing here.

altendky added a subscriber: altendky.Nov 5 2015, 6:21 PM

cspeckmim added a subscriber: cspeckmim.Nov 5 2015, 7:03 PM

joshuaspence added a subscriber: joshuaspence.Nov 5 2015, 8:15 PM

I think the most natural syntax (and the one I tried before discovering it didn't work!) would be to allow one to basically copy-paste the existing path at the top of file pages (the one inside the phui-header-header element), so that for example, a link to Diffusion's readme file on here would be: rP/README.md
And to link to, say, a specific line of a specific revision: rPbe0e84a81abc/README.md$17
And likewise for ranges: rPbe0e84a81abc/README.md$5-13

I would assume the parser would just have to look ahead after an object link and see if it's followed by a slash, then parse everything up to the next whitespace character as a path.

eadler added a subscriber: eadler.Feb 24 2016, 10:47 PM

aklapper added a subscriber: aklapper.May 22 2016, 12:12 PM

20after4 awarded a token.Jul 28 2016, 1:14 AM

sudowork mentioned this in Z1336: General Chat.Aug 23 2016, 6:13 PM

eadler added a project: Restricted Project.Sep 15 2016, 6:08 PM

epriestley closed subtask T4245: Make repository URIs slightly prettier as Resolved.Nov 13 2016, 8:42 PM

petr.biza awarded a token.Nov 6 2017, 10:46 AM

kerberizer awarded a token.Jan 2 2019, 2:43 PM

kerberizer added a subscriber: kerberizer.

epriestley moved this task from Backlog to Next on the Remarkup board.Apr 27 2019, 5:12 PM

Herald added a subscriber: amckinley. · View Herald TranscriptApr 27 2019, 5:12 PM

jbrownEP added a subscriber: jbrownEP.Apr 27 2019, 6:11 PM