Page MenuHomePhabricator
Differential D21831

Remove obsolete "setDisableMacros()" on "PhabricatorRemarkupControl"
ClosedPublic
Actions

Authored by epriestley on May 20 2022, 5:12 PM.
Tags
None
Referenced Files
F19472266: D21831.diff
Wed, Jan 7, 3:16 AM
F19397169: D21831.id52031.diff
Sat, Dec 27, 10:29 AM
F19006167: D21831.diff
Nov 21 2025, 5:22 PM
F18854284: D21831.diff
Oct 31 2025, 11:03 PM
F18809979: D21831.id.diff
Oct 19 2025, 6:30 PM
F18804274: D21831.diff
Oct 18 2025, 7:09 AM
F18761291: D21831.id.diff
Oct 6 2025, 1:25 PM
F18757612: D21831.id52031.diff
Oct 5 2025, 6:23 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default"
Commits
rPcc44ae32c546: Remove obsolete "setDisableMacros()" on "PhabricatorRemarkupControl"
Summary

Ref T13682. This method originated in D4781 and no longer has any callers; remove it.

(I believe this was from an era where macros didn't have to be on their own line to trigger.)

Test Plan

Grepped for method, found no callers.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley requested review of this revision.May 20 2022, 5:12 PM
epriestley created this revision.
Harbormaster completed remote builds in B25733: Diff 52031.May 20 2022, 5:12 PM
This revision was not accepted when it landed; it landed in state Needs Review.May 20 2022, 5:27 PM
Closed by commit rPcc44ae32c546: Remove obsolete "setDisableMacros()" on "PhabricatorRemarkupControl" (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rPcc44ae32c546: Remove obsolete "setDisableMacros()" on "PhabricatorRemarkupControl".

Revision Contents
Changeset List

PathSize
src/
view/
form/
control/
10 lines

Diff 52032

View Options

src/view/form/control/PhabricatorRemarkupControl.php

Loading...
Phabricator · Built by Phacility