Page MenuHomePhabricator

When printing, wrap all content in Remarkup tables more aggressively

Authored by epriestley on Sep 28 2020, 4:22 PM.



Ref T13564. See PHI1798. Earlier efforts here (see D21439) still leave us with:

  • Incorrect behavior for long URIs, like
  • Incorrect beahvior for long text blocks, like MMMMMM....
  • Undesirable behavior for monospaced text in non-printing contexts (it wraps when we'd prefer it not wrap).

Apply the wrapping rules to all "<td>" content to resolve these three prongs.

Test Plan
  • Viewed long URIs, text blocks, and monospaced text in and out of tables, while printed and not printed, in Safari, Firefox, and Chrome.
  • All browser behavior now appears to be correct ("all content is preserved in printed document").
  • Some browser behavior when making wrapping choices is questionable, but I can't find an automatic solution for that.

Diff Detail

rP Phabricator
Lint Not Applicable
Tests Not Applicable

Event Timeline

Here's the remaining goofy behavior:

Screen Shot 2020-09-28 at 8.59.24 AM.png (447×762 px, 43 KB)

This revision was not accepted when it landed; it landed in state Needs Review.Sep 28 2020, 4:47 PM
This revision was automatically updated to reflect the committed changes.