Page MenuHomePhabricator

Add a 15-second timeout to external service calls to fill Doorkeeper link tags
ClosedPublic

Authored by epriestley on May 20 2019, 6:45 PM.
Tags
None
Referenced Files
F18780498: D20530.id48957.diff
Sun, Oct 12, 4:37 PM
F18758963: D20530.diff
Mon, Oct 6, 12:53 AM
F18754617: D20530.id48975.diff
Sat, Oct 4, 11:58 PM
F18742104: D20530.id.diff
Thu, Oct 2, 5:26 PM
F18739535: D20530.diff
Wed, Oct 1, 9:51 PM
F18653388: D20530.diff
Sun, Sep 21, 1:11 PM
F18652177: D20530.id.diff
Sun, Sep 21, 6:59 AM
F18570201: D20530.id48975.diff
Sep 10 2025, 3:14 AM
Subscribers
None

Details

Summary

Depends on D20528. Ref T13291. Ref T13285. Currently, we don't put a timeout on external service calls when enriching URIs for external Asana/JIRA tasks.

Add a 15-second timeout so we'll do something reasonable-ish in the face of a downed service provider. Later, I plan to healthcheck Asana/JIRA providers in a generic way (see T13287) so we can stop making calls if they time out / fail too frequently.

Test Plan
  • Linked to JIRA and Asana tasks in comments.
  • Set timeout to 0.0001 seconds, saw requests time out.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable