Page MenuHomePhabricator

Add a 15-second timeout to external service calls to fill Doorkeeper link tags
ClosedPublic

Authored by epriestley on May 20 2019, 6:45 PM.
Tags
None
Referenced Files
F22740955: D20530.id.diff
Sun, Oct 4, 1:31 PM
Unknown Object (File)
Aug 15 2026, 11:29 AM
Unknown Object (File)
Jul 11 2026, 6:35 AM
Unknown Object (File)
Jul 6 2026, 4:48 PM
Unknown Object (File)
Jun 25 2026, 6:09 PM
Unknown Object (File)
Jun 25 2026, 6:09 PM
Unknown Object (File)
Jun 25 2026, 6:04 PM
Unknown Object (File)
Jun 25 2026, 6:04 PM
Subscribers
None

Details

Summary

Depends on D20528. Ref T13291. Ref T13285. Currently, we don't put a timeout on external service calls when enriching URIs for external Asana/JIRA tasks.

Add a 15-second timeout so we'll do something reasonable-ish in the face of a downed service provider. Later, I plan to healthcheck Asana/JIRA providers in a generic way (see T13287) so we can stop making calls if they time out / fail too frequently.

Test Plan
  • Linked to JIRA and Asana tasks in comments.
  • Set timeout to 0.0001 seconds, saw requests time out.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable