Page MenuHomePhabricator

Add a 15-second timeout to external service calls to fill Doorkeeper link tags
ClosedPublic

Authored by epriestley on May 20 2019, 6:45 PM.
Tags
None
Referenced Files
F15567650: D20530.diff
Fri, May 2, 11:57 AM
F15551594: D20530.id.diff
Sun, Apr 27, 5:33 PM
F15547900: D20530.diff
Sat, Apr 26, 8:39 PM
F15477597: D20530.diff
Apr 7 2025, 4:28 PM
F15441014: D20530.id.diff
Mar 26 2025, 4:05 PM
F15435672: D20530.id48957.diff
Mar 25 2025, 9:40 AM
F15421398: D20530.diff
Mar 21 2025, 11:21 PM
Unknown Object (File)
Feb 18 2025, 2:53 PM
Subscribers
None

Details

Summary

Depends on D20528. Ref T13291. Ref T13285. Currently, we don't put a timeout on external service calls when enriching URIs for external Asana/JIRA tasks.

Add a 15-second timeout so we'll do something reasonable-ish in the face of a downed service provider. Later, I plan to healthcheck Asana/JIRA providers in a generic way (see T13287) so we can stop making calls if they time out / fail too frequently.

Test Plan
  • Linked to JIRA and Asana tasks in comments.
  • Set timeout to 0.0001 seconds, saw requests time out.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable