Page MenuHomePhabricator

Add a 15-second timeout to external service calls to fill Doorkeeper link tags
ClosedPublic

Authored by epriestley on May 20 2019, 6:45 PM.
Tags
None
Referenced Files
F19084863: D20530.diff
Tue, Dec 2, 4:39 PM
F19084856: D20530.diff
Tue, Dec 2, 4:37 PM
F19084841: D20530.diff
Tue, Dec 2, 4:34 PM
F18878572: D20530.id.diff
Nov 6 2025, 5:25 PM
F18876041: D20530.diff
Nov 5 2025, 9:16 PM
F18815828: D20530.diff
Oct 21 2025, 3:52 AM
F18780498: D20530.id48957.diff
Oct 12 2025, 4:37 PM
F18758963: D20530.diff
Oct 6 2025, 12:53 AM
Subscribers
None

Details

Summary

Depends on D20528. Ref T13291. Ref T13285. Currently, we don't put a timeout on external service calls when enriching URIs for external Asana/JIRA tasks.

Add a 15-second timeout so we'll do something reasonable-ish in the face of a downed service provider. Later, I plan to healthcheck Asana/JIRA providers in a generic way (see T13287) so we can stop making calls if they time out / fail too frequently.

Test Plan
  • Linked to JIRA and Asana tasks in comments.
  • Set timeout to 0.0001 seconds, saw requests time out.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable