Page MenuHomePhabricator

Add a 15-second timeout to external service calls to fill Doorkeeper link tags
ClosedPublic

Authored by epriestley on May 20 2019, 6:45 PM.
Tags
None
Referenced Files
F18264340: D20530.diff
Fri, Aug 22, 10:39 AM
F18101914: D20530.id48975.diff
Sat, Aug 9, 4:39 PM
F18100520: D20530.id.diff
Sat, Aug 9, 11:55 AM
F17953872: D20530.id.diff
Fri, Aug 1, 3:33 AM
F17948648: D20530.id48957.diff
Thu, Jul 31, 9:38 PM
F17947703: D20530.id.diff
Thu, Jul 31, 6:03 PM
F17933420: D20530.diff
Wed, Jul 30, 9:17 PM
F17836227: D20530.id48975.diff
Sat, Jul 26, 3:56 PM
Subscribers
None

Details

Summary

Depends on D20528. Ref T13291. Ref T13285. Currently, we don't put a timeout on external service calls when enriching URIs for external Asana/JIRA tasks.

Add a 15-second timeout so we'll do something reasonable-ish in the face of a downed service provider. Later, I plan to healthcheck Asana/JIRA providers in a generic way (see T13287) so we can stop making calls if they time out / fail too frequently.

Test Plan
  • Linked to JIRA and Asana tasks in comments.
  • Set timeout to 0.0001 seconds, saw requests time out.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable