Page MenuHomePhabricator

Give "FileAttachment" policy support and a query object
ClosedPublic

Authored by epriestley on May 23 2022, 5:24 PM.
Tags
None
Referenced Files
F13228626: D21835.id52044.diff
Mon, May 20, 10:52 AM
F13198321: D21835.diff
Mon, May 13, 5:46 AM
F13190113: D21835.diff
Sat, May 11, 7:48 AM
F13183051: D21835.diff
Fri, May 10, 6:34 AM
F13180720: D21835.id52037.diff
Thu, May 9, 3:02 AM
F13180068: D21835.id52037.diff
Wed, May 8, 10:08 PM
Unknown Object (File)
Tue, May 7, 5:50 PM
Unknown Object (File)
Tue, May 7, 8:31 AM
Subscribers
None

Details

Summary

Ref T13682. This supports an "Attached Files" curtain UI element.

Test Plan

See next change.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.
  • Also fix indirect reference attachment/scrambling test.
  • Further improve unit test coverage and test "reference doesn't grant view permission".
This revision was not accepted when it landed; it landed in state Needs Review.May 23 2022, 9:08 PM
This revision was automatically updated to reflect the committed changes.