Page MenuHomePhabricator
Differential D21848

Update Slowvote poll status to use sensible string constants
ClosedPublic
Actions

Authored by epriestley on May 27 2022, 5:14 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jan 28, 1:45 PM
Unknown Object (File)
Tue, Jan 21, 11:02 AM
Unknown Object (File)
Fri, Jan 17, 9:54 PM
Unknown Object (File)
Sun, Jan 5, 10:26 AM
Unknown Object (File)
Dec 31 2024, 12:25 AM
Unknown Object (File)
Dec 27 2024, 3:01 PM
Unknown Object (File)
Dec 16 2024, 3:28 PM
Unknown Object (File)
Dec 8 2024, 3:58 PM
View All Files
Subscribers
Restricted Owners Package

Details

Reviewers
None
Maniphest Tasks
T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default"
Commits
rP809ae8175259: Update Slowvote poll status to use sensible string constants
Summary

Ref T13682. This prepares for modernizing Slowvote and exposing a more usable API.

Test Plan

Ran migrations, opened and closed polls.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.May 27 2022, 5:14 PM
Owners added a subscriber: Restricted Owners Package.May 27 2022, 5:14 PM
epriestley requested review of this revision.May 27 2022, 5:14 PM
Harbormaster completed remote builds in B25756: Diff 52070.May 27 2022, 5:14 PM
This revision was not accepted when it landed; it landed in state Needs Review.May 27 2022, 5:15 PM
Closed by commit rP809ae8175259: Update Slowvote poll status to use sensible string constants (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP809ae8175259: Update Slowvote poll status to use sensible string constants.

Revision Contents
Changeset List

Diff 52072

View Options

resources/sql/autopatches/20220525.slowvote.08.status-type.sql

Loading...
View Options

resources/sql/autopatches/20220525.slowvote.09.status-value.sql

Loading...
View Options

resources/sql/autopatches/20220525.slowvote.10.status-xactions.sql

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/slowvote/constants/SlowvotePollStatus.php

Loading...
View Options

src/applications/slowvote/controller/PhabricatorSlowvoteCloseController.php

Loading...
View Options

src/applications/slowvote/query/PhabricatorSlowvoteQuery.php

Loading...
View Options

src/applications/slowvote/query/PhabricatorSlowvoteSearchEngine.php

Loading...
View Options

src/applications/slowvote/storage/PhabricatorSlowvotePoll.php

Loading...
View Options

src/applications/slowvote/storage/PhabricatorSlowvoteTransaction.php

Loading...
View Options

src/applications/slowvote/xaction/PhabricatorSlowvoteCloseTransaction.php

Loading...
View Options

src/applications/slowvote/xaction/PhabricatorSlowvoteStatusTransaction.php

Loading...
Phabricator · Built by Phacility