Differential D21848

Update Slowvote poll status to use sensible string constants
ClosedPublic
Actions

Authored by epriestley on May 27 2022, 5:14 PM.

Details

Reviewers: None
Maniphest Tasks: T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default"
Commits: rP809ae8175259: Update Slowvote poll status to use sensible string constants

Summary

Ref T13682. This prepares for modernizing Slowvote and exposing a more usable API.

Test Plan

Ran migrations, opened and closed polls.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.May 27 2022, 5:14 PM

Owners added a subscriber: Restricted Owners Package.May 27 2022, 5:14 PM

epriestley requested review of this revision.May 27 2022, 5:14 PM

Harbormaster completed remote builds in B25756: Diff 52070.May 27 2022, 5:14 PM

This revision was not accepted when it landed; it landed in state Needs Review.May 27 2022, 5:15 PM

Closed by commit rP809ae8175259: Update Slowvote poll status to use sensible string constants (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP809ae8175259: Update Slowvote poll status to use sensible string constants.

Revision Contents
Changeset List

Path

Size

resources/

sql/

autopatches/

20220525.slowvote.08.status-type.sql

2 lines

20220525.slowvote.09.status-value.sql

5 lines

20220525.slowvote.10.status-xactions.sql

19 lines

src/

__phutil_library_map__.php

applications/

slowvote/

constants/

SlowvotePollStatus.php

10 lines

controller/

PhabricatorSlowvoteCloseController.php

4 lines

query/

PhabricatorSlowvoteQuery.php

13 lines

PhabricatorSlowvoteSearchEngine.php

23 lines

storage/

PhabricatorSlowvotePoll.php

10 lines

PhabricatorSlowvoteTransaction.php

2 lines

xaction/

PhabricatorSlowvoteCloseTransaction.php

PhabricatorSlowvoteStatusTransaction.php

60 lines

Diff 52072

View Options

resources/sql/autopatches/20220525.slowvote.08.status-type.sql

View Options

resources/sql/autopatches/20220525.slowvote.09.status-value.sql

View Options

resources/sql/autopatches/20220525.slowvote.10.status-xactions.sql

View Options

src/__phutil_library_map__.php

View Options

src/applications/slowvote/constants/SlowvotePollStatus.php

View Options

src/applications/slowvote/controller/PhabricatorSlowvoteCloseController.php

View Options

src/applications/slowvote/query/PhabricatorSlowvoteQuery.php

View Options

src/applications/slowvote/query/PhabricatorSlowvoteSearchEngine.php

View Options

src/applications/slowvote/storage/PhabricatorSlowvotePoll.php

View Options

src/applications/slowvote/storage/PhabricatorSlowvoteTransaction.php

View Options

src/applications/slowvote/xaction/PhabricatorSlowvoteCloseTransaction.php

View Options

src/applications/slowvote/xaction/PhabricatorSlowvoteStatusTransaction.php

Update Slowvote poll status to use sensible string constantsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 52072

resources/sql/autopatches/20220525.slowvote.08.status-type.sql

resources/sql/autopatches/20220525.slowvote.09.status-value.sql

resources/sql/autopatches/20220525.slowvote.10.status-xactions.sql

src/__phutil_library_map__.php

src/applications/slowvote/constants/SlowvotePollStatus.php

src/applications/slowvote/controller/PhabricatorSlowvoteCloseController.php

src/applications/slowvote/query/PhabricatorSlowvoteQuery.php

src/applications/slowvote/query/PhabricatorSlowvoteSearchEngine.php

src/applications/slowvote/storage/PhabricatorSlowvotePoll.php

src/applications/slowvote/storage/PhabricatorSlowvoteTransaction.php

src/applications/slowvote/xaction/PhabricatorSlowvoteCloseTransaction.php

src/applications/slowvote/xaction/PhabricatorSlowvoteStatusTransaction.php

Update Slowvote poll status to use sensible string constants
ClosedPublic
Actions

Revision Contents
Changeset List