Page MenuHomePhabricator

Move "Password Reset" email to "PeopleMailEngine"
ClosedPublic

Authored by epriestley on Jul 19 2019, 2:17 PM.
Tags
None
Referenced Files
F17703988: D20662.id49288.diff
Wed, Jul 16, 2:55 AM
F17600683: D20662.id49302.diff
Tue, Jul 8, 8:33 PM
Unknown Object (File)
Tue, Jul 1, 5:45 PM
Unknown Object (File)
Jun 14 2025, 4:05 AM
Unknown Object (File)
Jun 7 2025, 3:30 AM
Unknown Object (File)
Jun 5 2025, 4:37 PM
Unknown Object (File)
May 5 2025, 10:33 PM
Unknown Object (File)
Apr 19 2025, 1:10 AM
Subscribers
None

Details

Summary

Ref T13343. This makes "Password Reset" email a little more consistent with other modern types of email. My expectation is that this patch has no functional changes, just organizes code a little more consistently.

The new setRecipientAddress() mechanism deals with the case where the user types a secondary (but still verified) address.

Test Plan
  • Sent a normal "login with email" email.
  • Sent a "login with email to set password" email by trying to set a password on an account with no password yet.
  • Tried to email reset a bot account (no dice: they can't do web logins so this operation isn't valid).
  • Tested existing "PeopleMailEngine" subclasses:
    • Created a new user and sent a "welcome" email.
    • Renamed a user and sent a "username changed" email.
  • Reviewed all generated mail with bin/mail list-outbound.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable