Page MenuHomePhabricator

Move "Password Reset" email to "PeopleMailEngine"
ClosedPublic

Authored by epriestley on Jul 19 2019, 2:17 PM.
Tags
None
Referenced Files
F15573905: D20662.id.diff
Mon, May 5, 10:33 PM
F15517261: D20662.diff
Sat, Apr 19, 1:10 AM
F15514467: D20662.id49288.diff
Fri, Apr 18, 2:53 AM
F15511064: D20662.id49288.diff
Wed, Apr 16, 11:49 PM
F15504292: D20662.id49288.diff
Mon, Apr 14, 5:11 PM
F15494905: D20662.id49302.diff
Sun, Apr 13, 2:01 AM
F15468277: D20662.id.diff
Apr 3 2025, 10:42 PM
F15464415: D20662.diff
Apr 2 2025, 9:16 AM
Subscribers
None

Details

Summary

Ref T13343. This makes "Password Reset" email a little more consistent with other modern types of email. My expectation is that this patch has no functional changes, just organizes code a little more consistently.

The new setRecipientAddress() mechanism deals with the case where the user types a secondary (but still verified) address.

Test Plan
  • Sent a normal "login with email" email.
  • Sent a "login with email to set password" email by trying to set a password on an account with no password yet.
  • Tried to email reset a bot account (no dice: they can't do web logins so this operation isn't valid).
  • Tested existing "PeopleMailEngine" subclasses:
    • Created a new user and sent a "welcome" email.
    • Renamed a user and sent a "username changed" email.
  • Reviewed all generated mail with bin/mail list-outbound.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable