Page MenuHomePhabricator

Move "Password Reset" email to "PeopleMailEngine"
ClosedPublic

Authored by epriestley on Jul 19 2019, 2:17 PM.

Details

Summary

Ref T13343. This makes "Password Reset" email a little more consistent with other modern types of email. My expectation is that this patch has no functional changes, just organizes code a little more consistently.

The new setRecipientAddress() mechanism deals with the case where the user types a secondary (but still verified) address.

Test Plan
  • Sent a normal "login with email" email.
  • Sent a "login with email to set password" email by trying to set a password on an account with no password yet.
  • Tried to email reset a bot account (no dice: they can't do web logins so this operation isn't valid).
  • Tested existing "PeopleMailEngine" subclasses:
    • Created a new user and sent a "welcome" email.
    • Renamed a user and sent a "username changed" email.
  • Reviewed all generated mail with bin/mail list-outbound.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Jul 19 2019, 2:17 PM
epriestley requested review of this revision.Jul 19 2019, 2:18 PM
amckinley accepted this revision.Jul 19 2019, 8:00 PM
This revision is now accepted and ready to land.Jul 19 2019, 8:00 PM
This revision was automatically updated to reflect the committed changes.