Page MenuHomePhabricator

Move "Password Reset" email to "PeopleMailEngine"
ClosedPublic

Authored by epriestley on Jul 19 2019, 2:17 PM.
Tags
None
Referenced Files
F18383399: D20662.id.diff
Thu, Aug 28, 11:00 PM
F18348756: D20662.diff
Tue, Aug 26, 5:20 PM
F18100603: D20662.id.diff
Sat, Aug 9, 11:57 AM
F18037223: D20662.diff
Sun, Aug 3, 2:30 AM
F17938460: D20662.id.diff
Jul 31 2025, 2:13 AM
F17848474: D20662.id49288.diff
Jul 27 2025, 7:27 AM
F17828035: D20662.id49302.diff
Jul 26 2025, 8:48 AM
F17819750: D20662.id49302.diff
Jul 26 2025, 1:29 AM
Subscribers
None

Details

Summary

Ref T13343. This makes "Password Reset" email a little more consistent with other modern types of email. My expectation is that this patch has no functional changes, just organizes code a little more consistently.

The new setRecipientAddress() mechanism deals with the case where the user types a secondary (but still verified) address.

Test Plan
  • Sent a normal "login with email" email.
  • Sent a "login with email to set password" email by trying to set a password on an account with no password yet.
  • Tried to email reset a bot account (no dice: they can't do web logins so this operation isn't valid).
  • Tested existing "PeopleMailEngine" subclasses:
    • Created a new user and sent a "welcome" email.
    • Renamed a user and sent a "username changed" email.
  • Reviewed all generated mail with bin/mail list-outbound.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable