Differential D20662

Move "Password Reset" email to "PeopleMailEngine"
ClosedPublic
Actions

Authored by epriestley on Jul 19 2019, 2:17 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13343: Make "Send a login link to your email address" email include why it was sent to avoid confusion

Commits

rP5dd489500155: Move "Password Reset" email to "PeopleMailEngine"

Summary

Ref T13343. This makes "Password Reset" email a little more consistent with other modern types of email. My expectation is that this patch has no functional changes, just organizes code a little more consistently.

The new setRecipientAddress() mechanism deals with the case where the user types a secondary (but still verified) address.

Test Plan

Sent a normal "login with email" email.
Sent a "login with email to set password" email by trying to set a password on an account with no password yet.
Tried to email reset a bot account (no dice: they can't do web logins so this operation isn't valid).
Tested existing "PeopleMailEngine" subclasses:
- Created a new user and sent a "welcome" email.
- Renamed a user and sent a "username changed" email.
Reviewed all generated mail with bin/mail list-outbound.

Diff Detail

Repository

rP Phabricator

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Jul 19 2019, 2:17 PM

Harbormaster completed remote builds in B23155: Diff 49288.Jul 19 2019, 2:18 PM

epriestley requested review of this revision.Jul 19 2019, 2:18 PM

epriestley added a child revision: D20663: Allow installs to customize mail body guidance in the "Email Login" and "Set Password" emails.Jul 19 2019, 2:41 PM

amckinley accepted this revision.Jul 19 2019, 8:00 PM

This revision is now accepted and ready to land.Jul 19 2019, 8:00 PM

Closed by commit rP5dd489500155: Move "Password Reset" email to "PeopleMailEngine" (authored by epriestley). · Explain WhyJul 19 2019, 10:30 PM

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP5dd489500155: Move "Password Reset" email to "PeopleMailEngine".

Revision Contents
Changeset List

		Path
M		src/__phutil_library_map__.php (2 lines)
M		src/applications/auth/controller/PhabricatorEmailLoginController.php (78 lines)
A	M	src/applications/people/mail/PhabricatorPeopleEmailLoginMailEngine.php (107 lines)
M		src/applications/people/mail/PhabricatorPeopleMailEngine.php (26 lines)
M		src/applications/people/mail/PhabricatorPeopleUsernameMailEngine.php (2 lines)
M		src/applications/people/mail/PhabricatorPeopleWelcomeMailEngine.php (1 line)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	49288	f55aac4		Jul 19 2019, 2:17 PM	★	★
Diff 2	49302	f55aac4	rP5dd489500155ae3b423ba051531eade4d7d4dd26	Jul 19 2019, 10:30 PM	★	★

Status	Author	Revision
Closed	epriestley	D20674 Provide a basic detail view for user activity logs
Closed	epriestley	D20673 Record account recovery email links in the user activity log and make the mail message reference the log
Closed	epriestley	D20672 Give user log types a tokenizer and datasource instead of a page of checkboxes
Closed	epriestley	D20671 Modularize user activity log message types
Closed	epriestley	D20670 Remove explicit administrative actions from the user activity log
Closed	epriestley	D20669 Simplify implementation of "SysetemAction->getSystemActionConstant()"
Closed	epriestley	D20668 Replace old rate limiting in password login flow with "SystemAction" rate limiting
Closed	epriestley	D20667 Add a rate limit to requesting account recovery links from a given remote address
Closed	epriestley	D20666 Add a rate limit to generating new account recovery links for a given account
Closed	epriestley	D20665 Allow Auth messages to have detailed descriptions and default values, then give "Email Login" both
Closed	epriestley	D20664 Give "Auth Messages" a view/detail state before users customize them
Closed	epriestley	D20663 Allow installs to customize mail body guidance in the "Email Login" and "Set Password" emails
Closed	epriestley	D20662 Move "Password Reset" email to "PeopleMailEngine"