Page MenuHomePhabricator

Fix missing URI for "OAuthServerClient" object handles, causing dialog with no button
ClosedPublic

Authored by epriestley on Jun 29 2019, 3:28 PM.
Tags
None
Referenced Files
F18366093: D20624.diff
Wed, Aug 27, 9:53 PM
F18080510: D20624.diff
Mon, Aug 4, 9:54 PM
F18042813: D20624.id49205.diff
Sun, Aug 3, 5:11 AM
F18001871: D20624.id.diff
Sat, Aug 2, 9:23 AM
F17965978: D20624.diff
Fri, Aug 1, 11:47 AM
F17712025: D20624.diff
Jul 17 2025, 9:22 AM
Unknown Object (File)
Jun 27 2025, 6:39 PM
Unknown Object (File)
Apr 21 2025, 4:32 PM
Subscribers
None

Details

Summary

Ref T13330. Handles for "OAuthServerClient" objects currently do not have a URI, which causes some obscure fallout like a missing "Close" button when examining their transactions.

Add a URI.

Test Plan
  • Viewed an OAuth server client detail page.
  • Edited a policy, changing it to a custom policy.
  • Clicked "Custom Policy" in the resulting transaction to view a dialog explaining the changes.
  • Before change: dialog has no close button.
  • After change: dialog has a close button.

Screen Shot 2019-06-29 at 8.25.52 AM.png (1×1 px, 236 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable