Page MenuHomePhabricator

Fix missing URI for "OAuthServerClient" object handles, causing dialog with no button
ClosedPublic

Authored by epriestley on Jun 29 2019, 3:28 PM.
Tags
None
Referenced Files
F14076002: D20624.diff
Thu, Nov 21, 2:02 PM
Unknown Object (File)
Wed, Nov 20, 2:35 PM
Unknown Object (File)
Fri, Nov 15, 7:56 PM
Unknown Object (File)
Wed, Nov 13, 2:33 PM
Unknown Object (File)
Tue, Nov 12, 11:16 AM
Unknown Object (File)
Fri, Nov 8, 5:47 AM
Unknown Object (File)
Thu, Oct 24, 6:13 AM
Unknown Object (File)
Oct 15 2024, 3:29 PM
Subscribers
None

Details

Summary

Ref T13330. Handles for "OAuthServerClient" objects currently do not have a URI, which causes some obscure fallout like a missing "Close" button when examining their transactions.

Add a URI.

Test Plan
  • Viewed an OAuth server client detail page.
  • Edited a policy, changing it to a custom policy.
  • Clicked "Custom Policy" in the resulting transaction to view a dialog explaining the changes.
  • Before change: dialog has no close button.
  • After change: dialog has a close button.

Screen Shot 2019-06-29 at 8.25.52 AM.png (1×1 px, 236 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable