Page MenuHomePhabricator

Fix missing URI for "OAuthServerClient" object handles, causing dialog with no button
ClosedPublic

Authored by epriestley on Jun 29 2019, 3:28 PM.
Tags
None
Referenced Files
F18836268: D20624.diff
Sun, Oct 26, 11:38 PM
F18832822: D20624.diff
Sat, Oct 25, 11:17 PM
F18755347: D20624.id49205.diff
Sun, Oct 5, 5:05 AM
F18684965: D20624.id49213.diff
Sep 26 2025, 10:15 AM
F18567093: D20624.id.diff
Sep 9 2025, 3:30 PM
F18465479: D20624.id.diff
Sep 2 2025, 7:16 AM
F18455644: D20624.diff
Sep 1 2025, 9:26 AM
F18366093: D20624.diff
Aug 27 2025, 9:53 PM
Subscribers
None

Details

Summary

Ref T13330. Handles for "OAuthServerClient" objects currently do not have a URI, which causes some obscure fallout like a missing "Close" button when examining their transactions.

Add a URI.

Test Plan
  • Viewed an OAuth server client detail page.
  • Edited a policy, changing it to a custom policy.
  • Clicked "Custom Policy" in the resulting transaction to view a dialog explaining the changes.
  • Before change: dialog has no close button.
  • After change: dialog has a close button.

Screen Shot 2019-06-29 at 8.25.52 AM.png (1×1 px, 236 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable