Page MenuHomePhabricator

Fix missing URI for "OAuthServerClient" object handles, causing dialog with no button
ClosedPublic

Authored by epriestley on Jun 29 2019, 3:28 PM.
Tags
None
Referenced Files
F19933408: D20624.diff
Sat, Apr 11, 1:34 AM
F19908986: D20624.diff
Wed, Apr 1, 10:52 PM
F19908985: D20624.diff
Wed, Apr 1, 10:52 PM
F19892997: D20624.id49213.diff
Sat, Mar 28, 5:29 AM
F19888032: D20624.id.diff
Mon, Mar 23, 9:34 PM
F19819636: D20624.id.diff
Mar 6 2026, 7:54 AM
F19819631: D20624.id.diff
Mar 6 2026, 7:53 AM
F19798273: D20624.id49205.diff
Feb 27 2026, 9:02 PM
Subscribers
None

Details

Summary

Ref T13330. Handles for "OAuthServerClient" objects currently do not have a URI, which causes some obscure fallout like a missing "Close" button when examining their transactions.

Add a URI.

Test Plan
  • Viewed an OAuth server client detail page.
  • Edited a policy, changing it to a custom policy.
  • Clicked "Custom Policy" in the resulting transaction to view a dialog explaining the changes.
  • Before change: dialog has no close button.
  • After change: dialog has a close button.

Screen Shot 2019-06-29 at 8.25.52 AM.png (1×1 px, 236 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable