Page MenuHomePhabricator

Fix "add more metadata" fatal in Pholio
ClosedPublic

Authored by epriestley on Jul 11 2019, 9:40 PM.
Tags
None
Referenced Files
F19505277: D20647.diff
Fri, Jan 9, 10:39 AM
F19018522: D20647.id.diff
Nov 23 2025, 11:25 AM
F19014508: D20647.diff
Nov 22 2025, 8:27 PM
F18983171: D20647.id.diff
Nov 17 2025, 8:37 AM
F18865912: D20647.diff
Nov 3 2025, 2:33 PM
F18863978: D20647.diff
Nov 3 2025, 2:12 AM
F18830272: D20647.id49257.diff
Oct 25 2025, 5:46 AM
F18709384: D20647.id49259.diff
Sep 29 2025, 12:05 AM
Subscribers
None

Details

Summary

Ref T13332. This fix isn't terribly satisfying, but resolves the issue: this behavior may attempt to build HTML blocks with metadata after Javascript footer rendering has started. Use hsprintf() to flatten the markup earlier.

Test Plan

Put a T123 reference in the description of a Pholio image, then loaded a mock.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable