Page MenuHomePhabricator

Fix "add more metadata" fatal in Pholio
ClosedPublic

Authored by epriestley on Jul 11 2019, 9:40 PM.
Tags
None
Referenced Files
F14414169: D20647.id49257.diff
Tue, Dec 24, 3:12 PM
Unknown Object (File)
Sun, Dec 22, 2:07 AM
Unknown Object (File)
Sat, Dec 21, 10:46 AM
Unknown Object (File)
Sat, Dec 21, 2:35 AM
Unknown Object (File)
Sun, Dec 15, 10:44 AM
Unknown Object (File)
Fri, Dec 13, 8:54 AM
Unknown Object (File)
Wed, Dec 11, 1:30 AM
Unknown Object (File)
Tue, Dec 10, 7:09 AM
Subscribers
None

Details

Summary

Ref T13332. This fix isn't terribly satisfying, but resolves the issue: this behavior may attempt to build HTML blocks with metadata after Javascript footer rendering has started. Use hsprintf() to flatten the markup earlier.

Test Plan

Put a T123 reference in the description of a Pholio image, then loaded a mock.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable