Page MenuHomePhabricator

Fix "add more metadata" fatal in Pholio
ClosedPublic

Authored by epriestley on Jul 11 2019, 9:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Aug 4, 7:29 AM
Unknown Object (File)
Thu, Aug 4, 7:29 AM
Unknown Object (File)
Thu, Aug 4, 7:29 AM
Unknown Object (File)
Tue, Aug 2, 9:14 AM
Unknown Object (File)
Tue, Aug 2, 9:14 AM
Unknown Object (File)
Tue, Aug 2, 4:52 AM
Unknown Object (File)
Sun, Jul 24, 2:40 AM
Unknown Object (File)
Sun, Jul 24, 12:11 AM
Subscribers
None

Details

Summary

Ref T13332. This fix isn't terribly satisfying, but resolves the issue: this behavior may attempt to build HTML blocks with metadata after Javascript footer rendering has started. Use hsprintf() to flatten the markup earlier.

Test Plan

Put a T123 reference in the description of a Pholio image, then loaded a mock.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable