Fix "add more metadata" fatal in Pholio
ClosedPublic
Actions

Authored by epriestley on Jul 11 2019, 9:40 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13332: Javelin behaviors which pass PHUIViews to configuration parameters fatal the page in an abrupt way

Commits

rP099919366b12: Fix "add more metadata" fatal in Pholio

Summary

Ref T13332. This fix isn't terribly satisfying, but resolves the issue: this behavior may attempt to build HTML blocks with metadata after Javascript footer rendering has started. Use hsprintf() to flatten the markup earlier.

Test Plan

Put a T123 reference in the description of a Pholio image, then loaded a mock.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Jul 11 2019, 9:40 PM

Harbormaster completed remote builds in B23125: Diff 49257.Jul 11 2019, 9:41 PM

epriestley requested review of this revision.Jul 11 2019, 9:41 PM

epriestley mentioned this in T13332: Javelin behaviors which pass PHUIViews to configuration parameters fatal the page in an abrupt way.Jul 11 2019, 9:50 PM

amckinley accepted this revision.Jul 11 2019, 10:52 PM

This revision is now accepted and ready to land.Jul 11 2019, 10:52 PM

Closed by commit rP099919366b12: Fix "add more metadata" fatal in Pholio (authored by epriestley). · Explain WhyJul 11 2019, 10:56 PM

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP099919366b12: Fix "add more metadata" fatal in Pholio.

Revision Contents
Changeset List

Path

Size

src/

applications/

pholio/

view/

PholioMockImagesView.php

2 lines

Diff 49259

View Options

src/applications/pholio/view/PholioMockImagesView.php

Fix "add more metadata" fatal in PholioClosedPublicActions