Page MenuHomePhabricator

Fix "add more metadata" fatal in Pholio
ClosedPublic

Authored by epriestley on Jul 11 2019, 9:40 PM.
Tags
None
Referenced Files
F18830272: D20647.id49257.diff
Sat, Oct 25, 5:46 AM
F18709384: D20647.id49259.diff
Sep 29 2025, 12:05 AM
F18630144: D20647.diff
Sep 16 2025, 10:52 AM
F18567126: D20647.id.diff
Sep 9 2025, 3:32 PM
F18557974: D20647.diff
Sep 8 2025, 8:13 PM
F18528790: D20647.diff
Sep 6 2025, 9:48 PM
F18091036: D20647.id49257.diff
Aug 6 2025, 6:41 PM
F18090038: D20647.diff
Aug 6 2025, 1:48 PM
Subscribers
None

Details

Summary

Ref T13332. This fix isn't terribly satisfying, but resolves the issue: this behavior may attempt to build HTML blocks with metadata after Javascript footer rendering has started. Use hsprintf() to flatten the markup earlier.

Test Plan

Put a T123 reference in the description of a Pholio image, then loaded a mock.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable