Page MenuHomePhabricator

Fix "add more metadata" fatal in Pholio
ClosedPublic

Authored by epriestley on Jul 11 2019, 9:40 PM.

Details

Summary

Ref T13332. This fix isn't terribly satisfying, but resolves the issue: this behavior may attempt to build HTML blocks with metadata after Javascript footer rendering has started. Use hsprintf() to flatten the markup earlier.

Test Plan

Put a T123 reference in the description of a Pholio image, then loaded a mock.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Jul 11 2019, 9:40 PM
epriestley requested review of this revision.Jul 11 2019, 9:41 PM
amckinley accepted this revision.Jul 11 2019, 10:52 PM
This revision is now accepted and ready to land.Jul 11 2019, 10:52 PM
This revision was automatically updated to reflect the committed changes.