Page MenuHomePhabricator

Remove unused property "slug" from Workboard View controller
ClosedPublic

Authored by epriestley on Jun 29 2019, 8:06 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 14, 5:20 PM
Unknown Object (File)
Feb 26 2024, 9:32 AM
Unknown Object (File)
Feb 16 2024, 11:05 AM
Unknown Object (File)
Feb 5 2024, 12:28 AM
Unknown Object (File)
Feb 3 2024, 10:43 PM
Unknown Object (File)
Dec 26 2023, 8:56 PM
Unknown Object (File)
Dec 25 2023, 6:36 AM
Unknown Object (File)
Dec 23 2023, 7:48 PM
Subscribers
None

Details

Summary

Ref T4900. The Workboard view controller currently has a lot of different responsibilities (it's ~1,500 lines long) because it has to manage the board filter/sort state.

I'd like to split it up and make it easier to move some workboard features (like "move all tasks in column...") to other Controllers, so we can have smaller controllers implementing specific workflows.

I think the state handling isn't really all that bad, it just needs to be separated a little better than it currently is.

To start with, remove the unused "slug" property.

Test Plan

Searched for "slug", got no hits. This class is final and the property is private, so this is certainly unused.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable