Page MenuHomePhabricator

Remove unused property "slug" from Workboard View controller
ClosedPublic

Authored by epriestley on Jun 29 2019, 8:06 PM.
Tags
None
Referenced Files
F15445796: D20626.diff
Thu, Mar 27, 4:03 PM
F15411164: D20626.id49207.diff
Wed, Mar 19, 8:52 AM
F15409971: D20626.id49215.diff
Wed, Mar 19, 6:19 AM
F15399530: D20626.id.diff
Mon, Mar 17, 5:02 AM
F15396666: D20626.diff
Sun, Mar 16, 3:45 PM
F15396647: D20626.diff
Sun, Mar 16, 3:36 PM
F15382486: D20626.diff
Fri, Mar 14, 12:39 PM
F15377137: D20626.id49215.diff
Thu, Mar 13, 8:13 AM
Subscribers
None

Details

Summary

Ref T4900. The Workboard view controller currently has a lot of different responsibilities (it's ~1,500 lines long) because it has to manage the board filter/sort state.

I'd like to split it up and make it easier to move some workboard features (like "move all tasks in column...") to other Controllers, so we can have smaller controllers implementing specific workflows.

I think the state handling isn't really all that bad, it just needs to be separated a little better than it currently is.

To start with, remove the unused "slug" property.

Test Plan

Searched for "slug", got no hits. This class is final and the property is private, so this is certainly unused.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable