Page MenuHomePhabricator

Fix the "x" link in tokenizer tokens incorrectly closing dialogs
ClosedPublic

Authored by epriestley on Jun 28 2019, 3:43 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mar 16 2026, 8:59 AM
Unknown Object (File)
Mar 16 2026, 3:18 AM
Unknown Object (File)
Mar 16 2026, 3:12 AM
Unknown Object (File)
Feb 7 2026, 11:33 PM
Unknown Object (File)
Jan 31 2026, 2:25 AM
Unknown Object (File)
Jan 15 2026, 10:03 PM
Unknown Object (File)
Jan 14 2026, 9:58 PM
Unknown Object (File)
Dec 3 2025, 7:31 AM
Subscribers
None
Tokens
"Like" token, awarded by krisbuist.

Details

Summary

See https://discourse.phabricator-community.org/t/removing-tags-or-subscribers-from-a-maniphest-modal-causes-the-modal-to-close/2874.

My Javascript is rusty: '' + null == 'null'. Same for undefined. Use an explicit typecheck instead.

Test Plan

Clicked the "x" in a tokenizer token in a dialog, saw the token removed instead of the dialog closed.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable