Page MenuHomePhabricator

Fix the "x" link in tokenizer tokens incorrectly closing dialogs
ClosedPublic

Authored by epriestley on Jun 28 2019, 3:43 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Feb 18, 8:31 AM
Unknown Object (File)
Mon, Feb 10, 5:18 AM
Unknown Object (File)
Mon, Feb 10, 5:17 AM
Unknown Object (File)
Mon, Feb 10, 5:17 AM
Unknown Object (File)
Sun, Feb 2, 4:22 AM
Unknown Object (File)
Jan 28 2025, 5:18 AM
Unknown Object (File)
Jan 27 2025, 5:43 PM
Unknown Object (File)
Jan 22 2025, 2:10 PM
Subscribers
None
Tokens
"Like" token, awarded by krisbuist.

Details

Summary

See https://discourse.phabricator-community.org/t/removing-tags-or-subscribers-from-a-maniphest-modal-causes-the-modal-to-close/2874.

My Javascript is rusty: '' + null == 'null'. Same for undefined. Use an explicit typecheck instead.

Test Plan

Clicked the "x" in a tokenizer token in a dialog, saw the token removed instead of the dialog closed.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable