Page MenuHomePhabricator

Fix the "x" link in tokenizer tokens incorrectly closing dialogs
ClosedPublic

Authored by epriestley on Jun 28 2019, 3:43 PM.
Tags
None
Referenced Files
F18768929: D20623.diff
Wed, Oct 8, 5:55 AM
F18767197: D20623.id.diff
Tue, Oct 7, 9:12 PM
F18764966: D20623.id49201.diff
Tue, Oct 7, 8:49 AM
F18763342: D20623.diff
Mon, Oct 6, 11:51 PM
F18762998: D20623.diff
Mon, Oct 6, 10:04 PM
F18761107: D20623.id49202.diff
Mon, Oct 6, 12:18 PM
F18760411: D20623.id.diff
Mon, Oct 6, 9:12 AM
F18611397: D20623.id.diff
Sep 14 2025, 7:10 AM
Subscribers
None
Tokens
"Like" token, awarded by krisbuist.

Details

Summary

See https://discourse.phabricator-community.org/t/removing-tags-or-subscribers-from-a-maniphest-modal-causes-the-modal-to-close/2874.

My Javascript is rusty: '' + null == 'null'. Same for undefined. Use an explicit typecheck instead.

Test Plan

Clicked the "x" in a tokenizer token in a dialog, saw the token removed instead of the dialog closed.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable