Page MenuHomePhabricator

Fix the "x" link in tokenizer tokens incorrectly closing dialogs
ClosedPublic

Authored by epriestley on Jun 28 2019, 3:43 PM.
Tags
None
Referenced Files
F15528911: D20623.id49202.diff
Tue, Apr 22, 2:59 PM
F15522374: D20623.id49202.diff
Sun, Apr 20, 8:00 PM
F15513683: D20623.id.diff
Thu, Apr 17, 8:53 PM
F15510419: D20623.diff
Wed, Apr 16, 8:05 PM
F15463367: D20623.id49201.diff
Tue, Apr 1, 10:48 PM
F15449376: D20623.id49201.diff
Fri, Mar 28, 9:49 AM
F15445889: D20623.diff
Thu, Mar 27, 4:24 PM
F15383943: D20623.id49202.diff
Mar 14 2025, 6:23 PM
Subscribers
None
Tokens
"Like" token, awarded by krisbuist.

Details

Summary

See https://discourse.phabricator-community.org/t/removing-tags-or-subscribers-from-a-maniphest-modal-causes-the-modal-to-close/2874.

My Javascript is rusty: '' + null == 'null'. Same for undefined. Use an explicit typecheck instead.

Test Plan

Clicked the "x" in a tokenizer token in a dialog, saw the token removed instead of the dialog closed.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable