Page MenuHomePhabricator

Fix the "x" link in tokenizer tokens incorrectly closing dialogs
ClosedPublic

Authored by epriestley on Jun 28 2019, 3:43 PM.
Tags
None
Referenced Files
F22651692: D20623.id49201.diff
Wed, Sep 30, 11:32 PM
F22530471: D20623.diff
Mon, Sep 21, 3:00 PM
Unknown Object (File)
Fri, Sep 4, 2:05 AM
Unknown Object (File)
Aug 2 2026, 1:24 AM
Unknown Object (File)
Jun 30 2026, 10:42 AM
Unknown Object (File)
Jun 30 2026, 6:37 AM
Unknown Object (File)
Jun 22 2026, 10:32 AM
Unknown Object (File)
Jun 10 2026, 8:40 PM
Subscribers
None
Tokens
"Like" token, awarded by krisbuist.

Details

Summary

See https://discourse.phabricator-community.org/t/removing-tags-or-subscribers-from-a-maniphest-modal-causes-the-modal-to-close/2874.

My Javascript is rusty: '' + null == 'null'. Same for undefined. Use an explicit typecheck instead.

Test Plan

Clicked the "x" in a tokenizer token in a dialog, saw the token removed instead of the dialog closed.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable