Page MenuHomePhabricator

Fix the "x" link in tokenizer tokens incorrectly closing dialogs
ClosedPublic

Authored by epriestley on Jun 28 2019, 3:43 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jun 1, 7:42 PM
Unknown Object (File)
Tue, May 27, 10:16 PM
Unknown Object (File)
Mon, May 26, 9:45 PM
Unknown Object (File)
May 10 2025, 7:12 AM
Unknown Object (File)
Apr 27 2025, 2:18 AM
Unknown Object (File)
Apr 24 2025, 2:46 AM
Unknown Object (File)
Apr 22 2025, 2:59 PM
Unknown Object (File)
Apr 20 2025, 8:00 PM
Subscribers
None
Tokens
"Like" token, awarded by krisbuist.

Details

Summary

See https://discourse.phabricator-community.org/t/removing-tags-or-subscribers-from-a-maniphest-modal-causes-the-modal-to-close/2874.

My Javascript is rusty: '' + null == 'null'. Same for undefined. Use an explicit typecheck instead.

Test Plan

Clicked the "x" in a tokenizer token in a dialog, saw the token removed instead of the dialog closed.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable