Page MenuHomePhabricator
Create Task
Maniphest T13345

Ferret does not match documents with no title
Closed, ResolvedPublic
Actions

Description

See D20650. Currently, Ferret will not return a result if the document doesn't have a title, even if the document matches the search query in other fields (body, etc).

Empty fields are discarded by PhabricatorFerretFulltextEngineExtension and not inserted into the ffield table, but PhabricatorCursorPagedPolicyAwareQuery later does a JOIN against the title field in this table to apply a ranking order.

I think we can fix this by turning the JOIN into a LEFT JOIN and maybe tweaking the ranking logic slightly.

Revisions and Commits

Restricted Differential RevisionRestricted Diffusion Commit

Event Timeline

epriestley triaged this task as Low priority.Jul 18 2019, 5:16 PM
epriestley created this task.
Herald added a subscriber: amckinley. · View Herald TranscriptJul 18 2019, 5:16 PM
epriestley added a revision: Restricted Differential Revision.Jul 18 2019, 5:22 PM
amckinley updated the task description. (Show Details)Jul 18 2019, 5:26 PM
epriestley closed this task as Resolved by committing Restricted Diffusion Commit.Jul 18 2019, 5:37 PM
epriestley added a commit: Restricted Diffusion Commit.
Phabricator · Built by Phacility