Page MenuHomePhabricator

Move workboard "View as Query" workflow to a separate controller
ClosedPublic

Authored by epriestley on Jul 2 2019, 12:50 PM.
Tags
None
Referenced Files
F17849161: D20633.diff
Sun, Jul 27, 8:19 AM
F17826945: D20633.id.diff
Sat, Jul 26, 7:47 AM
F17805324: D20633.diff
Fri, Jul 25, 12:27 PM
F17796999: D20633.id49232.diff
Fri, Jul 25, 1:28 AM
F17761035: D20633.diff
Tue, Jul 22, 8:21 PM
F17631063: D20633.diff
Thu, Jul 10, 12:31 PM
Unknown Object (File)
Tue, Jul 1, 5:55 PM
Unknown Object (File)
Sun, Jun 29, 5:49 PM
Subscribers
None

Details

Summary

Depends on D20632. Ref T4900. As with other workflows on the board controller, this one is currently in the giant main "do everything" method. Move it to a separate controller.

This makes one material improvement: previously, we built the full board and did layout on all the cards before building the query. However, we do not actually need to do this: we don't need the cards. Instead, just do layout without handing over any card PHIDs. This is slightly faster, particularly on large boards.

Test Plan
  • Clicked "View as Query" on a board, got a query page for the column.
  • Applied a custom filter, then clicked "View as Query" on a board. Got a query page merging the two filters.
  • Applied a custom filter, then clicked "Veiw as Query" on a board, in a subproject column. Got a query page merging the two filters, respecting the project-ness of the column.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable