HomePhabricator

Fix transaction title rendering for AuthenticationConfigs

Description

Fix transaction title rendering for AuthenticationConfigs

Summary: I was poking around in PhabricatorAuthProviderViewController and noticed that none of the subclass-specific rendering was working. Figured out that no one ever calls PhabricatorAuthProviderConfigTransaction->setProvider(), so instead of adding all those calls, just pull the provider out of the config object.

Test Plan:
Before:

Screen Shot 2019-07-17 at 12.28.51 PM.png (541×479 px, 46 KB)

After:
Screen Shot 2019-07-17 at 12.29.00 PM.png (565×579 px, 52 KB)

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D20655

Details

Provenance
amckinleyAuthored on Jul 17 2019, 7:29 PM
amckinleyPushed on Jul 17 2019, 7:41 PM
Reviewer
epriestley
Differential Revision
D20655: Fix transaction title rendering for AuthenticationConfigs
Parents
rP2f313a0e0d55: Remove "unstable" status and T2784-specific warning message
Branches
Unknown
Tags
Unknown
Build Status
Buildable 23140
Build 31777: Run Core Tests