Page MenuHomePhabricator

Tailor "Restart All Builds" for the complex realities of modern build restart rules
ClosedPublic

Authored by epriestley on Jul 24 2019, 3:14 PM.

Details

Summary

Fixes T13348. Currently, the Harbormaster UI shows "Restart All Builds", but it really means "Restart Restartable Builds", which is often fewer than "All" builds (because of autobuilds, permissions, and/or configuration).

Remove the misleading term "All" and make the workflow preview exactly which builds will and will not be affected, and why.

Test Plan

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Jul 24 2019, 3:14 PM
Owners added a subscriber: Restricted Owners Package.Jul 24 2019, 3:14 PM
epriestley requested review of this revision.Jul 24 2019, 3:16 PM
amckinley accepted this revision.Jul 24 2019, 3:43 PM
This revision is now accepted and ready to land.Jul 24 2019, 3:43 PM