jcox (Josh Cox)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

Badges

User Since
Aug 22 2016, 4:36 PM (21 w, 4 d)
Availability
Available

Recent Activity

Yesterday

jcox added inline comments to rP2dfe79cfc713: When updating revisions in response to commits, reuse previously generated diffs.
Fri, Jan 20, 8:06 PM

Thu, Jan 19

jcox added a comment to D17233: Remove motivator panel.

Thu, Jan 19, 11:59 PM

Mon, Jan 16

jcox added a comment to T12084: `differential.updaterevision` conduit method no longer updates custom fields.

ah yep that seemed to work. I was still specifying releaseNotes for the field which I'm guessing is why it wasn't getting saved. Thanks again for all the help! If you're ever in Pittsburgh I think I owe you about 50 beers at this point.

Mon, Jan 16, 5:12 PM · Bug Report
jcox added a comment to T12084: `differential.updaterevision` conduit method no longer updates custom fields.

I pulled in that change and I'm still seeing the same issue. Editing the field from /differential/revision/edit/... seems to work normally, but adding it via the differential.createrevision endpoint does not.

Mon, Jan 16, 4:25 PM · Bug Report
jcox added a comment to T12084: `differential.updaterevision` conduit method no longer updates custom fields.

Checking in for guidance in case this is the wrong way to go. I have a custom field which extends DifferentialStoredCustomField and I'm trying to convert it in the same way as the above. Thus far my field isn't being saved when calling differential.createrevision. I've included the DifferentialCommitMessageCustomField and the DifferentialStoredCustomField below.

Mon, Jan 16, 3:12 PM · Bug Report

Wed, Jan 11

jcox closed T12084: `differential.updaterevision` conduit method no longer updates custom fields as "Resolved".

Thanks that did it! Still working through an issue with one of our more *ahem* exotic applications, but I suspect that'll be a more involved refactor on our end.

Wed, Jan 11, 4:26 PM · Bug Report

Tue, Jan 10

jcox added a comment to T12084: `differential.updaterevision` conduit method no longer updates custom fields.

Doing that without defining getFieldTransactions() in my class yields this exception:

Transaction with key "1" has invalid type "devTestPHIDs". This type is not recognized. Valid types are: update, comment, title, summary, testPlan, reviewers.add, reviewers.remove, reviewers.set, repositoryPHID, tasks.add, tasks.remove, tasks.set, view, edit, projects.add, projects.remove, projects.set, subscribers.add, subscribers.remove, subscribers.set, phabricator:auditors.
Tue, Jan 10, 7:39 PM · Bug Report
jcox added a comment to T12084: `differential.updaterevision` conduit method no longer updates custom fields.

Thanks for the help Evan. I've gone through and converted everything as you suggested. The conduit method then started telling me

Tue, Jan 10, 6:31 PM · Bug Report

Mon, Jan 9

jcox created T12084: `differential.updaterevision` conduit method no longer updates custom fields.
Mon, Jan 9, 4:22 PM · Bug Report

Dec 9 2016

jcox abandoned D17018: Add a `title` field to the `maniphest.query` conduit method.

Choosing "Abandon Revision" because "Abandon Revision, Set it on Fire, and Pretend it Never Existed" isn't an option. I'll get a diff ready that adds that as an option.

Dec 9 2016, 9:06 PM
jcox added a comment to D17018: Add a `title` field to the `maniphest.query` conduit method.

Oh god. I step away for 5 minutes and I'm now on the phacility hit-list.

Dec 9 2016, 9:04 PM
jcox added a comment to D17018: Add a `title` field to the `maniphest.query` conduit method.

haha I had a feeling this probably fell into the category of things that are in the process of being done a better/holistic way

Dec 9 2016, 8:30 PM
jcox retitled D17018: Add a `title` field to the `maniphest.query` conduit method from to Add a `title` field to the `maniphest.query` conduit method.
Dec 9 2016, 8:17 PM

Dec 6 2016

jcox raised the priority of T11955: Tag autocomplete doesn't always include milestones from "Normal" to "Needs Triage".
Dec 6 2016, 12:28 PM · Projects
jcox edited the description of T11955: Tag autocomplete doesn't always include milestones.
Dec 6 2016, 12:25 PM · Projects
jcox created T11955: Tag autocomplete doesn't always include milestones.
Dec 6 2016, 12:23 PM · Projects

Dec 5 2016

jcox updated subscribers of T11951: Make conduit more secure.
Dec 5 2016, 6:02 PM · Feature Request
jcox created T11951: Make conduit more secure.
Dec 5 2016, 6:02 PM · Feature Request

Nov 22 2016

jcox awarded E1216: Errands a Dislike token.
Nov 22 2016, 10:00 PM
jcox committed rPac66522c2e27: Add a flag to ./bin/worker to select tasks based on their failureCount (authored by jcox).
Add a flag to ./bin/worker to select tasks based on their failureCount
Nov 22 2016, 2:11 AM
jcox closed D16906: Add a flag to ./bin/worker to select tasks based on their failureCount by committing rPac66522c2e27: Add a flag to ./bin/worker to select tasks based on their failureCount.
Nov 22 2016, 2:11 AM
jcox updated the diff for D16906: Add a flag to ./bin/worker to select tasks based on their failureCount.

Use <= rather than <

Nov 22 2016, 2:09 AM
jcox requested review of D16906: Add a flag to ./bin/worker to select tasks based on their failureCount.

@epriestley do these changes look alright? I pulled most of PhabricatorWorkerArchiveTaskQuery up into the abstract PhabricatorWorkerTaskQuery and then added PhabricatorWorkerActiveTaskQuery. That made it more straightforward to just AND all the constraints together.

Nov 22 2016, 2:03 AM
jcox updated the diff for D16906: Add a flag to ./bin/worker to select tasks based on their failureCount.

Backed PhabricatorWorkerActiveTasks with an actual query object and refactored to share
some logic between Active and Archived tasks. Also removed some overeager indentations.

Nov 22 2016, 12:23 AM

Nov 21 2016

jcox added a comment to T11902: Periods in repository shortnames make the repo unreachable.

Confirmed this on my local. It seems to be due to D16851, specifically this line: https://secure.phabricator.com/source/phabricator/browse/master/src/applications/diffusion/application/PhabricatorDiffusionApplication.php$104.

Nov 21 2016, 8:02 PM · Bug Report
jcox retitled D16906: Add a flag to ./bin/worker to select tasks based on their failureCount from to Add a flag to ./bin/worker to select tasks based on their failureCount.
Nov 21 2016, 7:04 PM

Nov 10 2016

jcox added a comment to T11845: Media with "autoplay" should possibly not autoplay in news feed.

Pretty sure this works as intended

Nov 10 2016, 8:08 PM · Prioritized, Remarkup
jcox awarded T11845: Media with "autoplay" should possibly not autoplay in news feed a Y So Serious token.
Nov 10 2016, 7:52 PM · Prioritized, Remarkup
jcox awarded T11845: Media with "autoplay" should possibly not autoplay in news feed a Party Time token.
Nov 10 2016, 7:52 PM · Prioritized, Remarkup
jcox added a comment to T11843: Hitting "show older changes" throws an exception on DifferentialTransactionView::setLeftDiff() with Quicksand enabled.

{auto-playing-audio WilhelmScream.mp3}

Nov 10 2016, 7:43 PM · Quicksand, Bug Report
jcox added a comment to T11843: Hitting "show older changes" throws an exception on DifferentialTransactionView::setLeftDiff() with Quicksand enabled.

Yes I did have the persistent chat pane open. Also can't seem to repro without it.

Nov 10 2016, 7:41 PM · Quicksand, Bug Report
jcox added a comment to T11843: Hitting "show older changes" throws an exception on DifferentialTransactionView::setLeftDiff() with Quicksand enabled.

The other errors that appear in DarkConsole:

Nov 10 2016, 3:32 PM · Quicksand, Bug Report
jcox created T11843: Hitting "show older changes" throws an exception on DifferentialTransactionView::setLeftDiff() with Quicksand enabled.
Nov 10 2016, 3:28 PM · Quicksand, Bug Report
jcox placed T8628: Modernize AphrontControllers to implement handleRequest up for grabs.
Nov 10 2016, 2:41 PM · Contributor Onboarding, Modernization, Badge Awarded, Aphront
jcox moved T8628: Modernize AphrontControllers to implement handleRequest from Basic to Ready on the Contributor Onboarding board.
Nov 10 2016, 2:40 PM · Contributor Onboarding, Modernization, Badge Awarded, Aphront
jcox created T11842: Create notification option for "someone mentions me".
Nov 10 2016, 1:01 PM

Oct 28 2016

jcox created T11798: Allow harbormaster build logs to be downloaded via the API.
Oct 28 2016, 5:54 PM · Harbormaster

Oct 14 2016

jcox created T11761: Return to previous page after exiting high security mode.
Oct 14 2016, 3:04 PM · Security

Oct 13 2016

jcox added a comment to T11708: Daemons erroneously saying "Diff does not exist".

Hmmm I'm not seeing those lines in that file anywhere. On the current head of master, I'm pretty sure the viewer is always set to PhabricatorUser::getOmnipotentUser() in TransactionPublishWorker. Although maybe that isn't making it all the way to the policy aware query in every case.

Oct 13 2016, 11:02 AM · Daemons, Differential, Bug Report

Oct 12 2016

jcox added a comment to T11708: Daemons erroneously saying "Diff does not exist".

@jessjohnson I still haven't had a chance to dig further into this, but I'll report back when I do (or if you figure anything out, please let me know). I don't think killing off the tasks permanently is really an option since this seems to happen for specific degenerate instances of otherwise-needed tasks. Perhaps not allowing these tasks to retry would be an okay bandaid, but I'd still like to figure out the underlying problem if we can.

Oct 12 2016, 1:42 AM · Daemons, Differential, Bug Report

Oct 11 2016

jcox added a comment to T11752: Drydock worker tasks should have higher priority.

Nope we don't have that integrated in yet (just missed our last cutoff). Once we get that pulled in I'll confirm it clears up the issue.

Oct 11 2016, 10:27 PM · Drydock
jcox created T11752: Drydock worker tasks should have higher priority.
Oct 11 2016, 9:39 PM · Drydock
jcox added a comment to T11693: Make drydock command interfaces accessible via SSH workflows.

Evan, do you think there is a route forward with this that would be feasible for me to implement upstream?

Oct 11 2016, 11:17 AM · Restricted Project, Drydock

Oct 6 2016

jcox closed T11734: Test as "Invalid".
Oct 6 2016, 10:25 AM · Bug Report

Oct 5 2016

jcox added a comment to T11708: Daemons erroneously saying "Diff does not exist".

Ah yeah it could be related to that (policy errors/unit test failures), although I wouldn't really describe this as "extremely rare" (except of course when I'm trying to make it happen). Some stats from grepping through logs: since last week it looks like this error has happened 73k times involving 193 distinct diffs. It's like the daemons are laughing at my inability to repro it.

Oct 5 2016, 7:53 PM · Daemons, Differential, Bug Report
jcox claimed T11708: Daemons erroneously saying "Diff does not exist".

Just spent a bit of time trying to repro this in a script but could not. The diffs always load successfully from the script. I even tried waiting until right after one of the errors popped up in the logs and then queried for that diff via the script right away.

Oct 5 2016, 7:17 PM · Daemons, Differential, Bug Report

Sep 28 2016

jcox created T11708: Daemons erroneously saying "Diff does not exist".
Sep 28 2016, 6:55 PM · Daemons, Differential, Bug Report
jcox committed rP32d660c08f46: Added a `token_token` table in anticipation of some data-driven tokens (authored by jcox).
Added a `token_token` table in anticipation of some data-driven tokens
Sep 28 2016, 3:35 PM
jcox added a commit to T11217: Make Tokens modular / real application: rP32d660c08f46: Added a `token_token` table in anticipation of some data-driven tokens.
Sep 28 2016, 3:35 PM · Restricted Project, Contributor Onboarding, Celerity, Tokens
jcox closed D16621: Added a `token_token` table in anticipation of some data-driven tokens by committing rP32d660c08f46: Added a `token_token` table in anticipation of some data-driven tokens.
Sep 28 2016, 3:35 PM
jcox updated the diff for D16621: Added a `token_token` table in anticipation of some data-driven tokens.

Gonna go ahead and say no one should be automatically subscribed to tokens

Sep 28 2016, 3:20 PM
jcox updated the diff for D16621: Added a `token_token` table in anticipation of some data-driven tokens.

Fixed issues brought up in CR

Sep 28 2016, 3:18 PM
jcox added inline comments to D16621: Added a `token_token` table in anticipation of some data-driven tokens.
Sep 28 2016, 3:13 PM
jcox retitled D16621: Added a `token_token` table in anticipation of some data-driven tokens from to Added a `token_token` table in anticipation of some data-driven tokens.
Sep 28 2016, 2:41 PM
jcox added a revision to T11217: Make Tokens modular / real application: D16621: Added a `token_token` table in anticipation of some data-driven tokens.
Sep 28 2016, 2:41 PM · Restricted Project, Contributor Onboarding, Celerity, Tokens

Sep 27 2016

jcox committed rP0fc05ab47edd: Link to badge view from people profile view (authored by jcox).
Link to badge view from people profile view
Sep 27 2016, 7:32 PM
jcox closed T10715: Badge name on badge cards should be a link to the badge page as "Resolved" by committing rP0fc05ab47edd: Link to badge view from people profile view.
Sep 27 2016, 7:31 PM · Contributor Onboarding, Badges
jcox closed D16604: Link to badge view from people profile view by committing rP0fc05ab47edd: Link to badge view from people profile view.
Sep 27 2016, 7:31 PM
epriestley awarded D16604: Link to badge view from people profile view a Party Time token.
Sep 27 2016, 7:30 PM
jcox retitled D16604: Link to badge view from people profile view from to Link to badge view from people profile view.
Sep 27 2016, 7:27 PM
jcox added a revision to T10715: Badge name on badge cards should be a link to the badge page: D16604: Link to badge view from people profile view.
Sep 27 2016, 7:27 PM · Contributor Onboarding, Badges
jcox committed rP6649b0cef890: Remove "Application" field from ConduitSearchEngine (authored by jcox).
Remove "Application" field from ConduitSearchEngine
Sep 27 2016, 6:34 PM
jcox closed T9063: Conduit application search as "Resolved" by committing rP6649b0cef890: Remove "Application" field from ConduitSearchEngine.
Sep 27 2016, 6:34 PM · Contributor Onboarding, Restricted Project, Conduit
jcox closed D16602: Remove "Application" field from ConduitSearchEngine by committing rP6649b0cef890: Remove "Application" field from ConduitSearchEngine.
Sep 27 2016, 6:34 PM
jcox updated the diff for D16602: Remove "Application" field from ConduitSearchEngine.

removed another vestige of application names

Sep 27 2016, 6:32 PM
jcox updated the diff for D16602: Remove "Application" field from ConduitSearchEngine.

DELETE MOARRR CODE

Sep 27 2016, 5:59 PM
jcox added a revision to T9063: Conduit application search: D16602: Remove "Application" field from ConduitSearchEngine.
Sep 27 2016, 5:53 PM · Contributor Onboarding, Restricted Project, Conduit
jcox retitled D16602: Remove "Application" field from ConduitSearchEngine from to Remove "Application" field from ConduitSearchEngine.
Sep 27 2016, 5:53 PM
jcox committed rPfc821188483e: Expose conduit API methods for Phurl URLs (authored by jcox).
Expose conduit API methods for Phurl URLs
Sep 27 2016, 4:53 PM
jcox closed D16600: Expose conduit API methods for Phurl URLs by committing rPfc821188483e: Expose conduit API methods for Phurl URLs.
Sep 27 2016, 4:53 PM
jcox closed T10681: Add Phurl Conduit API methods as "Resolved" by committing rPfc821188483e: Expose conduit API methods for Phurl URLs.
Sep 27 2016, 4:53 PM · Contributor Onboarding, Restricted Project, Conduit, Phurl
jcox updated the diff for D16600: Expose conduit API methods for Phurl URLs.

Make getRedirectURI always have a domain

Sep 27 2016, 4:45 PM
jcox updated the diff for D16600: Expose conduit API methods for Phurl URLs.

s/phurl/Phurl/

Sep 27 2016, 4:23 PM
jcox updated the diff for D16600: Expose conduit API methods for Phurl URLs.

Added short URL to results

Sep 27 2016, 4:21 PM
jcox updated the diff for D16600: Expose conduit API methods for Phurl URLs.

Added ability to search by URL name substring

Sep 27 2016, 3:46 PM
jcox updated the test plan for D16600: Expose conduit API methods for Phurl URLs.
Sep 27 2016, 2:34 PM
jcox retitled D16600: Expose conduit API methods for Phurl URLs from to Expose conduit API methods for Phurl URLs.
Sep 27 2016, 2:34 PM
jcox added a revision to T10681: Add Phurl Conduit API methods : D16600: Expose conduit API methods for Phurl URLs.
Sep 27 2016, 2:34 PM · Contributor Onboarding, Restricted Project, Conduit, Phurl

Sep 26 2016

yelirekim awarded D16597: Remarkup rule to embed images a Pterodactyl token.
Sep 26 2016, 9:57 PM
jcox committed rP26b29a60c0f8: Remarkup rule to embed images (authored by jcox).
Remarkup rule to embed images
Sep 26 2016, 9:46 PM
jcox added a commit to T4190: Rebuild remarkup image proxying: rP26b29a60c0f8: Remarkup rule to embed images.
Sep 26 2016, 9:46 PM · Contributor Onboarding, Remarkup
jcox closed D16597: Remarkup rule to embed images by committing rP26b29a60c0f8: Remarkup rule to embed images.
Sep 26 2016, 9:46 PM
jcox updated the diff for D16597: Remarkup rule to embed images.

Clean up regex

Sep 26 2016, 9:37 PM
epriestley awarded D16597: Remarkup rule to embed images a Party Time token.
Sep 26 2016, 8:48 PM
jcox updated the diff for D16597: Remarkup rule to embed images.

Updated based on CR comments

Sep 26 2016, 8:43 PM
jcox updated D16597: Remarkup rule to embed images.
Sep 26 2016, 7:30 PM
jcox updated the diff for D16597: Remarkup rule to embed images.

Added parameters for width, height, alt, layout, and href

Sep 26 2016, 6:32 PM
jcox added a comment to D16597: Remarkup rule to embed images.

As far as dealing with URLs where the protocol isn't specified I see a few possible approaches:

Sep 26 2016, 4:52 PM
jcox updated the diff for D16597: Remarkup rule to embed images.

Use null rather than empty string.

Sep 26 2016, 4:37 PM
jcox updated the diff for D16597: Remarkup rule to embed images.

more succinct alias checking for src key

Sep 26 2016, 3:46 PM
jcox added inline comments to D16597: Remarkup rule to embed images.
Sep 26 2016, 3:40 PM
jcox added a comment to D16597: Remarkup rule to embed images.

All of the following syntaxes work now:

Sep 26 2016, 3:39 PM
jcox updated the diff for D16597: Remarkup rule to embed images.

Now using the imageproxy endpoint.

Sep 26 2016, 3:37 PM
jcox committed rP7d576c3f94b5: Fix a bug in the imageproxy controller (authored by jcox).
Fix a bug in the imageproxy controller
Sep 26 2016, 2:55 PM
jcox closed D16598: Fix a bug in the imageproxy controller by committing rP7d576c3f94b5: Fix a bug in the imageproxy controller.
Sep 26 2016, 2:55 PM
epriestley awarded D16598: Fix a bug in the imageproxy controller a Hungry Hippo token.
Sep 26 2016, 2:35 PM
jcox awarded D16598: Fix a bug in the imageproxy controller a Dislike token.
Sep 26 2016, 2:25 PM
jcox updated D16598: Fix a bug in the imageproxy controller.
Sep 26 2016, 2:19 PM
jcox retitled D16598: Fix a bug in the imageproxy controller from to Fix a bug in the imageproxy controller.
Sep 26 2016, 2:18 PM
jcox retitled D16597: Remarkup rule to embed images from Added the remarkup rule to embed images. Next step is actually using the imageproxy for it. to Remarkup rule to embed images.
Sep 26 2016, 2:02 PM