jcox (Josh Cox)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Aug 22 2016, 4:36 PM (51 w, 2 d)
Availability
Available

Recent Activity

Mon, Jul 24

jcox awarded T9041: Control access to administrator capabilities with custom policies a Like token.
Mon, Jul 24, 11:34 AM · FreeBSD, Policy, People

Jul 12 2017

jcox added a comment to D18111: Use keywords instead of ints to update task priority in ManiphestEditEngine.

This change appears to have made maniphest.edit (on the head of master) start failing on the following:

echo '{
  "transactions": [
    {
      "type": "priority",
      "value": "50"
    }
  ],
  "objectIdentifier": 12
}' | arc call-conduit maniphest.edit
Jul 12 2017, 1:34 PM

Jun 30 2017

jcox added a comment to T12880: Expose the ability to add some JS to every page.

Haha to be clear we're using an open-source self-hosted tracking solution, I was just throwing GA out there as an example. But I do understand your point vis-a-vis data security.

Jun 30 2017, 5:37 PM · Feature Request
jcox added a comment to T12880: Expose the ability to add some JS to every page.

Why do you want to track users with Google Analytics or a similar library?

Jun 30 2017, 2:17 PM · Feature Request

Jun 28 2017

jcox added a comment to T12880: Expose the ability to add some JS to every page.

Jun 28 2017, 7:55 PM · Feature Request
jcox created T12880: Expose the ability to add some JS to every page.
Jun 28 2017, 7:42 PM · Feature Request

Jun 23 2017

chad awarded rGITTESTd5a51a9e80fa: added a room guardian a Hungry Hippo token.
Jun 23 2017, 4:34 PM
jcox committed rGITTESTd5a51a9e80fa: added a room guardian (authored by jcox).
added a room guardian
Jun 23 2017, 4:27 PM

Jun 8 2017

jcox added a comment to T12804: Diffusion pre-redesign UI feedback (June 2017).

Jun 8 2017, 3:21 PM · Diffusion, Design & Planning
jcox awarded E1537: Dentist a Cup of Joe token.
Jun 8 2017, 1:43 PM

May 24 2017

epriestley awarded T12753: Pagination breaks when a task is tagged with two subprojects that have a mutual ancestor a Mountain of Wealth token.
May 24 2017, 7:04 PM · Bug Report
jcox added a comment to T12753: Pagination breaks when a task is tagged with two subprojects that have a mutual ancestor.

haha nice. I just posted this comment on our downstream task tracking this.

May 24 2017, 6:54 PM · Bug Report
jcox added a comment to T12753: Pagination breaks when a task is tagged with two subprojects that have a mutual ancestor.

I couldn't find a project with multiple subprojects on this install otherwise I would have linked you to an example

May 24 2017, 6:38 PM · Bug Report
jcox created T12753: Pagination breaks when a task is tagged with two subprojects that have a mutual ancestor.
May 24 2017, 6:34 PM · Bug Report
Pawka awarded T11518: Make arc feature much more fancy and fun a Like token.
May 24 2017, 2:31 PM · Restricted Project, Feature Request

May 17 2017

jcox awarded T12681: Upcoming Support Product / End of Paid Prioritization a Mountain of Wealth token.
May 17 2017, 11:47 AM · Guides, Phacility

May 3 2017

jcox awarded D12620: Add GoFmt linter a Like token.
May 3 2017, 3:18 PM
jcox awarded D12120: Add GoVet Linter a Like token.
May 3 2017, 3:17 PM

May 1 2017

jcox committed rPf2ca348b3a7a: Set project's ObjectName to its PHID when it doesn't have a hashtag (authored by jcox).
Set project's ObjectName to its PHID when it doesn't have a hashtag
May 1 2017, 1:26 PM
jcox closed D17807: Set project's ObjectName to its PHID when it doesn't have a hashtag by committing rPf2ca348b3a7a: Set project's ObjectName to its PHID when it doesn't have a hashtag.
May 1 2017, 1:26 PM
jcox closed T12659: arc diff errors when a milestone is a group reviewer as Resolved by committing rPf2ca348b3a7a: Set project's ObjectName to its PHID when it doesn't have a hashtag.
May 1 2017, 1:26 PM · Bug Report
jcox created D17807: Set project's ObjectName to its PHID when it doesn't have a hashtag.
May 1 2017, 1:19 PM
jcox added a revision to T12659: arc diff errors when a milestone is a group reviewer: D17807: Set project's ObjectName to its PHID when it doesn't have a hashtag.
May 1 2017, 1:19 PM · Bug Report
jcox added a comment to T12659: arc diff errors when a milestone is a group reviewer.

👍 testing it now.

May 1 2017, 12:58 PM · Bug Report
jcox created T12659: arc diff errors when a milestone is a group reviewer.
May 1 2017, 12:33 PM · Bug Report

Apr 10 2017

jcox added a comment to T9499: Revision repository is not updated when it is changed in the UI.

We've run into this a couple of times. When a user updates a revision through the web UI, the repository field (at /differential/revision/update/{REVID}/) doesn't auto-populate with the revision's repository and people sometimes forget to fill it out. This causes the repository to be stripped from the revision as well.

Apr 10 2017, 5:31 PM · Differential, Conduit

Apr 2 2017

amp343 awarded D17594: Automatically phix phrequent spelling phlubs phor all phabricator phorm phields a Dat Boi token.
Apr 2 2017, 4:25 AM

Apr 1 2017

bjshively awarded D17594: Automatically phix phrequent spelling phlubs phor all phabricator phorm phields a Pterodactyl token.
Apr 1 2017, 11:14 PM
chad awarded D17594: Automatically phix phrequent spelling phlubs phor all phabricator phorm phields a Pirate Logo token.
Apr 1 2017, 10:16 PM
johnny-bit awarded D17594: Automatically phix phrequent spelling phlubs phor all phabricator phorm phields a The World Burns token.
Apr 1 2017, 9:47 PM
timhirsh awarded D17594: Automatically phix phrequent spelling phlubs phor all phabricator phorm phields a Party Time token.
Apr 1 2017, 7:13 PM
jcox added a comment to D17594: Automatically phix phrequent spelling phlubs phor all phabricator phorm phields.

This will make it diphphicult to log in iph your username contains an 'f'. Should I add a database migration to automatically phix peoples' usernames?

Apr 1 2017, 6:05 PM
jcox updated the diff for D17594: Automatically phix phrequent spelling phlubs phor all phabricator phorm phields.

Update celerity map

Apr 1 2017, 5:49 PM
jcox created D17594: Automatically phix phrequent spelling phlubs phor all phabricator phorm phields.
Apr 1 2017, 5:46 PM

Mar 28 2017

jcox updated the task description for T12455: Tag order on tasks matters for subprojects and milestones.
Mar 28 2017, 12:22 PM · Bug Report
jcox created T12455: Tag order on tasks matters for subprojects and milestones.
Mar 28 2017, 12:18 PM · Bug Report

Mar 27 2017

jcox placed T9900: Figlet does not properly render apostrophes with some characters up for grabs.

Mar 27 2017, 4:36 PM · Contributor Onboarding, Remarkup

Mar 23 2017

jcox awarded T12441: Implement "Phabricator Stories" a Dat Boi token.
Mar 23 2017, 6:09 PM

Feb 17 2017

jcox awarded F905540: cat3.png a 100 token.
Feb 17 2017, 6:59 PM
jcox awarded F905540: cat3.png a Burninate token.
Feb 17 2017, 6:59 PM

Feb 15 2017

jcox backed I2 Donate to Phacility with $20.00 USD.
Feb 15 2017, 6:37 PM · Phacility

Feb 10 2017

jcox committed rPe0675b28d8e6: Pass exception to PhutilProxyException (authored by jcox).
Pass exception to PhutilProxyException
Feb 10 2017, 5:39 PM
jcox closed D17335: Pass exception to PhutilProxyException by committing rPe0675b28d8e6: Pass exception to PhutilProxyException.
Feb 10 2017, 5:38 PM
jcox closed T12243: Repository cluster engine throws InvalidArgument exception when failing to acquire a write lock as Resolved by committing rPe0675b28d8e6: Pass exception to PhutilProxyException.
Feb 10 2017, 5:38 PM · Diffusion, Bug Report
jcox updated the diff for D17335: Pass exception to PhutilProxyException.

learn to count parens

Feb 10 2017, 5:32 PM
jcox created D17335: Pass exception to PhutilProxyException.
Feb 10 2017, 5:30 PM
jcox added a revision to T12243: Repository cluster engine throws InvalidArgument exception when failing to acquire a write lock: D17335: Pass exception to PhutilProxyException.
Feb 10 2017, 5:30 PM · Diffusion, Bug Report
jcox added a comment to E1370: Last-Minute Pup Adventures.

In exchange, here is a cat on a mat trying to do some yoga. Not my cat, but she was at an airbnb I stayed at and my decision to not steal her came down to a coin toss

Feb 10 2017, 1:18 PM
jcox added a comment to E1370: Last-Minute Pup Adventures.

that's a great pup. 10/10

Feb 10 2017, 1:13 PM

Feb 9 2017

jcox committed rARC224986af634e: Provide a better error message when an invalid ID is given to arc patch (authored by jcox).
Provide a better error message when an invalid ID is given to arc patch
Feb 9 2017, 7:25 PM
jcox closed D17325: Provide a better error message when an invalid ID is given to arc patch by committing rARC224986af634e: Provide a better error message when an invalid ID is given to arc patch.
Feb 9 2017, 7:24 PM
jcox closed T8937: Unclear exception when patching non-existant revision as Resolved by committing rARC224986af634e: Provide a better error message when an invalid ID is given to arc patch.
Feb 9 2017, 7:24 PM · Arcanist

Feb 8 2017

jcox added a comment to D17325: Provide a better error message when an invalid ID is given to arc patch.

Yeah I think it probably makes sense to not distinguish between a permission error and invalid resource for the reasons you said. I know amazon S3 does a similar thing and just returns a 403 in both cases.

Feb 8 2017, 7:36 PM
jcox updated the diff for D17325: Provide a better error message when an invalid ID is given to arc patch.

Update message to account for permission error

Feb 8 2017, 7:29 PM
jcox added a comment to E1370: Last-Minute Pup Adventures.

send puppy pics please

Feb 8 2017, 7:04 PM
jcox added a comment to D17325: Provide a better error message when an invalid ID is given to arc patch.

I just ran into this again but for a completely different reason. The user assured me multiple times that they were entering a valid diff ID and I repeatedly explained, "no, you don't understand. I Know What I'm Doing™".

Feb 8 2017, 5:44 PM
jcox added a comment to D17324: Add back the motivator panel.

Feb 8 2017, 3:35 PM
jcox merged T12231: Projects with very long names cause menu bar to overlap workboard into T12214: Navigation menus in applications have no maximum width.
Feb 8 2017, 3:23 PM · PHUI
jcox merged task T12231: Projects with very long names cause menu bar to overlap workboard into T12214: Navigation menus in applications have no maximum width.
Feb 8 2017, 3:23 PM · Workboards, Bug Report
jcox added a comment to T12231: Projects with very long names cause menu bar to overlap workboard.

verified

Feb 8 2017, 3:23 PM · Workboards, Bug Report
jcox added a comment to T12231: Projects with very long names cause menu bar to overlap workboard.

Just to clarify, I tested it locally, not on this install.

Feb 8 2017, 2:17 PM · Workboards, Bug Report
jcox added a revision to T8937: Unclear exception when patching non-existant revision: D17325: Provide a better error message when an invalid ID is given to arc patch.
Feb 8 2017, 2:02 PM · Arcanist
jcox created D17325: Provide a better error message when an invalid ID is given to arc patch.
Feb 8 2017, 2:02 PM

Feb 7 2017

jcox added a comment to T8937: Unclear exception when patching non-existant revision.

Just spent some time tracking down what ended up being this issue. I wonder if adding a check in this block to query for the given revision would be sufficient enough to detect this case and return a more sensible error message. I can submit a diff for that if that'd be acceptable

Feb 7 2017, 6:53 PM · Arcanist

Feb 2 2017

jcox committed rP1b8b64aae662: Stop calling the undefined `withIsTag` method (authored by jcox).
Stop calling the undefined `withIsTag` method
Feb 2 2017, 4:35 PM
jcox closed D17299: Stop calling the undefined `withIsTag` method by committing rP1b8b64aae662: Stop calling the undefined `withIsTag` method.
Feb 2 2017, 4:34 PM
jcox created D17299: Stop calling the undefined `withIsTag` method.
Feb 2 2017, 4:31 PM

Jan 23 2017

jcox accepted rPef05bf335d8e: Allow Harbormaster builds to publish to a different object.

@yelirekim I think we're good here. Just needed to implement getHarbormasterPublishablePHID() for SubmitQueueIntegrationPlans, ReleaseCandidates, and ScheduledBuilds. See our downstream diff for those changes.

Jan 23 2017, 6:40 PM

Jan 20 2017

jcox added inline comments to rP2dfe79cfc713: When updating revisions in response to commits, reuse previously generated diffs.
Jan 20 2017, 8:06 PM

Jan 19 2017

jcox added a comment to D17233: Remove motivator panel.

Jan 19 2017, 11:59 PM

Jan 16 2017

jcox added a comment to T12084: `differential.updaterevision` conduit method no longer updates custom fields.

ah yep that seemed to work. I was still specifying releaseNotes for the field which I'm guessing is why it wasn't getting saved. Thanks again for all the help! If you're ever in Pittsburgh I think I owe you about 50 beers at this point.

Jan 16 2017, 5:12 PM · Bug Report
jcox added a comment to T12084: `differential.updaterevision` conduit method no longer updates custom fields.

I pulled in that change and I'm still seeing the same issue. Editing the field from /differential/revision/edit/... seems to work normally, but adding it via the differential.createrevision endpoint does not.

Jan 16 2017, 4:25 PM · Bug Report
jcox added a comment to T12084: `differential.updaterevision` conduit method no longer updates custom fields.

Checking in for guidance in case this is the wrong way to go. I have a custom field which extends DifferentialStoredCustomField and I'm trying to convert it in the same way as the above. Thus far my field isn't being saved when calling differential.createrevision. I've included the DifferentialCommitMessageCustomField and the DifferentialStoredCustomField below.

Jan 16 2017, 3:12 PM · Bug Report

Jan 11 2017

jcox closed T12084: `differential.updaterevision` conduit method no longer updates custom fields as Resolved.

Thanks that did it! Still working through an issue with one of our more *ahem* exotic applications, but I suspect that'll be a more involved refactor on our end.

Jan 11 2017, 4:26 PM · Bug Report

Jan 10 2017

jcox added a comment to T12084: `differential.updaterevision` conduit method no longer updates custom fields.

Doing that without defining getFieldTransactions() in my class yields this exception:

Transaction with key "1" has invalid type "devTestPHIDs". This type is not recognized. Valid types are: update, comment, title, summary, testPlan, reviewers.add, reviewers.remove, reviewers.set, repositoryPHID, tasks.add, tasks.remove, tasks.set, view, edit, projects.add, projects.remove, projects.set, subscribers.add, subscribers.remove, subscribers.set, phabricator:auditors.
Jan 10 2017, 7:39 PM · Bug Report
jcox added a comment to T12084: `differential.updaterevision` conduit method no longer updates custom fields.

Thanks for the help Evan. I've gone through and converted everything as you suggested. The conduit method then started telling me

Jan 10 2017, 6:31 PM · Bug Report

Jan 9 2017

jcox created T12084: `differential.updaterevision` conduit method no longer updates custom fields.
Jan 9 2017, 4:22 PM · Bug Report

Dec 9 2016

jcox abandoned D17018: Add a `title` field to the `maniphest.query` conduit method.

Choosing "Abandon Revision" because "Abandon Revision, Set it on Fire, and Pretend it Never Existed" isn't an option. I'll get a diff ready that adds that as an option.

Dec 9 2016, 9:06 PM
jcox added a comment to D17018: Add a `title` field to the `maniphest.query` conduit method.

Oh god. I step away for 5 minutes and I'm now on the phacility hit-list.

Dec 9 2016, 9:04 PM
jcox added a comment to D17018: Add a `title` field to the `maniphest.query` conduit method.

haha I had a feeling this probably fell into the category of things that are in the process of being done a better/holistic way

Dec 9 2016, 8:30 PM
jcox retitled D17018: Add a `title` field to the `maniphest.query` conduit method from to Add a `title` field to the `maniphest.query` conduit method.
Dec 9 2016, 8:17 PM

Dec 6 2016

jcox raised the priority of T11955: Tag autocomplete doesn't always include milestones from Normal to Needs Triage.
Dec 6 2016, 12:28 PM · Projects
jcox updated the task description for T11955: Tag autocomplete doesn't always include milestones.
Dec 6 2016, 12:25 PM · Projects
jcox created T11955: Tag autocomplete doesn't always include milestones.
Dec 6 2016, 12:23 PM · Projects

Dec 5 2016

jcox updated subscribers of T11951: Make conduit more secure.
Dec 5 2016, 6:02 PM · Feature Request
jcox created T11951: Make conduit more secure.
Dec 5 2016, 6:02 PM · Feature Request

Nov 22 2016

jcox awarded E1216: Errands a Dislike token.
Nov 22 2016, 10:00 PM
jcox committed rPac66522c2e27: Add a flag to ./bin/worker to select tasks based on their failureCount (authored by jcox).
Add a flag to ./bin/worker to select tasks based on their failureCount
Nov 22 2016, 2:11 AM
jcox closed D16906: Add a flag to ./bin/worker to select tasks based on their failureCount by committing rPac66522c2e27: Add a flag to ./bin/worker to select tasks based on their failureCount.
Nov 22 2016, 2:11 AM
jcox updated the diff for D16906: Add a flag to ./bin/worker to select tasks based on their failureCount.

Use <= rather than <

Nov 22 2016, 2:09 AM
jcox requested review of D16906: Add a flag to ./bin/worker to select tasks based on their failureCount.

@epriestley do these changes look alright? I pulled most of PhabricatorWorkerArchiveTaskQuery up into the abstract PhabricatorWorkerTaskQuery and then added PhabricatorWorkerActiveTaskQuery. That made it more straightforward to just AND all the constraints together.

Nov 22 2016, 2:03 AM
jcox updated the diff for D16906: Add a flag to ./bin/worker to select tasks based on their failureCount.

Backed PhabricatorWorkerActiveTasks with an actual query object and refactored to share
some logic between Active and Archived tasks. Also removed some overeager indentations.

Nov 22 2016, 12:23 AM

Nov 21 2016

jcox added a comment to T11902: Periods in repository shortnames make the repo unreachable.

Confirmed this on my local. It seems to be due to D16851, specifically this line: https://secure.phabricator.com/source/phabricator/browse/master/src/applications/diffusion/application/PhabricatorDiffusionApplication.php$104.

Nov 21 2016, 8:02 PM · Bug Report
jcox retitled D16906: Add a flag to ./bin/worker to select tasks based on their failureCount from to Add a flag to ./bin/worker to select tasks based on their failureCount.
Nov 21 2016, 7:04 PM

Nov 10 2016

jcox added a comment to T11845: Media with "autoplay" should possibly not autoplay in news feed.

Pretty sure this works as intended

Nov 10 2016, 8:08 PM · Prioritized, Remarkup
jcox awarded T11845: Media with "autoplay" should possibly not autoplay in news feed a Y So Serious token.
Nov 10 2016, 7:52 PM · Prioritized, Remarkup
jcox awarded T11845: Media with "autoplay" should possibly not autoplay in news feed a Party Time token.
Nov 10 2016, 7:52 PM · Prioritized, Remarkup
jcox added a comment to T11843: Hitting "show older changes" throws an exception on DifferentialTransactionView::setLeftDiff() with Quicksand enabled.

{auto-playing-audio WilhelmScream.mp3}

Nov 10 2016, 7:43 PM · Quicksand, Bug Report
jcox added a comment to T11843: Hitting "show older changes" throws an exception on DifferentialTransactionView::setLeftDiff() with Quicksand enabled.

Yes I did have the persistent chat pane open. Also can't seem to repro without it.

Nov 10 2016, 7:41 PM · Quicksand, Bug Report
jcox added a comment to T11843: Hitting "show older changes" throws an exception on DifferentialTransactionView::setLeftDiff() with Quicksand enabled.

The other errors that appear in DarkConsole:

Nov 10 2016, 3:32 PM · Quicksand, Bug Report