When parsing HTML in remarkup, always start a new tag when encountering "<"
ClosedPublic
Actions

Authored by epriestley on Tue, Jul 2, 12:11 AM.

Details

Reviewers

Commits

rPHUbda42d11c2c7: (stable) When parsing HTML in remarkup, always start a new tag when…
rPHU5fc88a5c73f1: When parsing HTML in remarkup, always start a new tag when encountering "<"

Summary

Depends on D20630. See https://discourse.phabricator-community.org/t/bug-in-src-parser-html-phutildomnode-php/2882/. Currently, we parse <x>1<2</x> as an <x> tag containing a <2</x> tag.

A more expected interpretation of this is a single <x> tag containing the content 1<2.

When we encounter a <, always start a new tag, even if we're currently in a tag.

Test Plan

Added a test and made it pass.

Diff Detail

Repository

rPHU libphutil

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Tue, Jul 2, 12:11 AM

Harbormaster completed remote builds in B23081: Diff 49212.Tue, Jul 2, 12:11 AM

epriestley requested review of this revision.Tue, Jul 2, 12:11 AM

amckinley accepted this revision.Tue, Jul 2, 5:25 PM

This revision is now accepted and ready to land.Tue, Jul 2, 5:25 PM

Closed by commit rPHU5fc88a5c73f1: When parsing HTML in remarkup, always start a new tag when encountering "<" (authored by epriestley). · Explain WhyTue, Jul 2, 9:19 PM

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPHU5fc88a5c73f1: When parsing HTML in remarkup, always start a new tag when encountering "<".

epriestley added a commit: rPHUbda42d11c2c7: (stable) When parsing HTML in remarkup, always start a new tag when….Mon, Jul 8, 11:41 PM

Revision Contents
Changeset List

			Path	Packages
M			src/parser/html/PhutilHTMLParser.php (8 lines)
A	M		src/parser/html/__tests__/data/tag-angle.txt (13 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	49212	26b341e		Tue, Jul 2, 12:11 AM	★	★
Diff 2	49227	eff4eb2	rPHU5fc88a5c73f1b328cd3323d4e997f63197e10f14	Tue, Jul 2, 9:18 PM	★	★

When parsing HTML in remarkup, always start a new tag when encountering "<"
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 49227

src/parser/html/PhutilHTMLParser.php

src/parser/html/tests/data/tag-angle.txt

When parsing HTML in remarkup, always start a new tag when encountering "<"ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 49227

src/parser/html/PhutilHTMLParser.php

src/parser/html/__tests__/data/tag-angle.txt

When parsing HTML in remarkup, always start a new tag when encountering "<"
ClosedPublic
Actions

Revision Contents
Changeset List

src/parser/html/tests/data/tag-angle.txt