Page MenuHomePhabricator

When parsing HTML in remarkup, always start a new tag when encountering "<"
ClosedPublic

Authored by epriestley on Jul 2 2019, 12:11 AM.
Tags
None
Referenced Files
F19709474: D20631.diff
Wed, Feb 11, 2:50 PM
F19528316: D20631.diff
Jan 19 2026, 8:18 AM
F19526153: D20631.diff
Jan 18 2026, 2:24 PM
F19502700: D20631.id49212.diff
Jan 8 2026, 6:30 PM
F18870743: D20631.id.diff
Nov 4 2025, 6:44 PM
F18863141: D20631.diff
Nov 2 2025, 10:08 PM
F18761860: D20631.id.diff
Oct 6 2025, 4:33 PM
F18759623: D20631.id49212.diff
Oct 6 2025, 4:51 AM
Subscribers
None

Details

Summary

Depends on D20630. See https://discourse.phabricator-community.org/t/bug-in-src-parser-html-phutildomnode-php/2882/. Currently, we parse <x>1<2</x> as an <x> tag containing a <2</x> tag.

A more expected interpretation of this is a single <x> tag containing the content 1<2.

When we encounter a <, always start a new tag, even if we're currently in a tag.

Test Plan

Added a test and made it pass.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable