Page MenuHomePhabricator

When parsing HTML in remarkup, always start a new tag when encountering "<"
ClosedPublic

Authored by epriestley on Jul 2 2019, 12:11 AM.
Tags
None
Referenced Files
F13994367: D20631.id.diff
Wed, Oct 23, 5:39 AM
F13970023: D20631.id49212.diff
Thu, Oct 17, 5:17 AM
Unknown Object (File)
Sep 6 2024, 6:32 AM
Unknown Object (File)
Sep 4 2024, 4:19 PM
Unknown Object (File)
Sep 2 2024, 2:49 AM
Unknown Object (File)
Aug 27 2024, 6:24 AM
Unknown Object (File)
Aug 25 2024, 1:50 AM
Unknown Object (File)
Aug 19 2024, 8:45 AM
Subscribers
None

Details

Summary

Depends on D20630. See https://discourse.phabricator-community.org/t/bug-in-src-parser-html-phutildomnode-php/2882/. Currently, we parse <x>1<2</x> as an <x> tag containing a <2</x> tag.

A more expected interpretation of this is a single <x> tag containing the content 1<2.

When we encounter a <, always start a new tag, even if we're currently in a tag.

Test Plan

Added a test and made it pass.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable