Page MenuHomePhabricator

When parsing HTML in remarkup, always start a new tag when encountering "<"
ClosedPublic

Authored by epriestley on Jul 2 2019, 12:11 AM.
Tags
None
Referenced Files
F15511934: D20631.id.diff
Thu, Apr 17, 6:37 AM
F15487906: D20631.id49212.diff
Thu, Apr 10, 5:57 PM
F15487578: D20631.id49227.diff
Thu, Apr 10, 3:13 PM
F15484661: D20631.id49212.diff
Wed, Apr 9, 7:26 PM
F15465359: D20631.id.diff
Wed, Apr 2, 5:47 PM
F15465171: D20631.id49227.diff
Wed, Apr 2, 3:27 PM
F15464283: D20631.id49212.diff
Wed, Apr 2, 8:10 AM
F15461245: D20631.diff
Tue, Apr 1, 6:37 AM
Subscribers
None

Details

Summary

Depends on D20630. See https://discourse.phabricator-community.org/t/bug-in-src-parser-html-phutildomnode-php/2882/. Currently, we parse <x>1<2</x> as an <x> tag containing a <2</x> tag.

A more expected interpretation of this is a single <x> tag containing the content 1<2.

When we encounter a <, always start a new tag, even if we're currently in a tag.

Test Plan

Added a test and made it pass.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable