Page MenuHomePhabricator
Differential D20631

When parsing HTML in remarkup, always start a new tag when encountering "<"
ClosedPublic
Actions

Authored by epriestley on Jul 2 2019, 12:11 AM.
Tags
None
Referenced Files
F14907582: D20631.id49227.diff
Mon, Feb 10, 5:05 AM
F14907581: D20631.id49212.diff
Mon, Feb 10, 5:05 AM
F14907580: D20631.id.diff
Mon, Feb 10, 5:04 AM
Unknown Object (File)
Sun, Feb 2, 4:16 AM
Unknown Object (File)
Fri, Jan 31, 3:16 AM
Unknown Object (File)
Sat, Jan 25, 4:32 AM
Unknown Object (File)
Wed, Jan 22, 4:53 AM
Unknown Object (File)
Mon, Jan 13, 5:17 PM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Commits
rPHUbda42d11c2c7: (stable) When parsing HTML in remarkup, always start a new tag when…
rPHU5fc88a5c73f1: When parsing HTML in remarkup, always start a new tag when encountering "<"
Summary

Depends on D20630. See https://discourse.phabricator-community.org/t/bug-in-src-parser-html-phutildomnode-php/2882/. Currently, we parse <x>1<2</x> as an <x> tag containing a <2</x> tag.

A more expected interpretation of this is a single <x> tag containing the content 1<2.

When we encounter a <, always start a new tag, even if we're currently in a tag.

Test Plan

Added a test and made it pass.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
parser/
html/
8 lines
__tests__/
data/
13 lines

Diff 49227

View Options

src/parser/html/PhutilHTMLParser.php

Loading...
View Options

src/parser/html/__tests__/data/tag-angle.txt

Loading...
Phabricator · Built by Phacility