Page MenuHomePhabricator

Improve coverage of remarkup "<table>" rule and fix some bad method calls
ClosedPublic

Authored by epriestley on Jul 8 2019, 11:55 PM.

Details

Summary

See PHI1334. The existing coverage for "<table>" in remarkup is all testing valid inputs, and we have some incorrect method call names when the input isn't valid.

Add coverage, then make it pass.

Test Plan

Added tests and made them pass. Rendered some questionable <table>-like tags in comment previews.

Diff Detail

Repository
rPHU libphutil
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Jul 8 2019, 11:55 PM
epriestley requested review of this revision.Jul 8 2019, 11:55 PM

I'm going to fast-track this to production since the fatal in PHI1334 is particularly unlucky (repository landing page) and I'm pretty confident the change doesn't make anything worse.