Page MenuHomePhabricator

Improve coverage of remarkup "<table>" rule and fix some bad method calls
ClosedPublic

Authored by epriestley on Jul 8 2019, 11:55 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 14, 5:27 PM
Unknown Object (File)
Fri, Mar 1, 3:36 AM
Unknown Object (File)
Fri, Mar 1, 3:35 AM
Unknown Object (File)
Fri, Mar 1, 3:35 AM
Unknown Object (File)
Fri, Mar 1, 3:04 AM
Unknown Object (File)
Feb 13 2024, 2:14 PM
Unknown Object (File)
Feb 8 2024, 8:03 PM
Unknown Object (File)
Feb 3 2024, 10:51 PM
Subscribers
None
Tokens
"Baby Tequila" token, awarded by amckinley.

Details

Summary

See PHI1334. The existing coverage for "<table>" in remarkup is all testing valid inputs, and we have some incorrect method call names when the input isn't valid.

Add coverage, then make it pass.

Test Plan

Added tests and made them pass. Rendered some questionable <table>-like tags in comment previews.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

I'm going to fast-track this to production since the fatal in PHI1334 is particularly unlucky (repository landing page) and I'm pretty confident the change doesn't make anything worse.