Page MenuHomePhabricator

Improve coverage of remarkup "<table>" rule and fix some bad method calls
ClosedPublic

Authored by epriestley on Jul 8 2019, 11:55 PM.
Tags
None
Referenced Files
F17676787: D20644.id49249.diff
Sun, Jul 13, 10:17 AM
Unknown Object (File)
Jun 19 2025, 9:09 AM
Unknown Object (File)
Jun 18 2025, 11:49 AM
Unknown Object (File)
Jun 11 2025, 11:08 AM
Unknown Object (File)
Jun 11 2025, 11:08 AM
Unknown Object (File)
Jun 3 2025, 12:57 PM
Unknown Object (File)
Jun 1 2025, 8:59 PM
Unknown Object (File)
Jun 1 2025, 8:59 PM
Subscribers
None
Tokens
"Baby Tequila" token, awarded by amckinley.

Details

Summary

See PHI1334. The existing coverage for "<table>" in remarkup is all testing valid inputs, and we have some incorrect method call names when the input isn't valid.

Add coverage, then make it pass.

Test Plan

Added tests and made them pass. Rendered some questionable <table>-like tags in comment previews.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

I'm going to fast-track this to production since the fatal in PHI1334 is particularly unlucky (repository landing page) and I'm pretty confident the change doesn't make anything worse.