Page MenuHomePhabricator
Projects Security

SecurityTag
ActivePublic
Watch Project

Members (5)

Watchers (9)

Details

Description

Tasks related to enhancing the security of Phabricator.

Recent Activity
View All

Thu, Apr 8

epriestley added a comment to T13589: Git may interpret refnames as flags in some commands which accept both refs and paths.

Yes. I closed down registration on this install (secure.phabricator.com) several years ago because the overwhelming majority of users who registered accounts here didn't read or follow the rules. Access to secure.phabricator.com is now invite-only.

Thu, Apr 8, 12:53 PM · Security, Git
holmboe added a comment to T13589: Git may interpret refnames as flags in some commands which accept both refs and paths.
In T13589#254320, @epriestley wrote:

Please use Discourse to report bugs.

Thu, Apr 8, 9:47 AM · Security, Git

Jan 28 2021

epriestley added a revision to T13589: Git may interpret refnames as flags in some commands which accept both refs and paths: D21528: Correct Diffusion browse behavior when visiting a path URI with no trailing slash.
Jan 28 2021, 12:34 AM · Security, Git

Jan 25 2021

epriestley added a revision to T13589: Git may interpret refnames as flags in some commands which accept both refs and paths: D21519: Correct Git repository browse behavior for differences in "ls-tree" output.
Jan 25 2021, 5:10 PM · Security, Git

Jan 20 2021

epriestley added a revision to T13589: Git may interpret refnames as flags in some commands which accept both refs and paths: D21512: Correct a straggling CLI format string after ref selector changes.
Jan 20 2021, 11:04 PM · Security, Git
epriestley added a revision to T13589: Git may interpret refnames as flags in some commands which accept both refs and paths: D21511: Further correct and disambigutate ref selectors passed to Git on the CLI.
Jan 20 2021, 7:44 PM · Security, Git
epriestley updated the task description for T13589: Git may interpret refnames as flags in some commands which accept both refs and paths.
Jan 20 2021, 6:47 PM · Security, Git

Jan 19 2021

epriestley added a comment to T13589: Git may interpret refnames as flags in some commands which accept both refs and paths.

Please use Discourse to report bugs. See https://discourse.phabricator-community.org/t/repository-view-git-command-failed-error/4510/.

Jan 19 2021, 3:34 PM · Security, Git
Abbe added a comment to T13589: Git may interpret refnames as flags in some commands which accept both refs and paths.

It works with Git 2.1.4 (shipped with Debian Wheezy), but not with Git 2.20.1 (shipped with Debian Buster), or Git 2.30.0 (latest version).

Jan 19 2021, 12:00 PM · Security, Git
Abbe added a comment to T13589: Git may interpret refnames as flags in some commands which accept both refs and paths.

My apologies if this is not the right place to post about this, but seems like due to ea9cb0b625fb6922c45aecbfdebacc60788ed92d we now get following error message when visiting diffusion repository page, i.e. URL /diffusion/$REPOID/:

Jan 19 2021, 11:44 AM · Security, Git

Jan 15 2021

epriestley changed the visibility for T13589: Git may interpret refnames as flags in some commands which accept both refs and paths.
Jan 15 2021, 6:45 PM · Security, Git
epriestley changed the visibility for T13589: Git may interpret refnames as flags in some commands which accept both refs and paths.
Jan 15 2021, 6:44 PM · Security, Git

Jan 12 2021

epriestley added a revision to T13589: Git may interpret refnames as flags in some commands which accept both refs and paths: D21510: Disambiguate Git ref selectors in some Git command line invocations.
Jan 12 2021, 8:11 PM · Security, Git
epriestley updated the task description for T13589: Git may interpret refnames as flags in some commands which accept both refs and paths.
Jan 12 2021, 8:10 PM · Security, Git
epriestley added a revision to T13589: Git may interpret refnames as flags in some commands which accept both refs and paths: D21509: Provide "gitsprintf(...)" and disambiguate Git ref selectors.
Jan 12 2021, 8:09 PM · Security, Git
epriestley triaged T13589: Git may interpret refnames as flags in some commands which accept both refs and paths as Normal priority.
Jan 12 2021, 6:26 PM · Security, Git

Aug 5 2020

epriestley updated the task description for T13241: Guide: SMS is Insecure.
Aug 5 2020, 7:22 PM · Security, Guides

Apr 30 2020

adrelanos added a watcher for Security: adrelanos.
Apr 30 2020, 7:59 PM

Jul 31 2019

epriestley closed T13350: Ancient "slowvote.info" API method bypasses policy checks as Resolved by committing rP2ec39afcd12b: Deprecate ancient "slowvote.info" API method.
Jul 31 2019, 6:28 PM · Slowvote, Security
epriestley added a revision to T13350: Ancient "slowvote.info" API method bypasses policy checks: D20687: Deprecate ancient "slowvote.info" API method.
Jul 31 2019, 6:26 PM · Slowvote, Security
epriestley added a revision to T13350: Ancient "slowvote.info" API method bypasses policy checks: D20686: Fix two minor display issues with the Conduit "*.search" API documentation.
Jul 31 2019, 6:22 PM · Slowvote, Security
epriestley added a revision to T13350: Ancient "slowvote.info" API method bypasses policy checks: D20685: Add a "slowvote.poll.search" API method.
Jul 31 2019, 6:17 PM · Slowvote, Security

Jul 30 2019

epriestley added a revision to T13350: Ancient "slowvote.info" API method bypasses policy checks: D20684: Fix policy behavior of "slowvote.info" API method.
Jul 30 2019, 6:53 PM · Slowvote, Security
epriestley triaged T13350: Ancient "slowvote.info" API method bypasses policy checks as Low priority.
Jul 30 2019, 6:46 PM · Slowvote, Security

Jul 15 2019

amckinley closed T7667: Provide `auth lock` and `auth unlock` to restrict authentication provider management to the CLI, a subtask of T6755: Allow more granular configuration of `security.allow-outbound-http`, as Resolved.
Jul 15 2019, 6:53 PM · Security
amckinley closed T7667: Provide `auth lock` and `auth unlock` to restrict authentication provider management to the CLI as Resolved by committing rP7852adb84bbe: Actually enforce auth.lock-config.
Jul 15 2019, 6:53 PM · Auth, Security

Jul 10 2019

amckinley added a revision to T7667: Provide `auth lock` and `auth unlock` to restrict authentication provider management to the CLI: D20645: Actually enforce auth.lock-config.
Jul 10 2019, 3:05 PM · Auth, Security

Apr 18 2019

epriestley added a revision to T7667: Provide `auth lock` and `auth unlock` to restrict authentication provider management to the CLI: Restricted Differential Revision.
Apr 18 2019, 2:05 PM · Auth, Security
epriestley added a comment to T7667: Provide `auth lock` and `auth unlock` to restrict authentication provider management to the CLI.

This could be made slightly cleaner with a setSummary() to set a shorter summary:

Apr 18 2019, 2:02 PM · Auth, Security
epriestley added a revision to T7667: Provide `auth lock` and `auth unlock` to restrict authentication provider management to the CLI: D20447: Don't warn about a locked database value after users run "bin/auth lock".
Apr 18 2019, 12:24 AM · Auth, Security
epriestley added a comment to T7667: Provide `auth lock` and `auth unlock` to restrict authentication provider management to the CLI.

hmmmmmm

Apr 18 2019, 12:21 AM · Auth, Security

Apr 11 2019

amckinley added a revision to T7667: Provide `auth lock` and `auth unlock` to restrict authentication provider management to the CLI: D20400: Some formatting changes for showing auth provider config guidance.
Apr 11 2019, 8:16 PM · Auth, Security

Apr 10 2019

amckinley added a revision to T7667: Provide `auth lock` and `auth unlock` to restrict authentication provider management to the CLI: D20394: Add a workflow and a new config option for locking authentication providers.
Apr 10 2019, 10:35 PM · Auth, Security

Feb 2 2019

epriestley renamed T13245: Improve MFA security by using replacing SMS code digits with emoji from Improve MFA security by using replacing digits with emoji to Improve MFA security by using replacing SMS code digits with emoji.
Feb 2 2019, 6:46 PM · Security
epriestley triaged T13245: Improve MFA security by using replacing SMS code digits with emoji as Low priority.
Feb 2 2019, 6:46 PM · Security

Jan 29 2019

epriestley added a comment to T6994: Write a general "Security guidelines" document.

Some guidance about "configure captchas if you're a public-facing, password-login install" would be good here too

Jan 29 2019, 7:21 PM · Security

Jan 25 2019

epriestley added a revision to T7667: Provide `auth lock` and `auth unlock` to restrict authentication provider management to the CLI: D20038: Require MFA to edit MFA providers.
Jan 25 2019, 6:45 PM · Auth, Security
epriestley added a comment to T7667: Provide `auth lock` and `auth unlock` to restrict authentication provider management to the CLI.

After T13222, this is more relevant:

Jan 25 2019, 6:31 PM · Auth, Security
epriestley added a comment to T13138: Improve consistency of MFA requirements to invite/approve users.

From T13222, MFA on related flows should generally be updated.

Jan 25 2019, 6:28 PM · People, Security
epriestley updated the task description for T13241: Guide: SMS is Insecure.
Jan 25 2019, 3:57 PM · Security, Guides

Jan 21 2019

epriestley closed T13238: Disallow MYSQLI_OPT_LOCAL_INFILE as Resolved by committing rPHU1d3b33d4ccbf: Move "options(MYSQLI_OPT_LOCAL_INFILE, ...)" call after "real_connect()".
Jan 21 2019, 6:33 PM · Infrastructure, Security
epriestley added a revision to T13238: Disallow MYSQLI_OPT_LOCAL_INFILE: D20004: Move "options(MYSQLI_OPT_LOCAL_INFILE, ...)" call after "real_connect()".
Jan 21 2019, 3:38 PM · Infrastructure, Security
epriestley added a comment to T13238: Disallow MYSQLI_OPT_LOCAL_INFILE.

Thanks! I get the same behavior locally, I filed this upstream: https://bugs.php.net/bug.php?id=77496

Jan 21 2019, 3:34 PM · Infrastructure, Security
vrana added a comment to T13238: Disallow MYSQLI_OPT_LOCAL_INFILE.

I can't get MYSQLI_OPT_LOCAL_INFILE to work on secure, either. I tried on secure001 and secure004 (where the database is not local). As far as I can tell, this option doesn't do anything, anywhere, ever?

Jan 21 2019, 8:27 AM · Infrastructure, Security

Jan 20 2019

epriestley lowered the priority of T13238: Disallow MYSQLI_OPT_LOCAL_INFILE from Low to Wishlist.

We're probably done here, but ideally the next steps are:

Jan 20 2019, 3:14 PM · Infrastructure, Security

Jan 18 2019

epriestley added a revision to T13238: Disallow MYSQLI_OPT_LOCAL_INFILE: Restricted Differential Revision.
Jan 18 2019, 5:40 PM · Infrastructure, Security
epriestley added a revision to T13238: Disallow MYSQLI_OPT_LOCAL_INFILE: D19999: Add setup warnings for "local_infile" (MySQL Server) and "mysql[i].allow_local_infile" (PHP Client).
Jan 18 2019, 5:37 PM · Infrastructure, Security
epriestley added a comment to T13238: Disallow MYSQLI_OPT_LOCAL_INFILE.

Maybe another point in favor of this claim is that the option does not work is the behavior of this:

Jan 18 2019, 5:02 PM · Infrastructure, Security
epriestley added a comment to T13238: Disallow MYSQLI_OPT_LOCAL_INFILE.

I think that maybe mysql_nonapi.c just overrides the conn->options() call? Near line 269 of PHP 7.2.3:

Jan 18 2019, 4:57 PM · Infrastructure, Security
epriestley added a comment to T13238: Disallow MYSQLI_OPT_LOCAL_INFILE.

I can't get MYSQLI_OPT_LOCAL_INFILE to work on secure, either. I tried on secure001 and secure004 (where the database is not local). As far as I can tell, this option doesn't do anything, anywhere, ever? I'm going to look at the source and see if I can figure out what's going on, but I'll back it out of D19998 if I can't find some evidence that it's useful.

Jan 18 2019, 4:49 PM · Infrastructure, Security
Phabricator · Built by Phacility