Page MenuHomePhabricator

Remove obsolete "options" from workboard "updateCard()" call
ClosedPublic

Authored by epriestley on Jul 2 2019, 5:19 PM.

Details

Summary

Depends on D20637. Ref T4900. This is some ancient dead code that nothing uses.

Test Plan

Grepped for updateCard() to verify it's private. Searched for "options" and "dirtyColumn" and got no hits.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Jul 2 2019, 5:19 PM
epriestley requested review of this revision.Jul 2 2019, 5:21 PM
epriestley updated this revision to Diff 49224.Jul 2 2019, 5:33 PM
  • For better or worse, there actually is an external caller in WorkboardController that slipped past me.
amckinley accepted this revision.Jul 2 2019, 10:57 PM
This revision is now accepted and ready to land.Jul 2 2019, 10:57 PM