Differential D20638

Remove obsolete "options" from workboard "updateCard()" call
ClosedPublic
Actions

Authored by epriestley on Jul 2 2019, 5:19 PM.

Tags

None

Subscribers

None

Details

Reviewers

Maniphest Tasks

T4900: Workboards updating in real time

Commits

rPfc795994f30f: Remove obsolete "options" from workboard "updateCard()" call

Summary

Depends on D20637. Ref T4900. This is some ancient dead code that nothing uses.

Test Plan

Grepped for updateCard() to verify it's private. Searched for "options" and "dirtyColumn" and got no hits.

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Jul 2 2019, 5:19 PM

Harbormaster completed remote builds in B23092: Diff 49223.Jul 2 2019, 5:21 PM

epriestley requested review of this revision.Jul 2 2019, 5:21 PM

For better or worse, there actually is an external caller in WorkboardController that slipped past me.

Harbormaster completed remote builds in B23093: Diff 49224.Jul 2 2019, 5:35 PM

epriestley added a child revision: D20639: Make pressing "R" on your keyboard reload the card state on workboards.Jul 2 2019, 8:57 PM

amckinley accepted this revision.Jul 2 2019, 10:57 PM

This revision is now accepted and ready to land.Jul 2 2019, 10:57 PM

Closed by commit rPfc795994f30f: Remove obsolete "options" from workboard "updateCard()" call (authored by epriestley). · Explain WhyJul 3 2019, 5:06 PM

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPfc795994f30f: Remove obsolete "options" from workboard "updateCard()" call.

Revision Contents
Changeset List

			Path	Packages
M			resources/celerity/map.php (28 lines)
M			webroot/rsrc/js/application/projects/WorkboardBoard.js (5 lines)

Diff 49238

resources/celerity/map.php

Loading...

webroot/rsrc/js/application/projects/WorkboardBoard.js

Loading...