Differential D20635

Move workboard "Move Tasks to Column..." workflow to a separate controller
ClosedPublic
Actions

Authored by epriestley on Jul 2 2019, 2:43 PM.

Details

Reviewers

Maniphest Tasks

T4900: Workboards updating in real time
T13316: On Workboards, "Move Tasks to Column..." has high friction in the common use case (selecting a column on the same board)

Commits

rP24b466cd62d1: Move workboard "Move Tasks to Column..." workflow to a separate controller

Summary

Depends on D20634. Ref T4900. Ref T13316. I'm planning to do a bit of additional cleanup here in followups, but this separates the main workflow out of the common controller.

Test Plan

Used "Move Tasks to Column..." to move some tasks on a board.
Tried to move an empty column, hit an error.

Diff Detail

Repository

rP Phabricator

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Jul 2 2019, 2:43 PM

Harbormaster completed remote builds in B23089: Diff 49220.Jul 2 2019, 2:45 PM

epriestley requested review of this revision.Jul 2 2019, 2:45 PM

epriestley added a child revision: D20636: Differentiate between "Move Tasks to Column..." and "Move Tasks to Project..." in the workboard UI.Jul 2 2019, 3:32 PM

amckinley accepted this revision.Jul 2 2019, 9:57 PM

This revision is now accepted and ready to land.Jul 2 2019, 9:57 PM

Closed by commit rP24b466cd62d1: Move workboard "Move Tasks to Column..." workflow to a separate controller (authored by epriestley). · Explain WhyJul 2 2019, 10:16 PM

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP24b466cd62d1: Move workboard "Move Tasks to Column..." workflow to a separate controller.

Revision Contents
Changeset List

		Path
M		src/__phutil_library_map__.php (2 lines)
M		src/applications/project/application/PhabricatorProjectApplication.php (2 lines)
M		src/applications/project/controller/PhabricatorProjectBoardViewController.php (209 lines)
A	M	src/applications/project/controller/PhabricatorProjectColumnBulkMoveController.php (219 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	49220	8b6b964		Jul 2 2019, 2:43 PM	★	★
Diff 2	49234	ec352b1	rP24b466cd62d1bd1398e0200838e567bf5801718f	Jul 2 2019, 10:16 PM	★	★

Status	Author	Revision
Closed	epriestley	D20656 Make workboard real-time updates mostly work
Closed	epriestley	D20654 Make reloading workboards with "R" respect workboard ordering
Closed	epriestley	D20653 When updating a workboard with "R", send the client visible set with version numbers
Closed	epriestley	D20652 Move "BoardResponseEngine" toward a more comprehensive update model
Closed	epriestley	D20639 Make pressing "R" on your keyboard reload the card state on workboards
Closed	epriestley	D20638 Remove obsolete "options" from workboard "updateCard()" call
Closed	epriestley	D20637 Remove remnants of clumsy old URI state handling from workboards
Closed	epriestley	D20636 Differentiate between "Move Tasks to Column..." and "Move Tasks to Project..." in the workboard UI
Closed	epriestley	D20635 Move workboard "Move Tasks to Column..." workflow to a separate controller
Closed	epriestley	D20634 Move workboard "Bulk Edit Tasks" workflow to a separate controller
Closed	epriestley	D20633 Move workboard "View as Query" workflow to a separate controller
Closed	epriestley	D20632 Move workboard "filter" workflow to a separate controller
Closed	epriestley	D20629 Give the workboard "default" workflows more modern state handling
Closed	epriestley	D20628 Separate workboard view state (ordering, filtering, hidden columns) from the View controller
Closed	epriestley	D20627 Remove property "id" from Workboard View controller
Closed	epriestley	D20626 Remove unused property "slug" from Workboard View controller

Diff 49234

View Options

src/__phutil_library_map__.php

View Options

src/applications/project/application/PhabricatorProjectApplication.php

View Options

src/applications/project/controller/PhabricatorProjectBoardViewController.php

View Options

src/applications/project/controller/PhabricatorProjectColumnBulkMoveController.php

Move workboard "Move Tasks to Column..." workflow to a separate controllerClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 49234

src/__phutil_library_map__.php

src/applications/project/application/PhabricatorProjectApplication.php

src/applications/project/controller/PhabricatorProjectBoardViewController.php

src/applications/project/controller/PhabricatorProjectColumnBulkMoveController.php

Move workboard "Move Tasks to Column..." workflow to a separate controller
ClosedPublic
Actions

Revision Contents
Changeset List