Page MenuHomePhabricator

Remove remnants of clumsy old URI state handling from workboards
ClosedPublic

Authored by epriestley on Tue, Jul 2, 4:30 PM.

Details

Summary

Depends on D20636. Ref T4900. Previously, some workflows didn't know how to identify the default state for the board, so they needed explicit ("force") parameters.

Everything uses the same state management code now so we can rip out the old stuff.

Test Plan

Changed board filters, selected a custom filter, edited a custom filter.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Tue, Jul 2, 4:30 PM
epriestley requested review of this revision.Tue, Jul 2, 4:31 PM
epriestley added inline comments.
src/applications/project/controller/PhabricatorProjectBoardViewController.php
721–741

No actual changes here, just making the code look more similar throughout the controller.

amckinley accepted this revision.Tue, Jul 2, 10:56 PM
This revision is now accepted and ready to land.Tue, Jul 2, 10:56 PM