Change baseURI for Packages to avoid 404
ClosedPublic
Actions

Authored by amckinley on Nov 19 2020, 9:31 PM.

Details

Reviewers

Commits

rPb2ab18f8f3d0: Change baseURI for Packages to avoid 404

Summary

Without this change, the landing page for the Packages app is https://secure.phabricator.com/packages, which is a 404. There's probably a better way to fix this, but this was the fewest characters.

Test Plan

doitlive

Diff Detail

Repository

rP Phabricator

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

amckinley created this revision.Nov 19 2020, 9:31 PM

Harbormaster completed remote builds in B24971: Diff 51157.Nov 19 2020, 9:33 PM

amckinley requested review of this revision.Nov 19 2020, 9:33 PM

Herald added a subscriber: Korvin. · View Herald TranscriptNov 19 2020, 9:33 PM

Seems reasonable, definitely the highest impact-per-character change I can come up with.

src/applications/packages/application/PhabricatorPackagesApplication.php
18	I think this should have a trailing slash for consistency.

This revision is now accepted and ready to land.Nov 19 2020, 9:35 PM

Trailing slash

Harbormaster completed remote builds in B24973: Diff 51159.Nov 19 2020, 9:48 PM

Closed by commit rPb2ab18f8f3d0: Change baseURI for Packages to avoid 404 (authored by amckinley). · Explain WhyNov 19 2020, 9:48 PM

This revision was automatically updated to reflect the committed changes.

amckinley added a commit: rPb2ab18f8f3d0: Change baseURI for Packages to avoid 404.

Revision Contents
Changeset List

Path

Size

src/

applications/

packages/

application/

PhabricatorPackagesApplication.php

2 lines

Diff 51160

View Options

src/applications/packages/application/PhabricatorPackagesApplication.php

Change baseURI for Packages to avoid 404ClosedPublicActions