Paths

Table of Contentst

Differential D20648

Update one straggling "CAN_INTERACT" check in comment removal
ClosedPublic
Actions

Authored by epriestley on Jul 11 2019, 10:51 PM.

Tags

None

Referenced Files

	F15575003: D20648.diff
	Tue, May 6, 4:31 AM

	F15542643: D20648.id.diff
	Fri, Apr 25, 5:46 PM

	F15527296: D20648.id49258.diff
	Tue, Apr 22, 2:34 AM

	F15525193: D20648.id49260.diff
	Mon, Apr 21, 12:45 PM

	F15524651: D20648.diff
	Mon, Apr 21, 9:31 AM

	F15522771: D20648.id.diff
	Sun, Apr 20, 9:16 PM

	F15517940: D20648.diff
	Sat, Apr 19, 9:44 AM

	F15474028: D20648.id49260.diff
	Apr 6 2025, 4:25 AM

View All Files

Subscribers

None

Tokens

"Love" token, awarded by 20after4.

Details

Reviewers

amckinley
20after4

Commits

rP41ea204144ab: Update one straggling "CAN_INTERACT" check in comment removal

Summary

See rPaacc62463d61. D20551 added some CAN_INTERACT checks, but CAN_INTERACT needs to be checked with canInteract() to fall back to CAN_VIEW properly. D20558 cleaned up most of this but missed one callsite; fix that up too.

Test Plan

Removed a comment on a commit.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Jul 11 2019, 10:51 PM

epriestley mentioned this in rPaacc62463d61: Prevent editing and deleting comments in locked conversations.Jul 11 2019, 10:53 PM

Harbormaster completed remote builds in B23126: Diff 49258.Jul 11 2019, 10:53 PM

epriestley requested review of this revision.Jul 11 2019, 10:53 PM

amckinley accepted this revision.Jul 11 2019, 10:56 PM

This revision is now accepted and ready to land.Jul 11 2019, 10:56 PM

Closed by commit rP41ea204144ab: Update one straggling "CAN_INTERACT" check in comment removal (authored by epriestley). · Explain WhyJul 11 2019, 11:09 PM

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP41ea204144ab: Update one straggling "CAN_INTERACT" check in comment removal.

20after4 awarded a token.Aug 1 2019, 6:56 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

transactions/

controller/

PhabricatorApplicationTransactionCommentRemoveController.php

5 lines

Diff 49260

View Options

src/applications/transactions/controller/PhabricatorApplicationTransactionCommentRemoveController.php

Update one straggling "CAN_INTERACT" check in comment removalClosedPublicActions