Differential D20642

Fix paging fatal with flagged objects
ClosedPublic
Actions

Authored by amckinley on Jul 4 2019, 11:01 PM.

Details

Reviewers

epriestley

Maniphest Tasks

T13331: "Next" button on personal Flags page triggers error "Call to undefined method PhabricatorFlagQuery::withIDs()"

Commits

rP3c4322252513: Fix paging fatal with flagged objects

Summary

Fixes T13331. Just adds a generic withIDs() method to PhabricatorFlagQuery.

Test Plan

Flagged > 100 objects, observed fatal attempting to page. Next page loads as expected after fix.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

amckinley created this revision.Jul 4 2019, 11:01 PM

amckinley mentioned this in T13331: "Next" button on personal Flags page triggers error "Call to undefined method PhabricatorFlagQuery::withIDs()".Jul 4 2019, 11:02 PM

Harbormaster completed remote builds in B23112: Diff 49244.Jul 4 2019, 11:03 PM

amckinley requested review of this revision.Jul 4 2019, 11:03 PM

Herald added a subscriber: Korvin. · View Herald TranscriptJul 4 2019, 11:03 PM

epriestley accepted this revision.Jul 5 2019, 5:17 PM

This revision is now accepted and ready to land.Jul 5 2019, 5:17 PM

Closed by commit rP3c4322252513: Fix paging fatal with flagged objects (authored by amckinley). · Explain WhyJul 5 2019, 9:25 PM

This revision was automatically updated to reflect the committed changes.

amckinley added a commit: rP3c4322252513: Fix paging fatal with flagged objects.

Revision Contents
Changeset List

Path

Size

src/

applications/

flag/

query/

PhabricatorFlagQuery.php

13 lines

Diff 49245

View Options

src/applications/flag/query/PhabricatorFlagQuery.php

Fix paging fatal with flagged objectsClosedPublicActions