Page MenuHomePhabricator

Add ferret support to Slowvote
AcceptedPublic

Authored by amckinley on Wed, Jul 3, 11:16 PM.

Details

Reviewers
epriestley
Summary

Keep pushing on PHI1292. AFAICT, there are only four classes that support Spaces but lack fulltext support:

  • PhabricatorMetaMTAApplicationEmail
  • PhabricatorPaste
  • PhabricatorPhurlURL
  • PhabricatorSlowvotePoll

These all look easy, so just pound out the first one of these.

Test Plan
  • bin/storage upgrade
  • bin/seach index --type POLL
  • Looked at DB tables, ran some searches, confirmed search-with-Space worked.

Diff Detail

Repository
rP Phabricator
Branch
poll-ferret (branched from master)
Lint
Lint OK
Unit
Unit Tests OK
Build Status
Buildable 23110
Build 31730: Run Core Tests
Build 31729: arc lint + arc unit

Event Timeline

amckinley created this revision.Wed, Jul 3, 11:16 PM
Owners added a subscriber: Restricted Owners Package.Wed, Jul 3, 11:16 PM
amckinley requested review of this revision.Wed, Jul 3, 11:17 PM
epriestley accepted this revision.Wed, Jul 3, 11:20 PM

Ah, nice!

You can also follow 20190412.herald.01.rebuild.php to add a migration which queues a worker to queue other workers to rebuild the index now. It's probably reasonable to do for Slowvote since installs are unlikely to have millions upon millions of these. But we could also do it later.

This revision is now accepted and ready to land.Wed, Jul 3, 11:20 PM

But we could also do it later.

Yup, I was planning on adding one at the end these four revs.