Page MenuHomePhabricator

Record account recovery email links in the user activity log and make the mail message reference the log
ClosedPublic

Authored by epriestley on Jul 19 2019, 10:05 PM.
Tags
None
Referenced Files
F18064607: D20673.id49319.diff
Mon, Aug 4, 1:34 PM
F18049780: D20673.id.diff
Sun, Aug 3, 5:17 PM
F18038365: D20673.diff
Sun, Aug 3, 2:57 AM
F17799091: D20673.id49319.diff
Fri, Jul 25, 4:31 AM
F17772980: D20673.diff
Wed, Jul 23, 4:51 PM
Unknown Object (File)
Jun 29 2025, 8:57 AM
Unknown Object (File)
Jun 5 2025, 4:38 PM
Unknown Object (File)
Jun 3 2025, 8:40 PM
Subscribers
None

Details

Summary

Depends on D20672. Ref T13343. When a user requests an account access link via email:

  • log it in the activity log; and
  • reference the log in the mail.

This makes it easier to ban users misusing the feature, provided they're coming from a single remote address, and takes a few steps down the pathway toward a button in the mail that users can click to report the action, suspend account recovery for their account, etc.

Test Plan
  • Requested an email recovery link.
  • Saw request appear in the user activity log.
  • Saw a reference to the log entry in the mail footer.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable