Page MenuHomePhabricator

Record account recovery email links in the user activity log and make the mail message reference the log
ClosedPublic

Authored by epriestley on Jul 19 2019, 10:05 PM.
Tags
None
Referenced Files
F22656720: D20673.id.diff
Thu, Oct 1, 4:15 AM
F22545521: D20673.id.diff
Tue, Sep 22, 9:16 PM
F22514766: D20673.id49300.diff
Sat, Sep 19, 11:12 PM
Unknown Object (File)
Aug 15 2026, 2:15 AM
Unknown Object (File)
Jun 23 2026, 9:13 AM
Unknown Object (File)
Jun 23 2026, 9:12 AM
Unknown Object (File)
Jun 21 2026, 2:14 AM
Unknown Object (File)
Apr 17 2026, 1:51 PM
Subscribers
None

Details

Summary

Depends on D20672. Ref T13343. When a user requests an account access link via email:

  • log it in the activity log; and
  • reference the log in the mail.

This makes it easier to ban users misusing the feature, provided they're coming from a single remote address, and takes a few steps down the pathway toward a button in the mail that users can click to report the action, suspend account recovery for their account, etc.

Test Plan
  • Requested an email recovery link.
  • Saw request appear in the user activity log.
  • Saw a reference to the log entry in the mail footer.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable