Differential D20627

Remove property "id" from Workboard View controller
ClosedPublic
Actions

Authored by epriestley on Jun 29 2019, 9:20 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T4900: Workboards updating in real time

Commits

rP0ae9e2c75d1f: Remove property "id" from Workboard View controller

Summary

Depends on D20626. Ref T4900. On this controller, "id" is a separate property, but serves little purpose and complicates separating state management. Remove it.

Test Plan

Bulk edited a column, managed filters, did show/hide on columns, edited a column.

Diff Detail

Repository

rP Phabricator

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Jun 29 2019, 9:20 PM

Harbormaster completed remote builds in B23077: Diff 49208.Jun 29 2019, 9:22 PM

epriestley requested review of this revision.Jun 29 2019, 9:22 PM

amckinley accepted this revision.Jun 29 2019, 9:26 PM

This revision is now accepted and ready to land.Jun 29 2019, 9:26 PM

epriestley added a child revision: D20628: Separate workboard view state (ordering, filtering, hidden columns) from the View controller.Jun 29 2019, 10:11 PM

Closed by commit rP0ae9e2c75d1f: Remove property "id" from Workboard View controller (authored by epriestley). · Explain WhyJul 2 2019, 12:17 PM

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP0ae9e2c75d1f: Remove property "id" from Workboard View controller.

Revision Contents
Changeset List

			Path	Packages
M			src/applications/project/controller/PhabricatorProjectBoardViewController.php (10 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	49208	6f4190c		Jun 29 2019, 9:20 PM	★	★
Diff 2	49216	df29b82	rP0ae9e2c75d1f65ebcb20449051540fc8278e2ec9	Jul 2 2019, 12:17 PM	★	★

Status	Author	Revision
Closed	epriestley	D20656 Make workboard real-time updates mostly work
Closed	epriestley	D20654 Make reloading workboards with "R" respect workboard ordering
Closed	epriestley	D20653 When updating a workboard with "R", send the client visible set with version numbers
Closed	epriestley	D20652 Move "BoardResponseEngine" toward a more comprehensive update model
Closed	epriestley	D20639 Make pressing "R" on your keyboard reload the card state on workboards
Closed	epriestley	D20638 Remove obsolete "options" from workboard "updateCard()" call
Closed	epriestley	D20637 Remove remnants of clumsy old URI state handling from workboards
Closed	epriestley	D20636 Differentiate between "Move Tasks to Column..." and "Move Tasks to Project..." in the workboard UI
Closed	epriestley	D20635 Move workboard "Move Tasks to Column..." workflow to a separate controller
Closed	epriestley	D20634 Move workboard "Bulk Edit Tasks" workflow to a separate controller
Closed	epriestley	D20633 Move workboard "View as Query" workflow to a separate controller
Closed	epriestley	D20632 Move workboard "filter" workflow to a separate controller
Closed	epriestley	D20629 Give the workboard "default" workflows more modern state handling
Closed	epriestley	D20628 Separate workboard view state (ordering, filtering, hidden columns) from the View controller
Closed	epriestley	D20627 Remove property "id" from Workboard View controller
Closed	epriestley	D20626 Remove unused property "slug" from Workboard View controller

Diff 49216

View Options

src/applications/project/controller/PhabricatorProjectBoardViewController.php

Remove property "id" from Workboard View controllerClosedPublicActions