Page MenuHomePhabricator

Give "Auth Messages" a view/detail state before users customize them
ClosedPublic

Authored by epriestley on Jul 19 2019, 4:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 20, 4:04 AM
Unknown Object (File)
Sat, Dec 14, 6:37 AM
Unknown Object (File)
Thu, Dec 12, 11:50 PM
Unknown Object (File)
Wed, Dec 11, 10:13 AM
Unknown Object (File)
Mon, Dec 9, 6:18 AM
Unknown Object (File)
Fri, Dec 6, 12:05 AM
Unknown Object (File)
Oct 22 2024, 9:38 PM
Unknown Object (File)
Sep 30 2024, 10:35 PM
Subscribers
None

Details

Summary

Depends on D20663. Ref T13343. Currently, if an Auth message hasn't been customized yet, clicking the message type takes you straight to an edit screen to create a message.

If an auth message has already been customized, you go to a detail screen instead.

Since there's no detail screen on the "create for the first time" flow, we don't have anywhere to put a more detailed description or a preview of a default value.

Add a view screen that works if a message is "empty" so we can add this stuff.

(The only reason we don't already have this is that it took a little work to build; this also generally improves the consistency and predictability of this interface.)

Test Plan

Screen Shot 2019-07-19 at 9.01.17 AM.png (984×1 px, 188 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable