Page MenuHomePhabricator

Fix some remarkup issues with selective construction of child nodes after HTML DOM parsing
ClosedPublic

Authored by epriestley on Jul 2 2019, 12:04 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 21, 12:46 PM
Unknown Object (File)
Mon, Apr 14, 6:17 AM
Unknown Object (File)
Apr 1 2025, 1:11 PM
Unknown Object (File)
Mar 29 2025, 6:28 PM
Unknown Object (File)
Mar 28 2025, 10:16 AM
Unknown Object (File)
Mar 27 2025, 3:43 PM
Unknown Object (File)
Mar 18 2025, 5:26 PM
Unknown Object (File)
Mar 14 2025, 12:30 PM
Subscribers
None

Details

Summary

See https://discourse.phabricator-community.org/t/bug-in-src-parser-html-phutildomnode-php/2882/.

The behavior of selectChildrenWithTags(...) currently isn't well-covered by tests and isn't quite right. Add coverage and fix it up.

Particularly, there's a bad call to a nonexistent method, and when we convert a tag that doesn't match the selection set into content, we incorrectly discard any paired closing tag.

Test Plan

Added failing tests, made them pass.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable