Page MenuHomePhabricator

Modularize user activity log message types
ClosedPublic

Authored by epriestley on Jul 19 2019, 9:41 PM.
Tags
None
Referenced Files
F22717988: D20671.id49317.diff
Sat, Oct 3, 7:45 PM
F22579674: D20671.diff
Sun, Sep 27, 3:58 PM
F22550497: D20671.id49298.diff
Wed, Sep 23, 4:39 AM
F22537498: D20671.id49317.diff
Tue, Sep 22, 6:20 AM
F22530136: D20671.diff
Mon, Sep 21, 2:33 PM
Unknown Object (File)
Aug 29 2026, 3:21 AM
Unknown Object (File)
Jul 4 2026, 11:52 AM
Unknown Object (File)
Jul 4 2026, 11:52 AM
Subscribers
None

Details

Summary

Depends on D20670. Ref T13343. The user activity message log types are currently hard-coded, so only upstream code can really use the log construct.

Under the theory that we're going to keep this log around going forward (just focus it a little bit), modularize things so the log is extensible.

Test Plan

Grepped for UserLog::, viewed activity logs in People and Settings.

(If I missed something here -- say, misspelled a constant -- the effect should just be that older logs don't get a human-readable label, so stakes are very low.)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable