Page MenuHomePhabricator

Modularize user activity log message types
ClosedPublic

Authored by epriestley on Jul 19 2019, 9:41 PM.
Tags
None
Referenced Files
F18839753: D20671.id.diff
Mon, Oct 27, 6:42 PM
F18835197: D20671.diff
Sun, Oct 26, 2:08 PM
F18773715: D20671.id49298.diff
Thu, Oct 9, 12:07 PM
F18675672: D20671.id.diff
Sep 25 2025, 6:06 PM
F18622081: D20671.diff
Sep 15 2025, 10:24 AM
F18567165: D20671.id.diff
Sep 9 2025, 3:34 PM
F18431053: D20671.id49317.diff
Aug 31 2025, 4:45 AM
F18304999: D20671.diff
Aug 23 2025, 11:13 PM
Subscribers
None

Details

Summary

Depends on D20670. Ref T13343. The user activity message log types are currently hard-coded, so only upstream code can really use the log construct.

Under the theory that we're going to keep this log around going forward (just focus it a little bit), modularize things so the log is extensible.

Test Plan

Grepped for UserLog::, viewed activity logs in People and Settings.

(If I missed something here -- say, misspelled a constant -- the effect should just be that older logs don't get a human-readable label, so stakes are very low.)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable