Page MenuHomePhabricator

Modularize user activity log message types
ClosedPublic

Authored by epriestley on Jul 19 2019, 9:41 PM.

Details

Summary

Depends on D20670. Ref T13343. The user activity message log types are currently hard-coded, so only upstream code can really use the log construct.

Under the theory that we're going to keep this log around going forward (just focus it a little bit), modularize things so the log is extensible.

Test Plan

Grepped for UserLog::, viewed activity logs in People and Settings.

(If I missed something here -- say, misspelled a constant -- the effect should just be that older logs don't get a human-readable label, so stakes are very low.)

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Jul 19 2019, 9:41 PM
epriestley requested review of this revision.Jul 19 2019, 9:43 PM
amckinley accepted this revision.Wed, Jul 24, 2:17 AM
This revision is now accepted and ready to land.Wed, Jul 24, 2:17 AM
This revision was automatically updated to reflect the committed changes.