Page MenuHomePhabricator

Modularize user activity log message types
ClosedPublic

Authored by epriestley on Jul 19 2019, 9:41 PM.
Tags
None
Referenced Files
F14906842: D20671.id49317.diff
Mon, Feb 10, 12:34 AM
F14906841: D20671.id49298.diff
Mon, Feb 10, 12:34 AM
F14906840: D20671.id.diff
Mon, Feb 10, 12:34 AM
Unknown Object (File)
Sun, Feb 2, 8:45 PM
Unknown Object (File)
Sun, Feb 2, 3:07 AM
Unknown Object (File)
Wed, Jan 22, 1:52 PM
Unknown Object (File)
Tue, Jan 21, 9:36 AM
Unknown Object (File)
Jan 8 2025, 9:44 PM
Subscribers
None

Details

Summary

Depends on D20670. Ref T13343. The user activity message log types are currently hard-coded, so only upstream code can really use the log construct.

Under the theory that we're going to keep this log around going forward (just focus it a little bit), modularize things so the log is extensible.

Test Plan

Grepped for UserLog::, viewed activity logs in People and Settings.

(If I missed something here -- say, misspelled a constant -- the effect should just be that older logs don't get a human-readable label, so stakes are very low.)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable