Page MenuHomePhabricator

Modularize user activity log message types
ClosedPublic

Authored by epriestley on Jul 19 2019, 9:41 PM.
Tags
None
Referenced Files
F15529115: D20671.id49298.diff
Tue, Apr 22, 4:54 PM
F15528884: D20671.id49317.diff
Tue, Apr 22, 2:46 PM
F15523574: D20671.diff
Mon, Apr 21, 2:19 AM
F15509931: D20671.id.diff
Wed, Apr 16, 5:37 PM
F15506819: D20671.diff
Tue, Apr 15, 2:25 PM
F15462480: D20671.diff
Tue, Apr 1, 3:20 PM
F15445236: D20671.diff
Mar 27 2025, 1:03 PM
F15382220: D20671.diff
Mar 14 2025, 11:20 AM
Subscribers
None

Details

Summary

Depends on D20670. Ref T13343. The user activity message log types are currently hard-coded, so only upstream code can really use the log construct.

Under the theory that we're going to keep this log around going forward (just focus it a little bit), modularize things so the log is extensible.

Test Plan

Grepped for UserLog::, viewed activity logs in People and Settings.

(If I missed something here -- say, misspelled a constant -- the effect should just be that older logs don't get a human-readable label, so stakes are very low.)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable