Page MenuHomePhabricator

Modularize user activity log message types
ClosedPublic

Authored by epriestley on Jul 19 2019, 9:41 PM.
Tags
None
Referenced Files
F18304999: D20671.diff
Sat, Aug 23, 11:13 PM
F18100616: D20671.id.diff
Sat, Aug 9, 11:58 AM
F18038102: D20671.diff
Sun, Aug 3, 2:50 AM
F17941005: D20671.id49298.diff
Thu, Jul 31, 4:56 AM
F17940082: D20671.diff
Thu, Jul 31, 3:52 AM
Unknown Object (File)
Jun 20 2025, 11:40 AM
Unknown Object (File)
Jun 17 2025, 6:22 PM
Unknown Object (File)
Jun 16 2025, 2:17 PM
Subscribers
None

Details

Summary

Depends on D20670. Ref T13343. The user activity message log types are currently hard-coded, so only upstream code can really use the log construct.

Under the theory that we're going to keep this log around going forward (just focus it a little bit), modularize things so the log is extensible.

Test Plan

Grepped for UserLog::, viewed activity logs in People and Settings.

(If I missed something here -- say, misspelled a constant -- the effect should just be that older logs don't get a human-readable label, so stakes are very low.)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable