Page MenuHomePhabricator

Modularize user activity log message types
ClosedPublic

Authored by epriestley on Jul 19 2019, 9:41 PM.
Tags
None
Referenced Files
F15336916: D20671.id49298.diff
Sun, Mar 9, 3:29 AM
F15325949: D20671.id.diff
Fri, Mar 7, 3:06 AM
Unknown Object (File)
Fri, Feb 21, 11:43 PM
Unknown Object (File)
Fri, Feb 21, 4:07 AM
Unknown Object (File)
Tue, Feb 18, 3:04 PM
Unknown Object (File)
Tue, Feb 18, 7:39 AM
Unknown Object (File)
Feb 10 2025, 12:34 AM
Unknown Object (File)
Feb 10 2025, 12:34 AM
Subscribers
None

Details

Summary

Depends on D20670. Ref T13343. The user activity message log types are currently hard-coded, so only upstream code can really use the log construct.

Under the theory that we're going to keep this log around going forward (just focus it a little bit), modularize things so the log is extensible.

Test Plan

Grepped for UserLog::, viewed activity logs in People and Settings.

(If I missed something here -- say, misspelled a constant -- the effect should just be that older logs don't get a human-readable label, so stakes are very low.)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable