Page MenuHomePhabricator

Modularize user activity log message types
ClosedPublic

Authored by epriestley on Jul 19 2019, 9:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, May 28, 1:27 AM
Unknown Object (File)
Apr 22 2025, 4:54 PM
Unknown Object (File)
Apr 22 2025, 2:46 PM
Unknown Object (File)
Apr 21 2025, 2:19 AM
Unknown Object (File)
Apr 16 2025, 5:37 PM
Unknown Object (File)
Apr 15 2025, 2:25 PM
Unknown Object (File)
Apr 1 2025, 3:20 PM
Unknown Object (File)
Mar 27 2025, 1:03 PM
Subscribers
None

Details

Summary

Depends on D20670. Ref T13343. The user activity message log types are currently hard-coded, so only upstream code can really use the log construct.

Under the theory that we're going to keep this log around going forward (just focus it a little bit), modularize things so the log is extensible.

Test Plan

Grepped for UserLog::, viewed activity logs in People and Settings.

(If I missed something here -- say, misspelled a constant -- the effect should just be that older logs don't get a human-readable label, so stakes are very low.)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable