Page MenuHomePhabricator

Fix double-close on dialogs leading to Javascript console error
ClosedPublic

Authored by epriestley on Jul 3 2019, 3:19 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 13, 12:37 AM
Unknown Object (File)
Sat, Nov 30, 9:16 PM
Unknown Object (File)
Thu, Nov 28, 3:39 PM
Unknown Object (File)
Wed, Nov 27, 1:11 AM
Unknown Object (File)
Tue, Nov 26, 4:49 PM
Unknown Object (File)
Mon, Nov 25, 5:18 PM
Unknown Object (File)
Sun, Nov 24, 8:15 PM
Unknown Object (File)
Sat, Nov 23, 4:46 AM
Subscribers
None

Details

Summary

Ref T13302. The "Close/Cancel" button is currently running two copies of the "dismiss dialog" code, since it's techncally a link with a valid HREF attribute.

An alternate formulation of this is perhaps if (JX.Stratcom.pass()) { return; } ("let other handlers react to this event; if something kills it, stop processing"), but pass() is inherently someone spooky/fragile so try to get away without it.

Test Plan

Opened the Javascript console, clicked "Edit Task" on a workboard, clicked "Close" on the dialog. Before: event was double-handled leading to a JS error in the console. After: dialog closes uneventfully.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable