Page MenuHomePhabricator

Fix double-close on dialogs leading to Javascript console error

Authored by epriestley on Jul 3 2019, 3:19 PM.



Ref T13302. The "Close/Cancel" button is currently running two copies of the "dismiss dialog" code, since it's techncally a link with a valid HREF attribute.

An alternate formulation of this is perhaps if (JX.Stratcom.pass()) { return; } ("let other handlers react to this event; if something kills it, stop processing"), but pass() is inherently someone spooky/fragile so try to get away without it.

Test Plan

Opened the Javascript console, clicked "Edit Task" on a workboard, clicked "Close" on the dialog. Before: event was double-handled leading to a JS error in the console. After: dialog closes uneventfully.

Diff Detail

rP Phabricator
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Jul 3 2019, 3:19 PM
epriestley requested review of this revision.Jul 3 2019, 3:20 PM
amckinley accepted this revision.Jul 3 2019, 6:57 PM
This revision is now accepted and ready to land.Jul 3 2019, 6:57 PM