Page MenuHomePhabricator

Fix transaction title rendering for AuthenticationConfigs
ClosedPublic

Authored by amckinley on Jul 17 2019, 7:32 PM.

Details

Summary

I was poking around in PhabricatorAuthProviderViewController and noticed that none of the subclass-specific rendering was working. Figured out that no one ever calls PhabricatorAuthProviderConfigTransaction->setProvider(), so instead of adding all those calls, just pull the provider out of the config object.

Test Plan

Before:


After:

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

amckinley created this revision.Jul 17 2019, 7:32 PM
amckinley requested review of this revision.Jul 17 2019, 7:34 PM
epriestley accepted this revision.Jul 17 2019, 7:39 PM

This seems very likely to always work properly when we expect it to.

It's possible for a transaction to not have an object but it looks like getObject() throws in this case rather than returning null so we should get a helpful exception even if something bizarre is afoot on some pathway here.

This revision is now accepted and ready to land.Jul 17 2019, 7:39 PM