Differential D20674

Provide a basic detail view for user activity logs
ClosedPublic
Actions

Authored by epriestley on Jul 19 2019, 10:30 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13343: Make "Send a login link to your email address" email include why it was sent to avoid confusion

Commits

rP99c864f5e6fb: Provide a basic detail view for user activity logs

Summary

Depends on D20673. Ref T13343. Since we're now putting log IDs in email, make the UI a little better for working with log IDs.

Some day, this page might have actions like "report this as suspicious" or whatever, but I'm not planning to do any of that for now.

Test Plan

Diff Detail

Repository

rP Phabricator

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Jul 19 2019, 10:30 PM

Harbormaster completed remote builds in B23168: Diff 49301.Jul 19 2019, 10:32 PM

epriestley requested review of this revision.Jul 19 2019, 10:32 PM

amckinley accepted this revision.Jul 24 2019, 2:18 AM

This revision is now accepted and ready to land.Jul 24 2019, 2:18 AM

Closed by commit rP99c864f5e6fb: Provide a basic detail view for user activity logs (authored by epriestley). · Explain WhyJul 24 2019, 2:14 PM

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP99c864f5e6fb: Provide a basic detail view for user activity logs.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

applications/

people/

application/

PhabricatorPeopleApplication.php

1 line

controller/

PhabricatorPeopleLogViewController.php

92 lines

query/

PhabricatorPeopleLogQuery.php

13 lines

storage/

PhabricatorUserLog.php

37 lines

view/

PhabricatorUserLogView.php

51 lines

Diff 49320

View Options

src/__phutil_library_map__.php

View Options

src/applications/people/application/PhabricatorPeopleApplication.php

View Options

src/applications/people/controller/PhabricatorPeopleLogViewController.php

View Options

src/applications/people/query/PhabricatorPeopleLogQuery.php

View Options

src/applications/people/storage/PhabricatorUserLog.php

View Options

src/applications/people/view/PhabricatorUserLogView.php

Provide a basic detail view for user activity logsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 49320

src/__phutil_library_map__.php

src/applications/people/application/PhabricatorPeopleApplication.php

src/applications/people/controller/PhabricatorPeopleLogViewController.php

src/applications/people/query/PhabricatorPeopleLogQuery.php

src/applications/people/storage/PhabricatorUserLog.php

src/applications/people/view/PhabricatorUserLogView.php

Provide a basic detail view for user activity logs
ClosedPublic
Actions

Revision Contents
Changeset List