Page MenuHomePhabricator

Move workboard "Bulk Edit Tasks" workflow to a separate controller
ClosedPublic

Authored by epriestley on Jul 2 2019, 1:16 PM.

Details

Summary

Depends on D20633. Ref T4900. Separate the "Bulk Edit Tasks..." flow out of the main workboard controller.

Test Plan
  • Used "Bulk Edit Tasks" on a column with some tasks, got an appropraite edit operation.
  • Used "Bulk Edit Tasks" on an empty column, got an error.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Jul 2 2019, 1:16 PM
epriestley added inline comments.Jul 2 2019, 1:17 PM
src/applications/project/controller/PhabricatorProjectBoardViewController.php
6

This removes some "edit all" stuff, I'll discuss that separately.

epriestley requested review of this revision.Jul 2 2019, 1:18 PM

In D12475, the "bulk edit" (then, "batch edit") stuff was added originally. This included a "Batch Edit Visible Tasks..." action that brought you into an edit workflow for every visible task on the board.

This was removed in D17879, probably by accident, since none of the support code was removed and the revision doesn't mention intending to remove it.

However, no one has noticed since then or requested this feature, so just get rid of it completely. You can generally perform this operation via queries in Maniphest with relative ease, anyway.

Later, in D18806, I made the UI consistently say "Bulk Edit" (previously, it sometimes said "Batch" and sometimes said "Bulk") but didn't change all the variable names. Now that this is getting some standalone testing, update the variable names to match the UI.

amckinley accepted this revision.Jul 2 2019, 9:37 PM
This revision is now accepted and ready to land.Jul 2 2019, 9:37 PM