Paths

Table of Contentst

Differential D20649

Fix a bad call to "writeInfo()" in "bin/phd stop" with no PHABRICATOR_INSTANCE defined
ClosedPublic
Actions

Authored by epriestley on Jul 12 2019, 3:41 PM.

Tags

None

Subscribers

None

Details

Reviewers

Commits

rPd2935fd7bdc2: Fix a bad call to "writeInfo()" in "bin/phd stop" with no PHABRICATOR_INSTANCE…

Summary

See https://discourse.phabricator-community.org/t/phd-status-calls-to-undefined-method-when-theres-no-instance/2918. This call should be logInfo().

Test Plan

Purged PHABRICATOR_INSTANCE from my environment. In a Phacility development environment, it comes from loading services/.
Ran bin/phd stop with all daemons already stopped.
- Before: bad call.
- After: helpful error.
Ran some other bin/phd start, bin/phd status, etc., to kick the tires.
Grepped for remaining writeInfo() calls (found none).

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Jul 12 2019, 3:41 PM

Harbormaster completed remote builds in B23129: Diff 49261.Jul 12 2019, 3:43 PM

epriestley requested review of this revision.Jul 12 2019, 3:43 PM

amckinley accepted this revision.Jul 12 2019, 4:14 PM

This revision is now accepted and ready to land.Jul 12 2019, 4:14 PM

Closed by commit rPd2935fd7bdc2: Fix a bad call to "writeInfo()" in "bin/phd stop" with no PHABRICATOR_INSTANCE… (authored by epriestley). · Explain WhyJul 12 2019, 4:15 PM

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPd2935fd7bdc2: Fix a bad call to "writeInfo()" in "bin/phd stop" with no PHABRICATOR_INSTANCE….

Revision Contents
Changeset List

Path

Size

src/

applications/

daemon/

management/

PhabricatorDaemonManagementStatusWorkflow.php

2 lines

Diff 49262

src/applications/daemon/management/PhabricatorDaemonManagementStatusWorkflow.php

Loading...