Page MenuHomePhabricator

Fix a bad call to "writeInfo()" in "bin/phd stop" with no PHABRICATOR_INSTANCE defined
ClosedPublic

Authored by epriestley on Jul 12 2019, 3:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jun 13, 7:56 PM
Unknown Object (File)
May 31 2025, 12:09 AM
Unknown Object (File)
May 30 2025, 9:23 AM
Unknown Object (File)
May 29 2025, 10:08 AM
Unknown Object (File)
May 28 2025, 8:08 AM
Unknown Object (File)
May 8 2025, 3:02 AM
Unknown Object (File)
Apr 30 2025, 12:57 PM
Unknown Object (File)
Apr 30 2025, 11:17 AM
Subscribers
None

Details

Summary
Test Plan
  • Purged PHABRICATOR_INSTANCE from my environment. In a Phacility development environment, it comes from loading services/.
  • Ran bin/phd stop with all daemons already stopped.
    • Before: bad call.
    • After: helpful error.
  • Ran some other bin/phd start, bin/phd status, etc., to kick the tires.
  • Grepped for remaining writeInfo() calls (found none).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable