Page MenuHomePhabricator

Fix a bad call to "writeInfo()" in "bin/phd stop" with no PHABRICATOR_INSTANCE defined
ClosedPublic

Authored by epriestley on Jul 12 2019, 3:41 PM.

Details

Summary
Test Plan
  • Purged PHABRICATOR_INSTANCE from my environment. In a Phacility development environment, it comes from loading services/.
  • Ran bin/phd stop with all daemons already stopped.
    • Before: bad call.
    • After: helpful error.
  • Ran some other bin/phd start, bin/phd status, etc., to kick the tires.
  • Grepped for remaining writeInfo() calls (found none).

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Jul 12 2019, 3:41 PM
epriestley requested review of this revision.Jul 12 2019, 3:43 PM
amckinley accepted this revision.Jul 12 2019, 4:14 PM
This revision is now accepted and ready to land.Jul 12 2019, 4:14 PM