Page MenuHomePhabricator

Fix a bad call to "writeInfo()" in "bin/phd stop" with no PHABRICATOR_INSTANCE defined
ClosedPublic

Authored by epriestley on Jul 12 2019, 3:41 PM.
Tags
None
Referenced Files
F19010755: D20649.diff
Sat, Nov 22, 6:21 AM
F18599142: D20649.diff
Sep 13 2025, 6:47 AM
F18593625: D20649.id49261.diff
Sep 12 2025, 3:26 PM
F18567131: D20649.id.diff
Sep 9 2025, 3:32 PM
F18564399: D20649.id.diff
Sep 9 2025, 9:48 AM
F18047783: D20649.id.diff
Aug 3 2025, 1:09 PM
F18036588: D20649.diff
Aug 3 2025, 2:04 AM
F18000336: D20649.diff
Aug 2 2025, 7:15 AM
Subscribers
None

Details

Summary
Test Plan
  • Purged PHABRICATOR_INSTANCE from my environment. In a Phacility development environment, it comes from loading services/.
  • Ran bin/phd stop with all daemons already stopped.
    • Before: bad call.
    • After: helpful error.
  • Ran some other bin/phd start, bin/phd status, etc., to kick the tires.
  • Grepped for remaining writeInfo() calls (found none).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable