Page MenuHomePhabricator
Feed All Stories

Feb 14 2018

epriestley merged task T5380: Better handling of anchored links in Phriction into T4280: Embed anchor in remark up text and later link to it. .
Feb 14 2018, 2:40 PM · Phriction, Remarkup
epriestley moved T5410: Make wiki creation dialog more user friendly from Backlog to Next on the Phriction board.
Feb 14 2018, 2:38 PM · Phriction
epriestley moved T5811: Phriction does not correctly save and restore document drafts of in-progress edits from Backlog to Next on the Phriction board.
Feb 14 2018, 2:38 PM · Phriction
epriestley moved T6610: Support per-section-editing in Phriction wiki from Backlog to Far Future on the Phriction board.
Feb 14 2018, 2:36 PM · Phriction
epriestley closed T8594: Develop system for dumping/backing up Phriction documents as Wontfix.

I'm going to roll this into T13077, which will provide full access to Phriction via the API. In combination with Webhooks, you could mirror everything into some external read-only backup system or just pipe every edit to lp and stick it in a binder or something.

Feb 14 2018, 2:35 PM · Phriction, Restricted Project
epriestley updated the task description for T13077: Plans: Phriction modern "v3" APIs, Drafts.
Feb 14 2018, 2:34 PM · Plans, Phriction
epriestley moved T10969: Incorrect Phriction link in email from Backlog to Next on the Phriction board.
Feb 14 2018, 2:33 PM · Phriction, Bug Report
epriestley moved T11163: Speed up wiki documents creation from Backlog to Next on the Phriction board.
Feb 14 2018, 2:32 PM · Phriction, Feature Request
epriestley moved T5941: Show Phriction Pages in Search Typeahead from Backlog to Next on the Phriction board.
Feb 14 2018, 2:32 PM · Phriction
epriestley moved T12793: Unable to move Phriction documents from Backlog to Next on the Phriction board.
Feb 14 2018, 2:31 PM · Customer Impact, Bug Report, Phriction
epriestley archived Badge Awarded.
Feb 14 2018, 2:31 PM
epriestley moved T1894: Support commenting on Phriction documents from Next to Future on the Phriction board.
Feb 14 2018, 2:31 PM · Restricted Project, Restricted Project, Phriction
epriestley closed T8900: Copying contents from Phriction history diff doesn't work as Resolved.

Mooted by the switch to prose diffing.

Feb 14 2018, 2:31 PM · Restricted Project, Infrastructure, Differential, Phriction
epriestley edited projects for T7878: strange "moved from" signal in [Phriction] diff, added: Differential; removed Phriction.
Feb 14 2018, 2:29 PM · Differential
epriestley moved T8552: Increase user control over document hierarchy in Phriction from Next to Future on the Phriction board.
Feb 14 2018, 2:28 PM · Phriction, Restricted Project
epriestley moved T8172: "Edit" button shouldn't be hidden in "Actions" from Next to Future on the Phriction board.
Feb 14 2018, 2:28 PM · FreeBSD, Restricted Project, Phriction
epriestley closed T9379: Build Phriction v3 as Resolved.

Rolling this forward into T13077.

Feb 14 2018, 2:24 PM · Phriction
epriestley triaged T13077: Plans: Phriction modern "v3" APIs, Drafts as Normal priority.
Feb 14 2018, 2:23 PM · Plans, Phriction
epriestley renamed T13076: Plans: Phacility cluster caching, renaming, and rebalance/compaction from Plans: Phacility cluster infrastructure improvements to Plans: Phacility cluster caching, renaming, and rebalance/compaction.
Feb 14 2018, 2:20 PM · Plans, Ops, Infrastructure, Phacility
epriestley closed T12217: Reduce the hardware cost of Phacility free instances as Invalid.

We no longer offer free instances and I don't currently plan to offer them again, so this is moot.

Feb 14 2018, 2:19 PM · Ops, Phacility
epriestley closed T12217: Reduce the hardware cost of Phacility free instances, a subtask of T12218: Reduce the operational cost of a larger Phacility cluster, as Invalid.
Feb 14 2018, 2:19 PM · Ops, Phacility
epriestley closed T12218: Reduce the operational cost of a larger Phacility cluster as Resolved.

We no longer offer free instances so tier growth is slower, and I plan to compact the tier in the nearish term.

Feb 14 2018, 2:18 PM · Ops, Phacility
epriestley closed T12298: Allow daemon pools to autoscale down to 0 processes, a subtask of T12217: Reduce the hardware cost of Phacility free instances, as Wontfix.
Feb 14 2018, 2:12 PM · Ops, Phacility
epriestley closed T12298: Allow daemon pools to autoscale down to 0 processes as Wontfix.

We no longer offer free instances so I don't currently plan to pursue this.

Feb 14 2018, 2:12 PM · Daemons, Ops, Phacility
epriestley triaged T13076: Plans: Phacility cluster caching, renaming, and rebalance/compaction as Normal priority.
Feb 14 2018, 2:10 PM · Plans, Ops, Infrastructure, Phacility
epriestley closed T7351: Improve storage scalability in the cluster, a subtask of T7346: Anticipate scaling challenges in the Phacility cluster, as Resolved.
Feb 14 2018, 2:03 PM · Phacility
epriestley closed T7351: Improve storage scalability in the cluster as Resolved.

We generally seem to have a reasonable handle on this after all.

Feb 14 2018, 2:03 PM · Phacility
epriestley removed a project from T6960: Support %P in qsprintf(): Phacility.
Feb 14 2018, 1:09 PM · Security, Infrastructure
michaeloa added a comment to T8936: Unable to identify the reftype of 'refs/remotes/origin/master'. Rejecting push..

So, in my case this turned out to be a well-known issue with git --mirror and the way pull-requests/branches are set up. I was able to clean up the issue for my purposes with this one-liner in the bare repository:

Feb 14 2018, 11:43 AM · Diffusion
epriestley triaged T13075: Plans: Diffusion authors, Herald ref rules, parsing, performance as Normal priority.
Feb 14 2018, 1:33 AM · Plans, Diffusion
epriestley merged T8747: "Path Does Not Exist" error caused by not standard characters into T7339: Raise a setup warning when the "en_US.UTF-8" locale is unavailable.
Feb 14 2018, 1:25 AM · Diffusion (v3)
epriestley merged task T8747: "Path Does Not Exist" error caused by not standard characters into T7339: Raise a setup warning when the "en_US.UTF-8" locale is unavailable.
Feb 14 2018, 1:25 AM · Diffusion
epriestley updated the task description for T13074: Plans: Workboard triggers, groups, and subproject columns.
Feb 14 2018, 12:36 AM · Workboards (v3), Plans, Projects
epriestley closed T12144: Ability to reorder milestones on a project's workboard as Wontfix.

I don't plan to support this because it makes improvements to milestones which depend on them being ordered ("move to next milestone", automatic date ranges, etc., per above) more complex to implement or use. All use cases here seem to be addressed by "use subprojects instead of milestones", especially after T11036. I'll make the ordering adjustment described above.

Feb 14 2018, 12:32 AM · Projects, Feature Request
epriestley added a project to T11036: Put subproject columns on workboards: Workboards.
Feb 14 2018, 12:28 AM · Workboards (v3), Projects (v3)

Feb 13 2018

epriestley closed T11377: Query-driven workboard columns as Wontfix.

I don't currently plan to implement this. I think T5474, T10333, T11036, and using the Maniphest list view with "Group By" address this use case to varying degrees (if you "Group By: Task Status" and then turn your monitor sideways, you pretty much get the desired result). It's possible we'll end up back here in the future, but since I'm not planning to scope this into T13074 I'm going to close it until those changes land and further use cases arise.

Feb 13 2018, 11:53 PM · Restricted Project, Workboards, Feature Request
epriestley closed T10946: Maniphest templates in project workboards? as Resolved.

Workboards have offered access to multiple task creation forms for some time.

Feb 13 2018, 11:45 PM · Workboards, Maniphest, Feature Request
epriestley triaged T10469: Implement "Tabs", an amazing feature where multiple different pages are loaded in the same browser window! as Wishlist priority.
Feb 13 2018, 11:44 PM · Quicksand, Feature Request, Workboards
epriestley moved T10469: Implement "Tabs", an amazing feature where multiple different pages are loaded in the same browser window! from Backlog to Far Future on the Workboards board.
Feb 13 2018, 11:44 PM · Quicksand, Feature Request, Workboards
epriestley closed T5523: Make bulk moves easier on Workboards as Resolved.

I think D18665 seems to generally have been satisfactory here, so I'm going to call this resolved until additional use cases arise.

Feb 13 2018, 11:43 PM · Restricted Project, Workboards
epriestley closed T4863: Allow Workboard Cards to be customized for display as Resolved.

This task is a giant mess with pretty much no remaining actionable use cases. See T13074 for plans. If you want some use case here included in that, file a description of your problem via support pact.

Feb 13 2018, 11:43 PM · Projects, Workboards, Wikimedia
epriestley closed T4863: Allow Workboard Cards to be customized for display, a subtask of T9520: Allow Workboards to show a thumbnail image within each card, as Resolved.
Feb 13 2018, 11:42 PM · Workboards
epriestley triaged T13074: Plans: Workboard triggers, groups, and subproject columns as Normal priority.
Feb 13 2018, 11:42 PM · Workboards (v3), Plans, Projects
epriestley closed T5100: Show work board column names as part of task basic information in query results and reference link popups, a subtask of T3670: Add subprojects, as Wontfix.
Feb 13 2018, 11:39 PM · KDE, Projects (v3), Restricted Project, FreeBSD, Wikimedia
epriestley closed T5100: Show work board column names as part of task basic information in query results and reference link popups as Wontfix.

I don't currently plan to do this. At a bare minimum, T5474 may moot it.

Feb 13 2018, 11:39 PM · Hovercards, Workboards, Maniphest
epriestley closed T10293: Plan rest of "CoverImage" feature as Resolved.

Some of this is fixed; the rest of it doesn't have outstanding customer requests.

Feb 13 2018, 11:38 PM · Workboards, Projects (v3)
epriestley closed T8236: `arc weld` should do something as Resolved by committing Restricted Diffusion Commit.
Feb 13 2018, 11:15 PM · Contributor Onboarding, Arcanist
epriestley added a revision to T8236: `arc weld` should do something: Unknown Object (Differential Revision).
Feb 13 2018, 11:12 PM · Contributor Onboarding, Arcanist
epriestley claimed T8236: `arc weld` should do something.
Feb 13 2018, 10:09 PM · Contributor Onboarding, Arcanist
epriestley updated the task description for T13073: Plans: Drydock for normal software use cases where builds take more than 45 seconds.
Feb 13 2018, 9:10 PM · Plans, Drydock
michaeloa added a comment to T8936: Unable to identify the reftype of 'refs/remotes/origin/master'. Rejecting push..

I'm seeing this currently on our brand-new phabricator install. git push --mirror worked for the first repository installed, but now on the second, this is happening.

Feb 13 2018, 7:53 PM · Diffusion
epriestley added a revision to T13073: Plans: Drydock for normal software use cases where builds take more than 45 seconds: Unknown Object (Differential Revision).
Feb 13 2018, 7:12 PM · Plans, Drydock
epriestley added a member for Community: brhodes.
Feb 13 2018, 6:26 PM
epriestley added a comment to T13073: Plans: Drydock for normal software use cases where builds take more than 45 seconds.

When a blueprint uses concurrency-limiting slot locks, it currently just returns a random lock if it can't find a slot it suspects is free. This makes "all slots look fill, waiting for something to free up" ambiguous with actual collisions. It would probably be better to distinguish between these cases and make it more clear which one we're in.

Feb 13 2018, 6:14 PM · Plans, Drydock
epriestley added a revision to T13073: Plans: Drydock for normal software use cases where builds take more than 45 seconds: Unknown Object (Differential Revision).
Feb 13 2018, 5:53 PM · Plans, Drydock
epriestley added a revision to T13073: Plans: Drydock for normal software use cases where builds take more than 45 seconds: Unknown Object (Differential Revision).
Feb 13 2018, 5:35 PM · Plans, Drydock
epriestley added a comment to T13073: Plans: Drydock for normal software use cases where builds take more than 45 seconds.

After the patches above, I can't reproduce any bad behavior for T11495 or T10559.

Feb 13 2018, 5:31 PM · Plans, Drydock
epriestley closed T11495: Drydock doesn't delete working copies as Invalid.

I'm unable to reproduce this by following the instructions provided, at least after changes in T13073. Here's what I did:

Feb 13 2018, 4:33 PM · Bug Report (Needs Information), Drydock
epriestley closed T10559: Lease Working Copy Hangs on lease failure, but should fail as Resolved.

After changes T13073, I am no longer able to reproduce this. That task has made some improvements and may have fixed whatever happened here.

Feb 13 2018, 4:03 PM · Drydock, Bug Report
epriestley updated the task description for T13073: Plans: Drydock for normal software use cases where builds take more than 45 seconds.
Feb 13 2018, 3:55 PM · Plans, Drydock
epriestley added a comment to T13073: Plans: Drydock for normal software use cases where builds take more than 45 seconds.

My HoaxBlueprint does not implement activateLease(). This causes leases to be broken and destroyed.

Feb 13 2018, 3:41 PM · Plans, Drydock
epriestley added a revision to T13073: Plans: Drydock for normal software use cases where builds take more than 45 seconds: Unknown Object (Differential Revision).
Feb 13 2018, 2:36 PM · Plans, Drydock
epriestley updated the task description for T13073: Plans: Drydock for normal software use cases where builds take more than 45 seconds.
Feb 13 2018, 2:35 PM · Plans, Drydock
epriestley added a comment to T13073: Plans: Drydock for normal software use cases where builds take more than 45 seconds.

Slightly more broadly: if the lease starts actually activating, we can't be sure that we can undo its state in the general case so we need to throw it away. But this failure (where the resource it has acquired doesn't activate) carries no such risk, and we can safely just throw it back in the pool. I think the only state we need to wipe out its its slot locks, which are easy to clean up.

Feb 13 2018, 2:31 PM · Plans, Drydock
epriestley added a comment to T13073: Plans: Drydock for normal software use cases where builds take more than 45 seconds.

Note that there's another similar scenario:

Feb 13 2018, 2:19 PM · Plans, Drydock
epriestley added a comment to T13073: Plans: Drydock for normal software use cases where builds take more than 45 seconds.

I just removed the setActivateWhenAcquired(true) for now without changing behavior. Next issue:

Feb 13 2018, 2:18 PM · Plans, Drydock
epriestley updated the task description for T13073: Plans: Drydock for normal software use cases where builds take more than 45 seconds.
Feb 13 2018, 1:58 PM · Plans, Drydock
epriestley added a comment to T13073: Plans: Drydock for normal software use cases where builds take more than 45 seconds.

Alright, next issue:

Feb 13 2018, 1:56 PM · Plans, Drydock
epriestley added a revision to T13073: Plans: Drydock for normal software use cases where builds take more than 45 seconds: Unknown Object (Differential Revision).
Feb 13 2018, 1:40 PM · Plans, Drydock
epriestley updated the task description for T13073: Plans: Drydock for normal software use cases where builds take more than 45 seconds.
Feb 13 2018, 1:24 PM · Plans, Drydock
epriestley added a revision to T13073: Plans: Drydock for normal software use cases where builds take more than 45 seconds: Unknown Object (Differential Revision).
Feb 13 2018, 1:14 PM · Plans, Drydock
epriestley added a revision to T13073: Plans: Drydock for normal software use cases where builds take more than 45 seconds: Unknown Object (Differential Revision).
Feb 13 2018, 12:24 PM · Plans, Drydock
epriestley added a comment to T13073: Plans: Drydock for normal software use cases where builds take more than 45 seconds.

Leases and resources don't use standard header UI tags to indicate status:

Feb 13 2018, 12:14 PM · Plans, Drydock
epriestley added a revision to T13073: Plans: Drydock for normal software use cases where builds take more than 45 seconds: Unknown Object (Differential Revision).
Feb 13 2018, 11:50 AM · Plans, Drydock
epriestley added a revision to T13073: Plans: Drydock for normal software use cases where builds take more than 45 seconds: Unknown Object (Differential Revision).
Feb 13 2018, 11:37 AM · Plans, Drydock
epriestley added a revision to T13073: Plans: Drydock for normal software use cases where builds take more than 45 seconds: Unknown Object (Differential Revision).
Feb 13 2018, 11:36 AM · Plans, Drydock
epriestley added a comment to T13073: Plans: Drydock for normal software use cases where builds take more than 45 seconds.

When logs span multiple lines, they are rendered as unreadable garbage messes:

Feb 13 2018, 11:29 AM · Plans, Drydock
epriestley added a comment to T13073: Plans: Drydock for normal software use cases where builds take more than 45 seconds.

When blueprints claim to be able to allocate resources but fail during allocation, we currently destroy the lease. I think this is likely too severe: consider an EC2 blueprint where the allocation call fails for some temporary reason (EC2 just fails, or we hit the account limit for instances, or whatever else).

Feb 13 2018, 11:00 AM · Plans, Drydock
epriestley added a comment to T13073: Plans: Drydock for normal software use cases where builds take more than 45 seconds.

In trying to plot a course through this, I'd like to try to sequence this so that existing issues get fixed first, then breaking changes happen afterward (maybe in the next release). Some of these changes (particularly, the CustomField-to-EditField change) will be significantly disruptive to existing custom code. (That change is also pretty straightforward and new stuff depends on it, so I'd probably start there if there was no compatibility concern.)

Feb 13 2018, 10:30 AM · Plans, Drydock

Feb 12 2018

epriestley renamed T13073: Plans: Drydock for normal software use cases where builds take more than 45 seconds from Plans: Drydock to Plans: Drydock for normal software use cases where builds take more than 45 seconds.
Feb 12 2018, 11:26 PM · Plans, Drydock
epriestley updated the task description for T13073: Plans: Drydock for normal software use cases where builds take more than 45 seconds.
Feb 12 2018, 11:17 PM · Plans, Drydock
epriestley updated the task description for T13072: Merge Harbormaster BuildCommand into BuildMessage.
Feb 12 2018, 11:04 PM · Harbormaster
epriestley closed T13054: Plans: Harbormaster Interactions with Differential / Chaos Reduction as Resolved.

See T13072 for Harbormaster followups.

Feb 12 2018, 11:03 PM · Plans, Differential, Harbormaster
epriestley updated the task description for T13054: Plans: Harbormaster Interactions with Differential / Chaos Reduction.
Feb 12 2018, 11:02 PM · Plans, Differential, Harbormaster
epriestley triaged T13073: Plans: Drydock for normal software use cases where builds take more than 45 seconds as Normal priority.
Feb 12 2018, 11:02 PM · Plans, Drydock
epriestley triaged T13072: Merge Harbormaster BuildCommand into BuildMessage as Wishlist priority.
Feb 12 2018, 11:01 PM · Harbormaster
epriestley moved T11195: Drydock's working copy should run "git lfs fetch && git lfs checkout" for repositories known to use Git LFS from Backlog to Far Future on the Drydock board.
Feb 12 2018, 10:58 PM · Drydock, Feature Request
epriestley closed T9811: Make it easier to diagnose command failures occurring inside Drydock allocations as Wontfix.

This doesn't really describe anything actionable.

Feb 12 2018, 10:58 PM · Drydock
epriestley removed projects from T12180: Cropped text in Property List: Drydock, Bug Report.
Feb 12 2018, 10:57 PM · PHUI
epriestley closed T1816: Support downloading a compressed working copy (tar/zip) of a repository at a specific commit or tag as Wontfix.

This is something we could reasonably build now, but I think we're unlikely to build it without a customer request and an actual use case. Closing until those materialize.

Feb 12 2018, 10:56 PM · Drydock, Diffusion
epriestley moved T12935: Automatically detect merge-ability in Differential from Backlog to Future on the Drydock board.
Feb 12 2018, 10:54 PM · Customer Impact, Harbormaster, Drydock, Differential
cspeckmim added a comment to T12688: Inline Comment Design Opportunities for Improvement.

In Chrome (Version 64.0.3282.140 (Official Build) (64-bit)) the inline comment buttons have a hot-spot for tooltips to party

Feb 12 2018, 10:31 PM · Design, Differential, Inline Comments
epriestley updated the task description for T13054: Plans: Harbormaster Interactions with Differential / Chaos Reduction.
Feb 12 2018, 10:02 PM · Plans, Differential, Harbormaster
epriestley added a revision to T13054: Plans: Harbormaster Interactions with Differential / Chaos Reduction: Unknown Object (Differential Revision).
Feb 12 2018, 9:04 PM · Plans, Differential, Harbormaster
epriestley added a comment to T2334: Implement Google Calendar v3 API into Calendar.

See Planning.

Feb 12 2018, 8:49 PM · Restricted Project, Prioritized, Calendar
gadi.rotenberg added a comment to T2334: Implement Google Calendar v3 API into Calendar.

Is there someone working on this feature?

Feb 12 2018, 8:48 PM · Restricted Project, Prioritized, Calendar
epriestley updated the task description for T13054: Plans: Harbormaster Interactions with Differential / Chaos Reduction.
Feb 12 2018, 8:37 PM · Plans, Differential, Harbormaster
epriestley added a revision to T13054: Plans: Harbormaster Interactions with Differential / Chaos Reduction: Unknown Object (Differential Revision).
Feb 12 2018, 8:11 PM · Plans, Differential, Harbormaster
epriestley added a revision to T13054: Plans: Harbormaster Interactions with Differential / Chaos Reduction: Restricted Differential Revision.
Feb 12 2018, 7:54 PM · Plans, Differential, Harbormaster
epriestley added a revision to T13054: Plans: Harbormaster Interactions with Differential / Chaos Reduction: Restricted Differential Revision.
Feb 12 2018, 7:09 PM · Plans, Differential, Harbormaster