Page MenuHomePhabricator

Inline Comment Design Opportunities for Improvement
Closed, ResolvedPublic

Description

Just a log of under-designed stuff that could maybe use design work, as I run into it.

Event Timeline

epriestley triaged this task as Wishlist priority.May 8 2017, 5:32 PM

In View OptionsCollapse File, we get into this sort of oldschool state:

Screen Shot 2017-05-08 at 10.28.31 AM.png (163×1 px, 28 KB)

  • It looks sort of okay but a little inconsistent with modern design.
  • Border/margin behavior is a touch cramped, particularly.
  • The text "Undo" should probably be "Expand".
  • I'd sort of maybe like to make all these inline actions ("Undo", "Show Generated Code", etc) become buttons? Not sure.

This stuff is probably going to churn for a bit but I'm pretty sure I'll forget about that thing if I don't write it down somewhere.

Everyone loves Opportunities For Improvement!

Just noting that this cat is perfect and DOES NOT need any design improvement:

cat3.png (400×400 px, 3 KB)

Just a note for me so I don't forget thanks

All of the inline comment icons got mis-aligned slightly a while ago. This is particularly visible with "Reply", I think. Note that the tooltip is centered, but the icon is too low (I think?) and too far to the right.

Screen Shot 2017-05-15 at 2.11.50 PM.png (132×107 px, 6 KB)

This is going to get even worse:

Screen Shot 2017-05-16 at 9.07.50 AM.png (909×635 px, 82 KB)

max-height: 600px; overflow: scroll;

We currently have three distinct selection states which I think are a little muddy. The first is the keyboard selection cursor, which shows what is selected with the keyboard:

Screen Shot 2017-05-17 at 4.57.22 AM.png (145×2 px, 25 KB)

You can also now make a "keyboard selection" by clicking the header of an inline.

The second is the "hover/edit/select" cursor, which is visible when dragging a line range to add a comment; hovering over an inline to see the lines it affects; or editing an inline (this bit is a little whack at HEAD):

Screen Shot 2017-05-17 at 4.57.16 AM.png (139×1 px, 12 KB)

The third is the "anchor" cursor, which is visible when you follow an anchor (/D123#inline-456) to an inline:

Screen Shot 2017-05-17 at 4.57.38 AM.png (124×1 px, 18 KB)

I don't think these are necessarily unclear or insufficently-designed, but they do feel a little utilitarian and maybe represent an opportunity for improvement. One issue with the current design is that we historically did some z-index magic to avoid these elements catching mouse events, but using pointer-events: none in CSS appears to solve this without creating any issues (although caniuse.org claims they don't work in IE8/9/10, so maybe I'm actually leading us down a bit of a dark path here).

The keyboard reticle, particularly, is now significantly more robust than it was in the past, and could focus inlines differently (e.g., just put a glow or "selected state" around the inline itself rather than drawing a full reticle).

(These states are mostly JS magic so I might have to be the one to actually implement any changes we pursue here, or I could do a patch which changes the highlight-inline behavior from "show the reticle" to "add a class" with bad epriestley design and you could tweak it if you wanted to pursue this.)

I may play around with these a bit more myself but they currently don't feel too bad to me, just a little less-than-ideal.

On mobile, the hamburger menu icon is not aligned properly:

Screen Shot 2017-05-17 at 7.11.37 AM.png (464×617 px, 32 KB)

Unified diffs have stray border coloration (all devices, I think). Specifically, the green border under the left "5":

Screen Shot 2017-05-17 at 7.12.18 AM.png (177×312 px, 14 KB)

In this screenshot:

  • Inline header feels a little bloated? Probably not too tough to make less-bad, but I'm not sure what we can really do here to make it good. Maybe no great low-effort fix. We could do something like tap-to-reveal-actions maybe? Or shove everything in a hamburger menu?
  • The bottom of the screenshot (under the "no-timestamp") line shows that the element has a double border. It looks a little like a dropdshadow but I think it's just a mundane extra border.

Screen Shot 2017-05-17 at 7.35.09 AM.png (504×760 px, 36 KB)

Not exactly related, but these cancel buttons used to be grey and are now blue:

Screen Shot 2017-06-12 at 9.56.33 AM.png (304×933 px, 22 KB)

In Chrome (Version 64.0.3282.140 (Official Build) (64-bit)) the inline comment buttons have a hot-spot for tooltips to party

Doesn't happen in Firefox 58.0.2 (though the cursor does blink a bit). Both browsers checked on Mac

In Chrome (Version 64.0.3282.140 (Official Build) (64-bit)) the inline comment buttons have a hot-spot for tooltips to party

I can't immediately reproduce this in modern Chrome -- presuming something got fixed at some point.


I think everything (?) else here got fixed too, some of it recently.