Page MenuHomePhabricator

Drydock's working copy should run "git lfs fetch && git lfs checkout" for repositories known to use Git LFS
Open, Needs TriagePublic


We started using Git LFS in a repository and didn't realise that Git LFS checkout / fetch wasn't something that happened automatically as part of git checkout So our binary assets didn't get converted from the Git LFS pointers to the real files, and when we built and packaged a release, we found that the assets were invalid (because they contained the pointer info instead of the actual file).

For now we can workaround the issue by adding git lfs fetch && git lfs checkout to our Harbormaster build plan after the working copy is obtained, but it'd be far better to have Drydock doing this so we're not running these commands for repositories that don't use Git LFS.

Event Timeline

epriestley added a subscriber: epriestley.

Offhand, I'm surprised by this. I expect LFS smudging to be a side effect of git checkout and for all Drydock working copy construction pathways to invoke git checkout. This appears consistent with advice from the LFS upstream (albeit a year or so old):

However, I haven't actually run this flow myself.

joshuaspence updated the task description. (Show Details)
joshuaspence added a subscriber: joshuaspence.

We have a similar issue - however I think the "fix" is probably worse then the workaround.

In our case we have not run the git lfs install command on our builders - so the .gitconfig is missing the smudge commands.

When a new drydock resource is created, the LFS files are not present until a git lfs fetch and git lfs checkout are run exactly like described in the bug report.

If git lfs install was run prior to initial clone, the performance of that operation would be very slow since GIT_LFS_SKIP_SMUDGE=1 is not configured... and even if it was you would still need to perform an initial lfs fetch afterwards.

Back when this was originally reported, I'm pretty sure git lfs clone didn't exist (or at least I wasn't aware of it's existence). The appropriate fix now is probably different to the fix suggested in the original report.